mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-04-15 17:24:10 +00:00
Remove app/Space folder and extract model business logic into services
Relocate all 14 files from the catch-all app/Space namespace into proper locations: data providers to Support/Formatters, installation utilities to Services/Installation, PDF utils to Services/Pdf, module/update classes to Services/Module and Services/Update, SiteApi trait to Traits, and helpers to Support. Extract ~1,400 lines of business logic from 8 fat models (Invoice, Payment, Estimate, RecurringInvoice, Company, Customer, Expense, User) into 9 new service classes with constructor injection. Controllers now depend on services instead of calling static model methods. Shared item/tax creation logic consolidated into DocumentItemService.
This commit is contained in:
@@ -8,11 +8,16 @@ use App\Http\Requests\CompaniesRequest;
|
||||
use App\Http\Resources\CompanyResource;
|
||||
use App\Models\Company;
|
||||
use App\Models\User;
|
||||
use App\Services\CompanyService;
|
||||
use Illuminate\Http\Request;
|
||||
use Silber\Bouncer\BouncerFacade;
|
||||
|
||||
class CompaniesController extends Controller
|
||||
{
|
||||
public function __construct(
|
||||
private readonly CompanyService $companyService,
|
||||
) {}
|
||||
|
||||
public function store(CompaniesRequest $request)
|
||||
{
|
||||
$this->authorize('create company');
|
||||
@@ -22,7 +27,7 @@ class CompaniesController extends Controller
|
||||
$company = Company::create($request->getCompanyPayload());
|
||||
$company->unique_hash = Hashids::connection(Company::class)->encode($company->id);
|
||||
$company->save();
|
||||
$company->setupDefaultData();
|
||||
$this->companyService->setupDefaults($company);
|
||||
$user->companies()->attach($company->id);
|
||||
$user->assign('super admin');
|
||||
|
||||
@@ -49,7 +54,7 @@ class CompaniesController extends Controller
|
||||
return respondJson('You_cannot_delete_all_companies', 'You cannot delete all companies');
|
||||
}
|
||||
|
||||
$company->deleteCompany($user);
|
||||
$this->companyService->delete($company, $user);
|
||||
|
||||
return response()->json([
|
||||
'success' => true,
|
||||
|
||||
Reference in New Issue
Block a user