QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-04-16 01:34:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove app/Space folder and extract model business logic into services

Browse Source 
Relocate all 14 files from the catch-all app/Space namespace into proper
locations: data providers to Support/Formatters, installation utilities to
Services/Installation, PDF utils to Services/Pdf, module/update classes to
Services/Module and Services/Update, SiteApi trait to Traits, and helpers
to Support.

Extract ~1,400 lines of business logic from 8 fat models (Invoice, Payment,
Estimate, RecurringInvoice, Company, Customer, Expense, User) into 9 new
service classes with constructor injection. Controllers now depend on
services instead of calling static model methods. Shared item/tax creation
logic consolidated into DocumentItemService.
This commit is contained in:
Darko Gjorgjijoski
2026-04-03 15:37:22 +02:00
parent 23ff69026e
commit 0ce88ab817
98 changed files with 1703 additions and 1563 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
app/Http/Controllers/V1/Admin/Estimate/EstimatesController.php
View File

@@ -8,10 +8,15 @@ use App\Http\Requests\EstimatesRequest;
use App\Http\Resources\EstimateResource;
use App\Jobs\GenerateEstimatePdfJob;
use App\Models\Estimate;
use App\Services\EstimateService;
use Illuminate\Http\Request;
class EstimatesController extends Controller
{
public function __construct(
private readonly EstimateService $estimateService,
) {}
public function index(Request $request)
{
$this->authorize('viewAny', Estimate::class);
@@ -35,10 +40,10 @@ class EstimatesController extends Controller
{
$this->authorize('create', Estimate::class);
$estimate = Estimate::createEstimate($request);
$estimate = $this->estimateService->create($request);
if ($request->has('estimateSend')) {
$estimate->send($request->title, $request->body);
$this->estimateService->send($estimate, $request->only(['title', 'body']));
}
GenerateEstimatePdfJob::dispatch($estimate);
@@ -57,7 +62,7 @@ class EstimatesController extends Controller
{
$this->authorize('update', $estimate);
$estimate = $estimate->updateEstimate($request);
$estimate = $this->estimateService->update($estimate, $request);
GenerateEstimatePdfJob::dispatch($estimate, true);