mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-04-15 09:14:08 +00:00
Remove app/Space folder and extract model business logic into services
Relocate all 14 files from the catch-all app/Space namespace into proper locations: data providers to Support/Formatters, installation utilities to Services/Installation, PDF utils to Services/Pdf, module/update classes to Services/Module and Services/Update, SiteApi trait to Traits, and helpers to Support. Extract ~1,400 lines of business logic from 8 fat models (Invoice, Payment, Estimate, RecurringInvoice, Company, Customer, Expense, User) into 9 new service classes with constructor injection. Controllers now depend on services instead of calling static model methods. Shared item/tax creation logic consolidated into DocumentItemService.
This commit is contained in:
@@ -7,11 +7,16 @@ use App\Http\Requests\DeleteExpensesRequest;
|
||||
use App\Http\Requests\ExpenseRequest;
|
||||
use App\Http\Resources\ExpenseResource;
|
||||
use App\Models\Expense;
|
||||
use App\Services\ExpenseService;
|
||||
use Illuminate\Http\JsonResponse;
|
||||
use Illuminate\Http\Request;
|
||||
|
||||
class ExpensesController extends Controller
|
||||
{
|
||||
public function __construct(
|
||||
private readonly ExpenseService $expenseService,
|
||||
) {}
|
||||
|
||||
/**
|
||||
* Display a listing of the resource.
|
||||
*
|
||||
@@ -46,7 +51,7 @@ class ExpensesController extends Controller
|
||||
{
|
||||
$this->authorize('create', Expense::class);
|
||||
|
||||
$expense = Expense::createExpense($request);
|
||||
$expense = $this->expenseService->create($request);
|
||||
|
||||
return new ExpenseResource($expense);
|
||||
}
|
||||
@@ -72,7 +77,7 @@ class ExpensesController extends Controller
|
||||
{
|
||||
$this->authorize('update', $expense);
|
||||
|
||||
$expense->updateExpense($request);
|
||||
$this->expenseService->update($expense, $request);
|
||||
|
||||
return new ExpenseResource($expense);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user