mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-04-15 17:24:10 +00:00
Remove app/Space folder and extract model business logic into services
Relocate all 14 files from the catch-all app/Space namespace into proper locations: data providers to Support/Formatters, installation utilities to Services/Installation, PDF utils to Services/Pdf, module/update classes to Services/Module and Services/Update, SiteApi trait to Traits, and helpers to Support. Extract ~1,400 lines of business logic from 8 fat models (Invoice, Payment, Estimate, RecurringInvoice, Company, Customer, Expense, User) into 9 new service classes with constructor injection. Controllers now depend on services instead of calling static model methods. Shared item/tax creation logic consolidated into DocumentItemService.
This commit is contained in:
@@ -6,11 +6,16 @@ use App\Http\Controllers\Controller;
|
||||
use App\Http\Requests\RecurringInvoiceRequest;
|
||||
use App\Http\Resources\RecurringInvoiceResource;
|
||||
use App\Models\RecurringInvoice;
|
||||
use App\Services\RecurringInvoiceService;
|
||||
use Illuminate\Http\Request;
|
||||
use Illuminate\Http\Response;
|
||||
|
||||
class RecurringInvoiceController extends Controller
|
||||
{
|
||||
public function __construct(
|
||||
private readonly RecurringInvoiceService $recurringInvoiceService,
|
||||
) {}
|
||||
|
||||
/**
|
||||
* Display a listing of the resource.
|
||||
*
|
||||
@@ -42,7 +47,7 @@ class RecurringInvoiceController extends Controller
|
||||
{
|
||||
$this->authorize('create', RecurringInvoice::class);
|
||||
|
||||
$recurringInvoice = RecurringInvoice::createFromRequest($request);
|
||||
$recurringInvoice = $this->recurringInvoiceService->create($request);
|
||||
|
||||
return new RecurringInvoiceResource($recurringInvoice);
|
||||
}
|
||||
@@ -69,7 +74,7 @@ class RecurringInvoiceController extends Controller
|
||||
{
|
||||
$this->authorize('update', $recurringInvoice);
|
||||
|
||||
$recurringInvoice->updateFromRequest($request);
|
||||
$this->recurringInvoiceService->update($recurringInvoice, $request);
|
||||
|
||||
return new RecurringInvoiceResource($recurringInvoice);
|
||||
}
|
||||
@@ -88,7 +93,7 @@ class RecurringInvoiceController extends Controller
|
||||
->whereIn('id', $request->ids)
|
||||
->pluck('id');
|
||||
|
||||
RecurringInvoice::deleteRecurringInvoice($ids);
|
||||
$this->recurringInvoiceService->delete($ids);
|
||||
|
||||
return response()->json([
|
||||
'success' => true,
|
||||
|
||||
Reference in New Issue
Block a user