QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-04-19 03:04:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove app/Space folder and extract model business logic into services

Browse Source 
Relocate all 14 files from the catch-all app/Space namespace into proper
locations: data providers to Support/Formatters, installation utilities to
Services/Installation, PDF utils to Services/Pdf, module/update classes to
Services/Module and Services/Update, SiteApi trait to Traits, and helpers
to Support.

Extract ~1,400 lines of business logic from 8 fat models (Invoice, Payment,
Estimate, RecurringInvoice, Company, Customer, Expense, User) into 9 new
service classes with constructor injection. Controllers now depend on
services instead of calling static model methods. Shared item/tax creation
logic consolidated into DocumentItemService.
This commit is contained in:
Darko Gjorgjijoski
2026-04-03 15:37:22 +02:00
parent 23ff69026e
commit 0ce88ab817
98 changed files with 1703 additions and 1563 deletions
Download Patch File Download Diff File Expand all files Collapse all files

69
app/Services/DocumentItemService.php Normal file
View File

@@ -0,0 +1,69 @@
<?php
namespace App\Services;
use Illuminate\Database\Eloquent\Model;
class DocumentItemService
{
public function createItems(Model $document, array $items): void
{
$exchangeRate = $document->exchange_rate;
foreach ($items as $item) {
$item['company_id'] = $document->company_id;
$item['exchange_rate'] = $exchangeRate;
$item['base_price'] = $item['price'] * $exchangeRate;
$item['base_discount_val'] = $item['discount_val'] * $exchangeRate;
$item['base_tax'] = $item['tax'] * $exchangeRate;
$item['base_total'] = $item['total'] * $exchangeRate;
if (array_key_exists('recurring_invoice_id', $item)) {
unset($item['recurring_invoice_id']);
}
$createdItem = $document->items()->create($item);
if (array_key_exists('taxes', $item) && $item['taxes']) {
foreach ($item['taxes'] as $tax) {
$tax['company_id'] = $document->company_id;
$tax['exchange_rate'] = $document->exchange_rate;
$tax['base_amount'] = $tax['amount'] * $exchangeRate;
$tax['currency_id'] = $document->currency_id;
if (gettype($tax['amount']) !== 'NULL') {
if (array_key_exists('recurring_invoice_id', $tax)) {
unset($tax['recurring_invoice_id']);
}
$createdItem->taxes()->create($tax);
}
}
}
if (array_key_exists('custom_fields', $item) && $item['custom_fields']) {
$createdItem->addCustomFields($item['custom_fields']);
}
}
}
public function createTaxes(Model $document, array $taxes): void
{
$exchangeRate = $document->exchange_rate;
foreach ($taxes as $tax) {
$tax['company_id'] = $document->company_id;
$tax['exchange_rate'] = $document->exchange_rate;
$tax['base_amount'] = $tax['amount'] * $exchangeRate;
$tax['currency_id'] = $document->currency_id;
if (gettype($tax['amount']) !== 'NULL') {
if (array_key_exists('recurring_invoice_id', $tax)) {
unset($tax['recurring_invoice_id']);
}
$document->taxes()->create($tax);
}
}
}
}