mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-17 06:15:20 +00:00
fix(security): recompute document totals server-side (GHSA-8c69) (#665)
Invoice/estimate/recurring-invoice creation and update accepted total, sub_total, tax and due_amount straight from the request with no server-side recalculation, so a client could persist financial totals that don't match the line items (and, on invoice update, corrupt the due-amount/paid-amount logic which keyed off the client total). - Adds App\Support\DocumentTotals which recomputes item totals (round(price * quantity) minus per-item discount) and document totals (sub_total, tax with per-item vs document and tax_included handling, total, due_amount), mirroring the front-end calculation. Only price/quantity/discounts/tax-line amounts are trusted. - getInvoicePayload/getEstimatePayload/getRecurringInvoicePayload override the client totals with the recomputed values; createItems recomputes each stored item total; Invoice::updateInvoice keys its due-amount/paid-amount logic off the recomputed total instead of the request total. Adds DocumentTotals unit tests + a feature test proving a tampered invoice total is ignored. Existing create/update tests no longer assert the (now server-authoritative) derived totals.
This commit is contained in:
committed by
GitHub
parent
d615cfb4ff
commit
107a951126
@@ -5,6 +5,7 @@ namespace App\Http\Requests;
|
||||
use App\Models\CompanySetting;
|
||||
use App\Models\Customer;
|
||||
use App\Models\RecurringInvoice;
|
||||
use App\Support\DocumentTotals;
|
||||
use Illuminate\Foundation\Http\FormRequest;
|
||||
|
||||
class RecurringInvoiceRequest extends FormRequest
|
||||
@@ -106,15 +107,35 @@ class RecurringInvoiceRequest extends FormRequest
|
||||
|
||||
$nextInvoiceAt = RecurringInvoice::getNextInvoiceDate($this->frequency, $this->starts_at);
|
||||
|
||||
$tax_per_item = CompanySetting::getSetting('tax_per_item', $this->header('company')) ?? 'NO ';
|
||||
$discount_per_item = CompanySetting::getSetting('discount_per_item', $this->header('company')) ?? 'NO';
|
||||
|
||||
// Recompute totals server-side from the line items (GHSA-8c69). The
|
||||
// recurring template totals propagate to every generated invoice.
|
||||
$totals = DocumentTotals::compute(
|
||||
$this->items ?? [],
|
||||
$this->taxes ?? [],
|
||||
$this->discount_val,
|
||||
$tax_per_item,
|
||||
(bool) $this->tax_included,
|
||||
$discount_per_item
|
||||
);
|
||||
|
||||
return collect($this->except('items', 'taxes'))
|
||||
->merge([
|
||||
'creator_id' => $this->user()->id,
|
||||
'company_id' => $this->header('company'),
|
||||
'next_invoice_at' => $nextInvoiceAt,
|
||||
'tax_per_item' => CompanySetting::getSetting('tax_per_item', $this->header('company')) ?? 'NO ',
|
||||
'discount_per_item' => CompanySetting::getSetting('discount_per_item', $this->header('company')) ?? 'NO',
|
||||
'due_amount' => $this->total,
|
||||
'tax_per_item' => $tax_per_item,
|
||||
'discount_per_item' => $discount_per_item,
|
||||
'sub_total' => $totals['sub_total'],
|
||||
'total' => $totals['total'],
|
||||
'tax' => $totals['tax'],
|
||||
'due_amount' => $totals['total'],
|
||||
'exchange_rate' => $exchange_rate,
|
||||
'base_sub_total' => $totals['sub_total'] * $exchange_rate,
|
||||
'base_total' => $totals['total'] * $exchange_rate,
|
||||
'base_tax' => $totals['tax'] * $exchange_rate,
|
||||
'currency_id' => $currency,
|
||||
])
|
||||
->toArray();
|
||||
|
||||
Reference in New Issue
Block a user