QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-08-05 07:32:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(invoices): require settlement before completion (#739)

Browse Source
This commit is contained in:
Darko Gjorgjijoski
2026-08-02 17:02:29 +02:00
committed by GitHub
parent 00c9c4268e
commit 1e72d9d449
7 changed files with 184 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/Feature/Admin/CreditNoteTest.php
View File

@@ -905,18 +905,24 @@ test('no surviving row keeps a dangling related invoice reference', function ()
expect(Invoice::find($creditNote->id)->related_invoice_id)->toBeNull();
});
test('completing an uncredited invoice still zeroes its balance', function () {
test('completing a fully credited invoice is idempotent', function () {
$invoice = creditableInvoice();
postJson("api/v1/invoices/{$invoice->id}/credit-note")
->assertStatus(201);
postJson("api/v1/invoices/{$invoice->id}/status", ['status' => Invoice::STATUS_COMPLETED])
->assertOk();
$invoice->refresh();
// The credit-note bookkeeping must not touch the manual status change.
// Completion verifies the recorded credit note and does not disturb the
// already-settled balance.
expect((int) $invoice->due_amount)->toBe(0)
->and((int) $invoice->base_due_amount)->toBe(0)
->and($invoice->status)->toBe(Invoice::STATUS_COMPLETED)
->and($invoice->paid_status)->toBe(Invoice::STATUS_PAID);
->and($invoice->paid_status)->toBe(Invoice::STATUS_PAID)
->and($invoice->payments)->toHaveCount(0);
});
test('renders a credit note pdf through the original invoice template family, not a hardcoded layout', function () {