Refactor FileDisk system with per-disk unique names and disk assignments UI

Major changes to the file disk subsystem:

- Each FileDisk now gets a unique Laravel disk name (disk_{id}) instead
  of temp_{driver}, fixing the bug where multiple local disks with
  different roots overwrote each other's config.

- Move disk registration logic from FileDisk model to FileDiskService
  (registerDisk, getDiskName). Model keeps only getDecodedCredentials
  and a deprecated setConfig() wrapper.

- Add Disk Assignments admin UI (File Disk tab) with three purpose
  dropdowns: Media Storage, PDF Storage, Backup Storage. Stored as
  settings (media_disk_id, pdf_disk_id, backup_disk_id).

- Backup tab now uses the assigned backup disk instead of a per-backup
  dropdown. BackupsController refactored to use BackupService which
  centralizes disk resolution. Removed stale 4-second cache.

- Add local_public disk to config/filesystems.php so system disks
  are properly defined.

- Local disk roots stored relative to storage/app/ with hint text
  in the admin modal explaining the convention.

- Fix BaseModal watchEffect -> watch to prevent infinite request
  loops on the File Disk page.

- Fix string/number comparison for disk purpose IDs from settings.

- Add safeguards: prevent deleting disks with files, warn on
  purpose change, prevent deleting system disks.
This commit is contained in:
Darko Gjorgjijoski
2026-04-07 02:04:57 +02:00
parent ea1fc9b799
commit 20085cab5d
20 changed files with 492 additions and 258 deletions

View File

@@ -1,5 +1,5 @@
<script setup lang="ts">
import { computed, ref, watch } from 'vue'
import { computed, ref } from 'vue'
import { useI18n } from 'vue-i18n'
import { useModalStore } from '@v2/stores/modal.store'
import { useDialogStore } from '@v2/stores/dialog.store'
@@ -20,10 +20,6 @@ interface TableColumn {
sortable?: boolean
}
interface DiskOption extends Disk {
display_name: string
}
interface FetchParams {
page: number
filter: Record<string, unknown>
@@ -46,8 +42,7 @@ const notificationStore = useNotificationStore()
const { t } = useI18n()
const table = ref<{ refresh: () => void } | null>(null)
const disks = ref<DiskOption[]>([])
const selectedDisk = ref<DiskOption | null>(null)
const backupDisk = ref<Disk | null>(null)
const isFetchingInitialData = ref(false)
const backupError = ref('')
@@ -68,6 +63,12 @@ const backupColumns = computed<TableColumn[]>(() => [
label: t('settings.backup.size'),
tdClass: 'font-medium text-heading',
},
{
key: 'disk_name',
label: t('settings.disk.title', 1),
tdClass: 'font-medium text-muted',
sortable: false,
},
{
key: 'actions',
label: '',
@@ -76,30 +77,27 @@ const backupColumns = computed<TableColumn[]>(() => [
},
])
watch(
selectedDisk,
(newDisk, oldDisk) => {
if (newDisk?.id && oldDisk?.id && newDisk.id !== oldDisk.id) {
refreshTable()
}
}
)
loadBackupDisk()
loadDisks()
async function loadDisks(): Promise<void> {
async function loadBackupDisk(): Promise<void> {
isFetchingInitialData.value = true
try {
const response = await diskService.list({ limit: 'all' })
const [diskResponse, purposesResponse] = await Promise.all([
diskService.list({ limit: 'all' }),
diskService.getDiskPurposes(),
])
disks.value = response.data.map((disk) => ({
...disk,
display_name: `${disk.name} - [${disk.driver}]`,
}))
const disks = diskResponse.data
const backupDiskId = purposesResponse.backup_disk_id
selectedDisk.value =
disks.value.find((disk) => disk.set_as_default) ?? disks.value[0] ?? null
backupDisk.value =
(backupDiskId ? disks.find((disk) => disk.id === Number(backupDiskId)) : null) ??
disks.find((disk) => disk.set_as_default) ??
disks[0] ??
null
// Refresh table now that we know which disk to query
refreshTable()
} catch (error: unknown) {
showApiError(error)
} finally {
@@ -108,7 +106,7 @@ async function loadDisks(): Promise<void> {
}
async function fetchData({ page }: FetchParams): Promise<FetchResult> {
if (!selectedDisk.value) {
if (!backupDisk.value) {
return emptyResult(page)
}
@@ -116,8 +114,8 @@ async function fetchData({ page }: FetchParams): Promise<FetchResult> {
try {
const response = await backupService.list({
disk: selectedDisk.value.driver,
file_disk_id: selectedDisk.value.id,
disk: backupDisk.value.driver,
file_disk_id: backupDisk.value.id,
})
if (response.error) {
@@ -142,7 +140,7 @@ async function fetchData({ page }: FetchParams): Promise<FetchResult> {
}
async function removeBackup(backup: Backup): Promise<void> {
if (!selectedDisk.value) {
if (!backupDisk.value) {
return
}
@@ -162,8 +160,8 @@ async function removeBackup(backup: Backup): Promise<void> {
try {
const response = await backupService.delete({
disk: selectedDisk.value.driver,
file_disk_id: selectedDisk.value.id,
disk: backupDisk.value.driver,
file_disk_id: backupDisk.value.id,
path: backup.path,
})
@@ -180,7 +178,7 @@ async function removeBackup(backup: Backup): Promise<void> {
}
async function downloadBackup(backup: Backup): Promise<void> {
if (!selectedDisk.value) {
if (!backupDisk.value) {
return
}
@@ -189,8 +187,8 @@ async function downloadBackup(backup: Backup): Promise<void> {
try {
const blob = await backupService.download({
disk: selectedDisk.value.driver,
file_disk_id: selectedDisk.value.id,
disk: backupDisk.value.driver,
file_disk_id: backupDisk.value.id,
path: backup.path,
})
@@ -216,13 +214,16 @@ async function downloadBackup(backup: Backup): Promise<void> {
}
function openCreateBackupModal(): void {
if (!backupDisk.value) {
return
}
modalStore.openModal({
title: t('settings.backup.create_backup'),
componentName: 'AdminBackupModal',
size: 'sm',
data: {
disks: disks.value,
selectedDiskId: selectedDisk.value?.id ?? null,
file_disk_id: backupDisk.value.id,
},
refreshData: table.value?.refresh,
})
@@ -271,26 +272,6 @@ function showApiError(error: unknown): void {
</BaseButton>
</template>
<div class="grid my-14 md:grid-cols-3">
<BaseInputGroup
:label="$t('settings.disk.select_disk')"
:content-loading="isFetchingInitialData"
>
<BaseMultiselect
v-model="selectedDisk"
:content-loading="isFetchingInitialData"
:options="disks"
track-by="id"
value-prop="id"
label="display_name"
:placeholder="$t('settings.disk.select_disk')"
object
searchable
class="w-full"
/>
</BaseInputGroup>
</div>
<BaseErrorAlert
v-if="backupError"
class="mt-6"
@@ -304,6 +285,10 @@ function showApiError(error: unknown): void {
:data="fetchData"
:columns="backupColumns"
>
<template #cell-disk_name>
{{ backupDisk?.name ?? '-' }}
</template>
<template #cell-actions="{ row }">
<BaseDropdown>
<template #activator>