Consolidate single-action controllers into resource controllers

Merge 11 single-action controllers into their parent resource controllers:
- Invoice: send, sendPreview, clone, changeStatus -> InvoicesController
- Estimate: send, sendPreview, clone, convertToInvoice, changeStatus -> EstimatesController
- Payment: send, sendPreview -> PaymentsController

Extract clone and convert business logic from controllers into services:
- InvoiceService: add clone(), changeStatus()
- EstimateService: add clone(), convertToInvoice(), changeStatus()

Previously this logic was inlined in controllers (~80-90 lines each).

app/Http/Controllers/V1/Admin/Estimate/ChangeEstimateStatusController.php

@@ -1,27 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\V1\Admin\Estimate;
-
-use App\Http\Controllers\Controller;
-use App\Models\Estimate;
-use Illuminate\Http\Request;
-use Illuminate\Http\Response;
-
-class ChangeEstimateStatusController extends Controller
-{
-    /**
-     * Handle the incoming request.
-     *
-     * @return Response
-     */
-    public function __invoke(Request $request, Estimate $estimate)
-    {
-        $this->authorize('send estimate', $estimate);
-
-        $estimate->update($request->only('status'));
-
-        return response()->json([
-            'success' => true,
-        ]);
-    }
-}

app/Http/Controllers/V1/Admin/Estimate/CloneEstimateController.php

@@ -1,133 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\V1\Admin\Estimate;
-
-use App\Facades\Hashids;
-use App\Http\Controllers\Controller;
-use App\Http\Resources\EstimateResource;
-use App\Models\CompanySetting;
-use App\Models\Estimate;
-use App\Services\SerialNumberService;
-use Carbon\Carbon;
-use Illuminate\Http\JsonResponse;
-use Illuminate\Http\Request;
-
-class CloneEstimateController extends Controller
-{
-    /**
-     * Mail a specific invoice to the corresponding customer's email address.
-     *
-     * @return JsonResponse
-     */
-    public function __invoke(Request $request, Estimate $estimate)
-    {
-        $this->authorize('view', $estimate);
-        $this->authorize('create', Estimate::class);
-
-        $date = Carbon::now();
-
-        $serial = (new SerialNumberService)
-            ->setModel($estimate)
-            ->setCompany($estimate->company_id)
-            ->setCustomer($estimate->customer_id)
-            ->setNextNumbers();
-
-        $due_date = null;
-        $dueDateEnabled = CompanySetting::getSetting(
-            'estimate_set_expiry_date_automatically',
-            $request->header('company')
-        );
-
-        if ($dueDateEnabled === 'YES') {
-            $dueDateDays = intval(CompanySetting::getSetting(
-                'estimate_expiry_date_days',
-                $request->header('company')
-            ));
-            $due_date = Carbon::now()->addDays($dueDateDays)->format('Y-m-d');
-        }
-
-        $exchange_rate = $estimate->exchange_rate;
-
-        $newEstimate = Estimate::create([
-            'estimate_date' => $date->format('Y-m-d'),
-            'expiry_date' => $due_date,
-            'estimate_number' => $serial->getNextNumber(),
-            'sequence_number' => $serial->nextSequenceNumber,
-            'customer_sequence_number' => $serial->nextCustomerSequenceNumber,
-            'reference_number' => $estimate->reference_number,
-            'customer_id' => $estimate->customer_id,
-            'company_id' => $request->header('company'),
-            'template_name' => $estimate->template_name,
-            'status' => Estimate::STATUS_DRAFT,
-            'sub_total' => $estimate->sub_total,
-            'discount' => $estimate->discount,
-            'discount_type' => $estimate->discount_type,
-            'discount_val' => $estimate->discount_val,
-            'total' => $estimate->total,
-            'due_amount' => $estimate->total,
-            'tax_per_item' => $estimate->tax_per_item,
-            'discount_per_item' => $estimate->discount_per_item,
-            'tax' => $estimate->tax,
-            'notes' => $estimate->notes,
-            'exchange_rate' => $exchange_rate,
-            'base_total' => $estimate->total * $exchange_rate,
-            'base_discount_val' => $estimate->discount_val * $exchange_rate,
-            'base_sub_total' => $estimate->sub_total * $exchange_rate,
-            'base_tax' => $estimate->tax * $exchange_rate,
-            'base_due_amount' => $estimate->total * $exchange_rate,
-            'currency_id' => $estimate->currency_id,
-            'sales_tax_type' => $estimate->sales_tax_type,
-            'sales_tax_address_type' => $estimate->sales_tax_address_type,
-        ]);
-
-        $newEstimate->unique_hash = Hashids::connection(Estimate::class)->encode($newEstimate->id);
-        $newEstimate->save();
-        $estimate->load('items.taxes');
-
-        $estimateItems = $estimate->items->toArray();
-
-        foreach ($estimateItems as $estimateItem) {
-            $estimateItem['company_id'] = $request->header('company');
-            $estimateItem['name'] = $estimateItem['name'];
-            $estimateItem['exchange_rate'] = $exchange_rate;
-            $estimateItem['base_price'] = $estimateItem['price'] * $exchange_rate;
-            $estimateItem['base_discount_val'] = $estimateItem['discount_val'] * $exchange_rate;
-            $estimateItem['base_tax'] = $estimateItem['tax'] * $exchange_rate;
-            $estimateItem['base_total'] = $estimateItem['total'] * $exchange_rate;
-
-            $item = $newEstimate->items()->create($estimateItem);
-
-            if (array_key_exists('taxes', $estimateItem) && $estimateItem['taxes']) {
-                foreach ($estimateItem['taxes'] as $tax) {
-                    $tax['company_id'] = $request->header('company');
-
-                    if ($tax['amount']) {
-                        $item->taxes()->create($tax);
-                    }
-                }
-            }
-        }
-
-        if ($estimate->taxes) {
-            foreach ($estimate->taxes->toArray() as $tax) {
-                $tax['company_id'] = $request->header('company');
-                $newEstimate->taxes()->create($tax);
-            }
-        }
-
-        if ($estimate->fields()->exists()) {
-            $customFields = [];
-
-            foreach ($estimate->fields as $data) {
-                $customFields[] = [
-                    'id' => $data->custom_field_id,
-                    'value' => $data->defaultAnswer,
-                ];
-            }
-
-            $newEstimate->addCustomFields($customFields);
-        }
-
-        return new EstimateResource($newEstimate);
-    }
-}

app/Http/Controllers/V1/Admin/Estimate/ConvertEstimateController.php

@@ -1,133 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\V1\Admin\Estimate;
-
-use App\Facades\Hashids;
-use App\Http\Controllers\Controller;
-use App\Http\Resources\InvoiceResource;
-use App\Models\CompanySetting;
-use App\Models\Estimate;
-use App\Models\Invoice;
-use App\Services\SerialNumberService;
-use Carbon\Carbon;
-use Illuminate\Http\Request;
-use Illuminate\Http\Response;
-use Illuminate\Support\Facades\Auth;
-
-class ConvertEstimateController extends Controller
-{
-    /**
-     * Handle the incoming request.
-     *
-     * @return Response
-     */
-    public function __invoke(Request $request, Estimate $estimate, Invoice $invoice)
-    {
-        $this->authorize('create', Invoice::class);
-
-        $estimate->load(['items', 'items.taxes', 'customer', 'taxes']);
-
-        $invoice_date = Carbon::now();
-        $due_date = null;
-
-        $dueDateEnabled = CompanySetting::getSetting(
-            'invoice_set_due_date_automatically',
-            $request->header('company')
-        );
-
-        if ($dueDateEnabled === 'YES') {
-            $dueDateDays = intval(CompanySetting::getSetting(
-                'invoice_due_date_days',
-                $request->header('company')
-            ));
-            $due_date = Carbon::now()->addDays($dueDateDays)->format('Y-m-d');
-        }
-
-        $serial = (new SerialNumberService)
-            ->setModel($invoice)
-            ->setCompany($estimate->company_id)
-            ->setCustomer($estimate->customer_id)
-            ->setNextNumbers();
-
-        $templateName = $estimate->getInvoiceTemplateName();
-
-        $exchange_rate = $estimate->exchange_rate;
-
-        $invoice = Invoice::create([
-            'creator_id' => Auth::id(),
-            'invoice_date' => $invoice_date->format('Y-m-d'),
-            'due_date' => $due_date,
-            'invoice_number' => $serial->getNextNumber(),
-            'sequence_number' => $serial->nextSequenceNumber,
-            'customer_sequence_number' => $serial->nextCustomerSequenceNumber,
-            'reference_number' => $serial->getNextNumber(),
-            'customer_id' => $estimate->customer_id,
-            'company_id' => $request->header('company'),
-            'template_name' => $templateName,
-            'status' => Invoice::STATUS_DRAFT,
-            'paid_status' => Invoice::STATUS_UNPAID,
-            'sub_total' => $estimate->sub_total,
-            'discount' => $estimate->discount,
-            'discount_type' => $estimate->discount_type,
-            'discount_val' => $estimate->discount_val,
-            'total' => $estimate->total,
-            'due_amount' => $estimate->total,
-            'tax_per_item' => $estimate->tax_per_item,
-            'discount_per_item' => $estimate->discount_per_item,
-            'tax' => $estimate->tax,
-            'notes' => $estimate->notes,
-            'exchange_rate' => $exchange_rate,
-            'base_discount_val' => $estimate->discount_val * $exchange_rate,
-            'base_sub_total' => $estimate->sub_total * $exchange_rate,
-            'base_total' => $estimate->total * $exchange_rate,
-            'base_tax' => $estimate->tax * $exchange_rate,
-            'currency_id' => $estimate->currency_id,
-            'sales_tax_type' => $estimate->sales_tax_type,
-            'sales_tax_address_type' => $estimate->sales_tax_address_type,
-        ]);
-
-        $invoice->unique_hash = Hashids::connection(Invoice::class)->encode($invoice->id);
-        $invoice->save();
-        $invoiceItems = $estimate->items->toArray();
-
-        foreach ($invoiceItems as $invoiceItem) {
-            $invoiceItem['company_id'] = $request->header('company');
-            $invoiceItem['name'] = $invoiceItem['name'];
-            $estimateItem['exchange_rate'] = $exchange_rate;
-            $estimateItem['base_price'] = $invoiceItem['price'] * $exchange_rate;
-            $estimateItem['base_discount_val'] = $invoiceItem['discount_val'] * $exchange_rate;
-            $estimateItem['base_tax'] = $invoiceItem['tax'] * $exchange_rate;
-            $estimateItem['base_total'] = $invoiceItem['total'] * $exchange_rate;
-
-            $item = $invoice->items()->create($invoiceItem);
-
-            if (array_key_exists('taxes', $invoiceItem) && $invoiceItem['taxes']) {
-                foreach ($invoiceItem['taxes'] as $tax) {
-                    $tax['company_id'] = $request->header('company');
-
-                    if ($tax['amount']) {
-                        $item->taxes()->create($tax);
-                    }
-                }
-            }
-        }
-
-        if ($estimate->taxes) {
-            foreach ($estimate->taxes->toArray() as $tax) {
-                $tax['company_id'] = $request->header('company');
-                $tax['exchange_rate'] = $exchange_rate;
-                $tax['base_amount'] = $tax['amount'] * $exchange_rate;
-                $tax['currency_id'] = $estimate->currency_id;
-                unset($tax['estimate_id']);
-
-                $invoice->taxes()->create($tax);
-            }
-        }
-
-        $estimate->checkForEstimateConvertAction();
-
-        $invoice = Invoice::find($invoice->id);
-
-        return new InvoiceResource($invoice);
-    }
-}

app/Http/Controllers/V1/Admin/Estimate/EstimatesController.php

@@ -5,11 +5,15 @@ namespace App\Http\Controllers\V1\Admin\Estimate;
 use App\Http\Controllers\Controller;
 use App\Http\Requests\DeleteEstimatesRequest;
 use App\Http\Requests\EstimatesRequest;
+use App\Http\Requests\SendEstimatesRequest;
 use App\Http\Resources\EstimateResource;
+use App\Http\Resources\InvoiceResource;
 use App\Jobs\GenerateEstimatePdfJob;
 use App\Models\Estimate;
+use App\Models\Invoice;
 use App\Services\EstimateService;
 use Illuminate\Http\Request;
+use Illuminate\Mail\Markdown;
 
 class EstimatesController extends Controller
 {
@@ -83,4 +87,55 @@ class EstimatesController extends Controller
             'success' => true,
         ]);
     }
+
+    public function send(SendEstimatesRequest $request, Estimate $estimate)
+    {
+        $this->authorize('send estimate', $estimate);
+
+        $response = $this->estimateService->send($estimate, $request->all());
+
+        return response()->json($response);
+    }
+
+    public function sendPreview(SendEstimatesRequest $request, Estimate $estimate)
+    {
+        $this->authorize('send estimate', $estimate);
+
+        $markdown = new Markdown(view(), config('mail.markdown'));
+
+        $data = $this->estimateService->sendEstimateData($estimate, $request->all());
+        $data['url'] = $estimate->estimatePdfUrl;
+
+        return $markdown->render('emails.send.estimate', ['data' => $data]);
+    }
+
+    public function clone(Request $request, Estimate $estimate)
+    {
+        $this->authorize('view', $estimate);
+        $this->authorize('create', Estimate::class);
+
+        $newEstimate = $this->estimateService->clone($estimate);
+
+        return new EstimateResource($newEstimate);
+    }
+
+    public function convertToInvoice(Request $request, Estimate $estimate)
+    {
+        $this->authorize('create', Invoice::class);
+
+        $invoice = $this->estimateService->convertToInvoice($estimate);
+
+        return new InvoiceResource($invoice);
+    }
+
+    public function changeStatus(Request $request, Estimate $estimate)
+    {
+        $this->authorize('send estimate', $estimate);
+
+        $this->estimateService->changeStatus($estimate, $request->status);
+
+        return response()->json([
+            'success' => true,
+        ]);
+    }
 }

app/Http/Controllers/V1/Admin/Estimate/SendEstimateController.php

@@ -1,30 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\V1\Admin\Estimate;
-
-use App\Http\Controllers\Controller;
-use App\Http\Requests\SendEstimatesRequest;
-use App\Models\Estimate;
-use App\Services\EstimateService;
-use Illuminate\Http\JsonResponse;
-
-class SendEstimateController extends Controller
-{
-    public function __construct(
-        private readonly EstimateService $estimateService,
-    ) {}
-
-    /**
-     * Handle the incoming request.
-     *
-     * @return JsonResponse
-     */
-    public function __invoke(SendEstimatesRequest $request, Estimate $estimate)
-    {
-        $this->authorize('send estimate', $estimate);
-
-        $response = $this->estimateService->send($estimate, $request->all());
-
-        return response()->json($response);
-    }
-}

app/Http/Controllers/V1/Admin/Estimate/SendEstimatePreviewController.php

@@ -1,34 +0,0 @@
-<?php
-
-namespace App\Http\Controllers\V1\Admin\Estimate;
-
-use App\Http\Controllers\Controller;
-use App\Http\Requests\SendEstimatesRequest;
-use App\Models\Estimate;
-use App\Services\EstimateService;
-use Illuminate\Http\JsonResponse;
-use Illuminate\Mail\Markdown;
-
-class SendEstimatePreviewController extends Controller
-{
-    public function __construct(
-        private readonly EstimateService $estimateService,
-    ) {}
-
-    /**
-     * Handle the incoming request.
-     *
-     * @return JsonResponse
-     */
-    public function __invoke(SendEstimatesRequest $request, Estimate $estimate)
-    {
-        $this->authorize('send estimate', $estimate);
-
-        $markdown = new Markdown(view(), config('mail.markdown'));
-
-        $data = $this->estimateService->sendEstimateData($estimate, $request->all());
-        $data['url'] = $estimate->estimatePdfUrl;
-
-        return $markdown->render('emails.send.estimate', ['data' => $data]);
-    }
-}