QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-08-04 23:22:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(pdf): give both drivers one contract, and fix what that was hiding (#727)

Browse Source 
PdfDriver and ResponseStream existed but nothing implemented them. The factory
returned the vendor dompdf wrapper for one driver and a bespoke class for the
other, so the two were never held to the same shape. Three things had slipped
through that gap.

Report PDFs answered 403 for everyone. The five report routes carry no company
header, so ScopeBouncer is not in their middleware stack and the ability scope
was never set; 'view-financial-reports' is stored scoped to a company, so the
check could not pass. They now scope to the company named in the URL. The policy
still checks membership, so this grants nothing new. Also firstOrFail() on the
hash lookup, so an unknown company is a 404 rather than a 500 on a null.

Report downloads were fatal on Gotenberg. GotenbergPdfResponse had no download(),
and the report controllers are its only callers. Added, alongside stream() and
output(), with the whole set now on the interface.

Streamed documents carried an HTTP preamble. GeneratesPdfTrait wrapped
$pdf->stream() -- already a Response -- in another response()->make(), which
stringified it and prepended "HTTP/1.0 200 OK" plus headers to the file. Readers
scan the first kilobyte for %PDF so nobody noticed, but the bytes were malformed.
Passing ->output() fixes it, and the render test now asserts the position.

Two driver-parity settings, both checked against a real gotenberg:8 rather than
inferred: emulateScreenMediaType(), because Chromium defaults to print media
while config/dompdf.php renders as screen, so a @media print rule applied on one
driver and not the other; and printBackground(), which turns out to affect only
the root background, since Chromium paints element backgrounds either way. No
stock template sets a body background, so that one changes nothing today and is
here to keep custom templates consistent across drivers.

Claude-Session: https://claude.ai/code/session_01QmECndmNZwzN65Zz9P87dF
This commit is contained in:
Darko Gjorgjijoski
2026-08-01 12:43:31 +02:00
committed by GitHub
parent a8cbcda835
commit 6cb754da60
18 changed files with 379 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/Http/Controllers/Company/Report/ProfitLossReportController.php
View File

@@ -13,6 +13,7 @@ use Carbon\Carbon;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\App;
use Silber\Bouncer\BouncerFacade;
class ProfitLossReportController extends Controller
{
@@ -24,7 +25,14 @@ class ProfitLossReportController extends Controller
*/
public function __invoke(Request $request, $hash)
{
$company = Company::where('unique_hash', $hash)->first();
$company = Company::where('unique_hash', $hash)->firstOrFail();
// These routes carry no company header, so ScopeBouncer is not in their
// middleware stack and the ability scope was never set. 'view-financial-reports'
// is stored scoped to a company, so the unscoped check always failed and every
// report PDF answered 403. Scope to the company named in the URL: the policy
// still checks membership, so this grants nothing new.
BouncerFacade::scope()->to($company->id);
$this->authorize('view report', $company);