QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-04-15 17:24:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(menu): priority-sorted menu groups, user-menu items, sidebar appearance toggle

Browse Source 
Every main_menu entry moves from numeric group (1/2/3) to string-based group + group_label + priority. Groups now carry their own i18n label and child entries are sorted by an explicit priority field instead of config-array order, so module-contributed menu items can slot into any existing group at any position.

BootstrapController merges module-registered menu items into main_menu (previously they lived in a separate module_menu response key) and introduces a user_menu response key for items modules want to place in the avatar dropdown. The global store follows suit: moduleMenu becomes userMenu, menuGroups is a computed that sorts by priority, and hasActiveModules drops out.

New admin Appearance setting page with a single toggle for whether sidebar group labels render — so instances that prefer a compact sidebar can hide the Documents/Administration/Modules headings without losing the grouping itself. CompanyLayout watches route meta and re-bootstraps when the admin-mode flag flips so the sidebar repaints with the right menu on navigation across the admin boundary.

Test suites updated: module menu merging is asserted against main_menu (name: 'module-{slug}') rather than the old module_menu response; HelloWorldIntegrationTest verifies the schema translation path; CompanyModulesIndexTest covers the display_name attachment.
This commit is contained in:
Darko Gjorgjijoski
2026-04-11 00:30:00 +02:00
parent 345bfde306
commit 7885bf9d11
17 changed files with 246 additions and 148 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
tests/Feature/Company/Modules/BootstrapModuleMenuTest.php
View File

@@ -24,7 +24,7 @@ afterEach(function () {
Registry::flush();
});
test('bootstrap returns module_menu populated from Registry', function () {
test('bootstrap merges module menu items into main_menu', function () {
Registry::registerMenu('sales-tax-us', [
'title' => 'sales_tax_us::menu.title',
'link' => '/admin/modules/sales-tax-us/settings',
@@ -33,18 +33,43 @@ test('bootstrap returns module_menu populated from Registry', function () {
$response = getJson('api/v1/bootstrap')->assertOk();
$response->assertJsonPath('module_menu.0.title', 'sales_tax_us::menu.title');
$response->assertJsonPath('module_menu.0.link', '/admin/modules/sales-tax-us/settings');
$response->assertJsonPath('module_menu.0.icon', 'CalculatorIcon');
$mainMenu = collect($response->json('main_menu'));
$moduleItem = $mainMenu->firstWhere('name', 'module-sales-tax-us');
expect($moduleItem)->not->toBeNull();
expect($moduleItem['link'])->toBe('/admin/modules/sales-tax-us/settings');
expect($moduleItem['icon'])->toBe('CalculatorIcon');
expect($moduleItem['group'])->toBe('modules');
});
test('bootstrap returns empty module_menu when nothing is registered', function () {
getJson('api/v1/bootstrap')
->assertOk()
->assertJsonPath('module_menu', []);
test('module items support custom group and priority', function () {
Registry::registerMenu('sales-tax-us', [
'title' => 'sales_tax_us::menu.title',
'link' => '/admin/modules/sales-tax-us/settings',
'icon' => 'CalculatorIcon',
'group' => 'documents',
'priority' => 25,
]);
$response = getJson('api/v1/bootstrap')->assertOk();
$mainMenu = collect($response->json('main_menu'));
$moduleItem = $mainMenu->firstWhere('name', 'module-sales-tax-us');
expect($moduleItem['group'])->toBe('documents');
expect($moduleItem['priority'])->toBe(25);
});
test('admin-mode bootstrap does not include module_menu', function () {
test('bootstrap has no module items when nothing is registered', function () {
$response = getJson('api/v1/bootstrap')->assertOk();
$mainMenu = collect($response->json('main_menu'));
$moduleItems = $mainMenu->filter(fn ($item) => str_starts_with($item['name'], 'module-'));
expect($moduleItems)->toBeEmpty();
});
test('admin-mode bootstrap does not include module items', function () {
Registry::registerMenu('sales-tax-us', [
'title' => 'sales_tax_us::menu.title',
'link' => '/admin/modules/sales-tax-us/settings',
@@ -53,7 +78,8 @@ test('admin-mode bootstrap does not include module_menu', function () {
$response = getJson('api/v1/bootstrap?admin_mode=1');
// Super-admin branch should not include the dynamic Modules sidebar group —
// that surface only exists in the company context.
$response->assertJsonMissingPath('module_menu');
$mainMenu = collect($response->json('main_menu'));
$moduleItems = $mainMenu->filter(fn ($item) => str_starts_with($item['name'] ?? '', 'module-'));
expect($moduleItems)->toBeEmpty();
});