QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-07-20 15:55:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(services): move Updater to app/Support/Update

Browse Source 
Updater is a pure static procedural class — all eight public methods (checkForUpdate, download, unzip, copyFiles, deleteFiles, cleanStaleFiles, migrateUpdate, finishUpdate) are static, there's no constructor, no DI, no instance state. It's stateless self-update plumbing, same character as the Setup/ helpers that moved to Support/ in commit 6d1816bd.

Moving it out of Services/ leaves Services/ exclusively for DI-injected classes with real business logic, which is the contract the reorg was aiming for. Update/ now lives next to Setup/ in Support/ where the other install/upgrade-time utilities live.

Only 3 consumers needed touching: UpdateController, UpdateCommand, and a reference in config/invoiceshelf.php's comment. 350 tests still pass.
This commit is contained in:
Darko Gjorgjijoski
2026-04-11 12:30:00 +02:00
parent 947d00a9f1
commit 7cf72b9f1d
4 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Console/Commands/UpdateCommand.php
View File

@@ -2,7 +2,7 @@
namespace App\Console\Commands; namespace App\Console\Commands;
use App\Services\Update\Updater; use App\Support\Update\Updater;
use Illuminate\Console\Command; use Illuminate\Console\Command;
use Illuminate\Support\Facades\File; use Illuminate\Support\Facades\File;

2
app/Http/Controllers/Admin/UpdateController.php
View File

@@ -3,7 +3,7 @@
namespace App\Http\Controllers\Admin; namespace App\Http\Controllers\Admin;
use App\Http\Controllers\Controller; use App\Http\Controllers\Controller;
use App\Services\Update\Updater; use App\Support\Update\Updater;
use Illuminate\Http\JsonResponse; use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request; use Illuminate\Http\Request;
use Illuminate\Support\Facades\File; use Illuminate\Support\Facades\File;

2
app/Services/Update/Updater.php → app/Support/Update/Updater.php
View File

@@ -1,6 +1,6 @@
<?php <?php
namespace App\Services\Update; namespace App\Support\Update;
use App\Events\UpdateFinished; use App\Events\UpdateFinished;
use App\Models\Setting; use App\Models\Setting;

2
config/invoiceshelf.php
View File

@@ -45,7 +45,7 @@ return [
* Marketplace and updater base URL. * Marketplace and updater base URL.
* *
* The marketplace client (App\Services\Module\ModuleInstaller) and the * The marketplace client (App\Services\Module\ModuleInstaller) and the
* updater (App\Services\Update\Updater) both build their HTTP client base * updater (App\Support\Update\Updater) both build their HTTP client base
* URI from this value via App\Traits\SiteApi::getRemote(). Override via * URI from this value via App\Traits\SiteApi::getRemote(). Override via
* INVOICESHELF_BASE_URL in .env to point a self-hosted instance or local * INVOICESHELF_BASE_URL in .env to point a self-hosted instance or local
* dev environment at a non-production marketplace (e.g. a local checkout * dev environment at a non-production marketplace (e.g. a local checkout