QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-07-16 22:05:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(services): move ModuleInstaller to app/Support/Module

Browse Source 
ModuleInstaller has the same shape as Updater (moved in 7cf72b9f): every method is public static, no constructor, no DI, no instance state. It orchestrates marketplace operations — fetch catalog, download zip, verify checksum, unzip, copy files, run module:migrate/module:enable, dispatch install/enable events — but the orchestration itself is stateless procedural plumbing.

Emitting events and writing to the Module eloquent model doesn't make it a service; plenty of static helpers touch models. The distinguishing factor is stateless-procedural vs DI-injected-workflow, and this is clearly the former.

4 consumers updated: ModulesController, ModuleInstallationController, InstallModuleCommand, and a doc comment in config/invoiceshelf.php. 350 tests still pass.

This leaves app/Services/ with no single-file driver-less subdirs except Mail/Module/Pdf/Storage which have multiple files each. The Module/ subdir in Services is now deleted entirely — the marketplace installer moved out and there were no other files in there.
This commit is contained in:
Darko Gjorgjijoski
2026-04-11 13:30:00 +02:00
parent 7cf72b9f1d
commit 8cc4a6fa98
5 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/Console/Commands/InstallModuleCommand.php
View File

@@ -2,7 +2,7 @@
namespace App\Console\Commands;
use App\Services\Module\ModuleInstaller;
use App\Support\Module\ModuleInstaller;
use Illuminate\Console\Command;
class InstallModuleCommand extends Command