QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-09-02 05:10:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(modules): add safe module uninstall lifecycle (#746)

Browse Source 
* fix(modules): recover from missing runtime files

* feat(modules): add safe uninstall lifecycle

* build(deps): lock module SDK 3.2.0

* test(modules): expect SDK 3.2 scaffold constraint
This commit is contained in:
Darko Gjorgjijoski
2026-08-05 12:15:29 +02:00
committed by GitHub
parent 8579e4f85f
commit a34bf0909f
27 changed files with 1251 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Controllers/Admin/Modules/ModuleInstallationController.php
+21
View File
@@ -4,7 +4,9 @@ namespace App\Http\Controllers\Admin\Modules;
use App\Http\Controllers\Controller;
use App\Http\Requests\InstallMarketplaceModuleRequest;
use App\Http\Requests\UninstallMarketplaceModuleRequest;
use App\Services\Marketplace\MarketplaceInstaller;
use App\Services\Marketplace\MarketplaceUninstaller;
use Illuminate\Http\JsonResponse;
class ModuleInstallationController extends Controller
@@ -21,4 +23,23 @@ class ModuleInstallationController extends Controller
return response()->json($response, $response['success'] ? 200 : 422);
}
public function uninstall(string $module, UninstallMarketplaceModuleRequest $request, MarketplaceUninstaller $uninstaller): JsonResponse
{
$this->authorize('manage modules');
$response = $uninstaller->uninstall(
$module,
$request->boolean('remove_data'),
$request->string('confirmation')->toString() ?: null,
);
$status = match ($response['error'] ?? null) {
'module_not_installed' => 404,
'operation_in_progress', 'module_runtime_missing', 'dependent_modules_installed' => 409,
default => $response['success'] ? 200 : 422,
};
return response()->json($response, $status);
}
}
app/Http/Controllers/Admin/Modules/ModulesController.php
+41 -9
View File
@@ -7,9 +7,9 @@ use App\Events\ModuleEnabledEvent;
use App\Http\Controllers\Controller;
use App\Http\Resources\ModuleResource;
use App\Models\Module as ModelsModule;
use App\Services\Marketplace\DatabaseActivator;
use App\Services\Marketplace\MarketplaceClient;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Nwidart\Modules\Facades\Module;
class ModulesController extends Controller
@@ -52,31 +52,63 @@ class ModulesController extends Controller
]]);
}
public function enable(Request $request, string $module): JsonResponse
public function enable(string $module): JsonResponse
{
$this->authorize('manage modules');
$module = ModelsModule::where('name', $module)->first();
$module->update(['enabled' => true]);
$module = ModelsModule::query()
->where('name', $module)
->where('installed', true)
->firstOrFail();
$installedModule = Module::find($module->name);
if ($installedModule === null) {
$this->markRuntimeMissing($module);
return response()->json([
'success' => false,
'error' => 'module_runtime_missing',
], 409);
}
$installedModule->enable();
$module->refresh();
ModuleEnabledEvent::dispatch($module);
return response()->json(['success' => true]);
}
public function disable(Request $request, string $module): JsonResponse
public function disable(string $module, DatabaseActivator $activator): JsonResponse
{
$this->authorize('manage modules');
$module = ModelsModule::where('name', $module)->first();
$module->update(['enabled' => false]);
$installedModule = Module::find($module->name);
$installedModule->disable();
$module = ModelsModule::query()
->where('name', $module)
->where('installed', true)
->firstOrFail();
$activator->setActiveByName($module->name, false);
if (Module::find($module->name) === null) {
$this->markRuntimeMissing($module);
} else {
$module->refresh();
}
ModuleDisabledEvent::dispatch($module);
return response()->json(['success' => true]);
}
private function markRuntimeMissing(ModelsModule $module): void
{
$module->update([
'installed' => false,
'enabled' => false,
'state' => 'failed',
'last_error' => 'module_runtime_missing',
'last_failed_at' => now(),
]);
}
}