QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-09-02 13:21:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(modules): add safe module uninstall lifecycle (#746)

Browse Source 
* fix(modules): recover from missing runtime files

* feat(modules): add safe uninstall lifecycle

* build(deps): lock module SDK 3.2.0

* test(modules): expect SDK 3.2 scaffold constraint
This commit is contained in:
Darko Gjorgjijoski
2026-08-05 12:15:29 +02:00
committed by GitHub
parent 8579e4f85f
commit a34bf0909f
27 changed files with 1251 additions and 82 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/Http/Resources/ModuleResource.php
+38
View File
@@ -6,6 +6,7 @@ use App\Models\Module as ModelsModule;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Http\Request;
use Illuminate\Http\Resources\Json\JsonResource;
use Illuminate\Support\Facades\File;
class ModuleResource extends JsonResource
{
@@ -64,6 +65,7 @@ class ModuleResource extends JsonResource
'author_avatar' => data_get($this->resource, 'author_avatar') ?? data_get($this->resource, 'author.avatar'),
'installed' => $this->moduleInstalled($installedModule),
'enabled' => $this->moduleEnabled($installedModule),
'supports_data_cleanup' => $this->supportsDataCleanup($installedModule),
'update_available' => $this->updateAvailable($installedModule, $latestVersion),
'video_link' => data_get($this->resource, 'video_link') ?? data_get($this->resource, 'video.url'),
'video_thumbnail' => data_get($this->resource, 'video_thumbnail') ?? data_get($this->resource, 'video.thumbnail'),
@@ -111,4 +113,40 @@ class ModuleResource extends JsonResource
return version_compare($installedModule->version, $latestVersion, '<');
}
public function supportsDataCleanup(?ModelsModule $installedModule): bool
{
if (! $installedModule?->installed) {
return false;
}
$path = base_path('Modules/'.$installedModule->name.'/module.json');
$metadata = File::isFile($path) ? json_decode((string) File::get($path), true) : null;
$uninstall = is_array($metadata) ? ($metadata['uninstall'] ?? null) : null;
$cleanup = is_array($uninstall) ? ($uninstall['data_cleanup'] ?? null) : null;
$contract = 'InvoiceShelf\\Modules\\Contracts\\DataCleanup';
if (! (is_array($metadata)
&& ($metadata['schema_version'] ?? null) === 2
&& ($metadata['migration_policy'] ?? null) === 'reversible'
&& is_array($uninstall)
&& array_keys($uninstall) === ['data_cleanup']
&& is_string($cleanup)
&& interface_exists($contract))) {
return false;
}
try {
$reflection = new \ReflectionClass($cleanup);
return ! $reflection->isAbstract()
&& $reflection->isInstantiable()
&& is_a($cleanup, $contract, true)
&& $reflection->hasMethod('cleanup')
&& $reflection->getMethod('cleanup')->isPublic()
&& ! $reflection->getMethod('cleanup')->isStatic();
} catch (\Throwable) {
return false;
}
}
}