QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-04-07 13:41:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Installer reliability improvements (#593)

Browse Source 
* docs: add CLAUDE.md for Claude Code guidance

* fix: handle missing settings table in installation middlewares

RedirectIfInstalled crashed with "no such table: settings" when the
database_created marker file existed but the database was empty.
Changed to use isDbCreated() which verifies actual tables, and added
try-catch around Setting queries in both middlewares.

* feat: pre-select database driver from env in installation wizard

The database step now reads DB_CONNECTION from the environment and
pre-selects the matching driver on load, including correct defaults
for hostname and port.

* feat: pre-select mail driver and config from env in installation wizard

The email step now fetches the current mail configuration on load
instead of hardcoding the driver to 'mail'. SMTP fields fall back
to Laravel config values from the environment.

* refactor: remove file-based DB marker in favor of direct DB checks

The database_created marker file was a second source of truth that
could drift out of sync with the actual database. InstallUtils now
checks the database directly via Schema::hasTable which is cached
per-request and handles all error cases gracefully.
This commit is contained in:
Darko Gjorgjijoski
2026-04-02 14:48:08 +02:00
committed by GitHub
parent 375cfc6b18
commit a38f09cf7b
12 changed files with 118 additions and 78 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
app/Space/InstallUtils.php
View File

@@ -5,8 +5,6 @@ namespace App\Space;
use App\Models\Setting;
use Illuminate\Database\QueryException;
use Illuminate\Support\Facades\File;
use Illuminate\Support\Facades\Log;
use League\Flysystem\FilesystemException;
class InstallUtils
{
@@ -17,7 +15,7 @@ class InstallUtils
*/
public static function isDbCreated()
{
return self::dbMarkerExists() && self::tableExists('users');
return self::tableExists('users');
}
/**
@@ -44,54 +42,6 @@ class InstallUtils
return $cache[$table];
}
/**
* Check if database created marker exists
*
* @return bool
*/
public static function dbMarkerExists()
{
try {
return \Storage::disk('local')->has('database_created');
} catch (FilesystemException $e) {
Log::error('Unable to verify db marker: '.$e->getMessage());
}
return false;
}
/**
* Creates the database marker
*
* @return bool
*/
public static function createDbMarker()
{
try {
return \Storage::disk('local')->put('database_created', time());
} catch (\Exception $e) {
Log::error('Unable to create db marker: '.$e->getMessage());
}
return false;
}
/**
* Deletes the database marker
*
* @return bool
*/
public static function deleteDbMarker()
{
try {
return \Storage::disk('local')->delete('database_created');
} catch (\Exception $e) {
Log::error('Unable to delete db marker: '.$e->getMessage());
}
return false;
}
/**
* Set the app version
*