From af205acb75802f14ae9ebc14df1f447e10d82ae7 Mon Sep 17 00:00:00 2001 From: Devstack Date: Thu, 1 Jan 2026 22:43:52 +0100 Subject: [PATCH] Fix aggregates for customers using withSum() (SQL-portable, no DB mode tweaks) (#486) * Update CustomersController.php Fix: replace GROUP BY + SUM join with withSum() to avoid ONLY_FULL_GROUP_BY; no API changes (same aliases) * Update CustomersController.php style: apply Laravel Pint formatting --- .../V1/Admin/Customer/CustomersController.php | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/app/Http/Controllers/V1/Admin/Customer/CustomersController.php b/app/Http/Controllers/V1/Admin/Customer/CustomersController.php index ada15c13..63c1b748 100644 --- a/app/Http/Controllers/V1/Admin/Customer/CustomersController.php +++ b/app/Http/Controllers/V1/Admin/Customer/CustomersController.php @@ -8,7 +8,6 @@ use App\Http\Requests\DeleteCustomersRequest; use App\Http\Resources\CustomerResource; use App\Models\Customer; use Illuminate\Http\Request; -use Illuminate\Support\Facades\DB; class CustomersController extends Controller { @@ -26,13 +25,8 @@ class CustomersController extends Controller $customers = Customer::with('creator') ->whereCompany() ->applyFilters($request->all()) - ->select( - 'customers.*', - DB::raw('sum(invoices.base_due_amount) as base_due_amount'), - DB::raw('sum(invoices.due_amount) as due_amount'), - ) - ->groupBy('customers.id') - ->leftJoin('invoices', 'customers.id', '=', 'invoices.customer_id') + ->withSum('invoices as base_due_amount', 'base_due_amount') + ->withSum('invoices as due_amount', 'due_amount') ->paginateData($limit); return CustomerResource::collection($customers)