mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-17 06:15:20 +00:00
fix(security): enforce company scope on notes, doc-convert, and member bulk-delete (#668)
v3 port of the v2 authorization fixes. - Notes IDOR (GHSA-85wc): NotePolicy checks the note's company_id and NotesController passes the bound model to authorize() on show/update/destroy. - Estimate<->Invoice convert IDOR (GHSA-j2vg): EstimatesController::convertToInvoice and InvoicesController::convertToEstimate authorize 'view' on the source document before creating the target. - Member bulk-delete (GHSA-wxrv): MembersController scopes ids via User::whereCompany() before MemberService::delete. Adds feature tests for cross-company 403s + same-company happy paths.
This commit is contained in:
committed by
GitHub
parent
f3ab0f22fc
commit
c6a00df120
@@ -93,7 +93,16 @@ class MembersController extends Controller
|
||||
$this->authorize('delete multiple users', User::class);
|
||||
|
||||
if ($request->users) {
|
||||
$this->memberService->delete($request->users);
|
||||
// Scope the candidate ids to members of the acting company so a user
|
||||
// from one company cannot delete accounts belonging to another.
|
||||
$ids = User::whereCompany()
|
||||
->whereIn('id', $request->users)
|
||||
->pluck('id')
|
||||
->toArray();
|
||||
|
||||
if ($ids) {
|
||||
$this->memberService->delete($ids);
|
||||
}
|
||||
}
|
||||
|
||||
return response()->json([
|
||||
|
||||
Reference in New Issue
Block a user