mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-16 13:55:21 +00:00
fix(security): enforce company scope on notes, doc-convert, and member bulk-delete (#668)
v3 port of the v2 authorization fixes. - Notes IDOR (GHSA-85wc): NotePolicy checks the note's company_id and NotesController passes the bound model to authorize() on show/update/destroy. - Estimate<->Invoice convert IDOR (GHSA-j2vg): EstimatesController::convertToInvoice and InvoicesController::convertToEstimate authorize 'view' on the source document before creating the target. - Member bulk-delete (GHSA-wxrv): MembersController scopes ids via User::whereCompany() before MemberService::delete. Adds feature tests for cross-company 403s + same-company happy paths.
This commit is contained in:
committed by
GitHub
parent
f3ab0f22fc
commit
c6a00df120
@@ -2,10 +2,12 @@
|
||||
|
||||
use App\Http\Controllers\Company\Members\MembersController;
|
||||
use App\Http\Requests\MemberRequest;
|
||||
use App\Models\Company;
|
||||
use App\Models\User;
|
||||
use Laravel\Sanctum\Sanctum;
|
||||
|
||||
use function Pest\Laravel\getJson;
|
||||
use function Pest\Laravel\postJson;
|
||||
|
||||
beforeEach(function () {
|
||||
Artisan::call('db:seed', ['--class' => 'DatabaseSeeder', '--force' => true]);
|
||||
@@ -48,3 +50,22 @@ test('update member using a form request', function () {
|
||||
MemberRequest::class
|
||||
);
|
||||
});
|
||||
|
||||
test('deletes a member belonging to the current company', function () {
|
||||
$companyId = User::where('role', 'super admin')->first()->companies()->first()->id;
|
||||
$user = User::factory()->create();
|
||||
$user->companies()->attach($companyId);
|
||||
|
||||
postJson('/api/v1/members/delete', ['users' => [$user->id]])->assertOk();
|
||||
|
||||
$this->assertDatabaseMissing('users', ['id' => $user->id]);
|
||||
});
|
||||
|
||||
test('cannot bulk delete a member belonging to another company', function () {
|
||||
$user = User::factory()->create();
|
||||
$user->companies()->attach(Company::factory()->create()->id);
|
||||
|
||||
postJson('/api/v1/members/delete', ['users' => [$user->id]])->assertOk();
|
||||
|
||||
$this->assertDatabaseHas('users', ['id' => $user->id]);
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user