QT/InvoiceShelf
1
0
Fork 0
mirror of https://github.com/InvoiceShelf/InvoiceShelf.git synced 2026-04-15 09:14:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove dead model methods now handled by services

Browse Source 
Remove createItem/updateItem from Item, createTransaction/
completeTransaction/failedTransaction from Transaction,
createCustomField/updateCustomField from CustomField, all business
methods from ExchangeRateProvider (CRUD + API checks + URL helpers),
and validateCredentials/createDisk/updateDisk/updateDefaultDisks/
setAsDefaultDisk from FileDisk.

All logic now lives in their respective service classes.
This commit is contained in:
Darko Gjorgjijoski
2026-04-03 20:32:02 +02:00
parent 85b62dfdf8
commit c90dd1f2ac
5 changed files with 0 additions and 294 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/Models/Transaction.php
View File

@@ -2,7 +2,6 @@
namespace App\Models;
use App\Facades\Hashids;
use Carbon\Carbon;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
@@ -42,27 +41,6 @@ class Transaction extends Model
return $this->belongsTo(Company::class);
}
public function completeTransaction()
{
$this->status = self::SUCCESS;
$this->save();
}
public function failedTransaction()
{
$this->status = self::FAILED;
$this->save();
}
public static function createTransaction($data)
{
$transaction = self::create($data);
$transaction->unique_hash = Hashids::connection(Transaction::class)->encode($transaction->id);
$transaction->save();
return $transaction;
}
public function isExpired()
{
$linkExpiryDays = (int) CompanySetting::getSetting('link_expiry_days', $this->company_id);