Consolidate Admin/Modules: 10 single-action controllers into 2

ModulesController: index, show, checkToken, enable, disable
ModuleInstallationController: download, upload, unzip, copy, complete
This commit is contained in:
Darko Gjorgjijoski
2026-04-03 21:16:18 +02:00
parent e9ee74cd01
commit d505677a74
21 changed files with 244 additions and 373 deletions

View File

@@ -9,6 +9,9 @@ use Illuminate\Http\JsonResponse;
class ApiController extends Controller
{
/**
* Resoibd wutg syccess
*/
public function respondSuccess(): JsonResponse
{
return response()->json([

View File

@@ -7,6 +7,7 @@ namespace App\Http\Controllers\Admin\Backup;
use App\Jobs\CreateBackupJob;
use App\Models\FileDisk;
use App\Rules\Backup\PathToZip;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Cache;
@@ -19,9 +20,10 @@ class BackupsController extends ApiController
/**
* Display a listing of the resource.
*
* @return JsonResponse
*
* @throws AuthorizationException
*/
public function index(Request $request)
public function index(Request $request): JsonResponse
{
$this->authorize('manage backups');
@@ -70,9 +72,10 @@ class BackupsController extends ApiController
/**
* Store a newly created resource in storage.
*
* @return JsonResponse
*
* @throws AuthorizationException
*/
public function store(Request $request)
public function store(Request $request): JsonResponse
{
$this->authorize('manage backups');
@@ -87,9 +90,10 @@ class BackupsController extends ApiController
/**
* Remove the specified resource from storage.
*
* @return JsonResponse
*
* @throws AuthorizationException
*/
public function destroy($disk, Request $request)
public function destroy($disk, Request $request): JsonResponse
{
$this->authorize('manage backups');

View File

@@ -5,6 +5,8 @@
namespace App\Http\Controllers\Admin\Backup;
use App\Rules\Backup\PathToZip;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Contracts\Routing\ResponseFactory;
use Illuminate\Http\Request;
use Spatie\Backup\BackupDestination\Backup;
use Spatie\Backup\BackupDestination\BackupDestination;
@@ -13,7 +15,13 @@ use Symfony\Component\HttpFoundation\StreamedResponse;
class DownloadBackupController extends ApiController
{
public function __invoke(Request $request)
/**
* Handle backups
*
*
* @throws AuthorizationException
*/
public function __invoke(Request $request): \Illuminate\Http\Response|StreamedResponse|ResponseFactory
{
$this->authorize('manage backups');
@@ -34,6 +42,9 @@ class DownloadBackupController extends ApiController
return $this->respondWithBackupStream($backup);
}
/**
* Respond with backup stream
*/
public function respondWithBackupStream(Backup $backup): StreamedResponse
{
$fileName = pathinfo($backup->path(), PATHINFO_BASENAME);