diff --git a/CLAUDE.md b/CLAUDE.md index 6ba2a11e..48ddc293 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -60,7 +60,7 @@ Three guards: `web` (session), `api` (Sanctum tokens for `/api/v1/`), `customer` - **PDF generation**: DomPDF (`GeneratesPdfTrait`) or Gotenberg - **Email**: Mailable classes with `EmailLog` tracking - **File storage**: Spatie MediaLibrary, supports local/S3/Dropbox -- **Serial numbers**: `SerialNumberFormatter` service +- **Serial numbers**: `SerialNumberService` service - **Company settings**: `CompanySetting` model (key-value per company) ### Database diff --git a/app/Http/Controllers/V1/Admin/Estimate/CloneEstimateController.php b/app/Http/Controllers/V1/Admin/Estimate/CloneEstimateController.php index 64a57f64..bd5cc35c 100644 --- a/app/Http/Controllers/V1/Admin/Estimate/CloneEstimateController.php +++ b/app/Http/Controllers/V1/Admin/Estimate/CloneEstimateController.php @@ -7,7 +7,7 @@ use App\Http\Controllers\Controller; use App\Http\Resources\EstimateResource; use App\Models\CompanySetting; use App\Models\Estimate; -use App\Services\SerialNumberFormatter; +use App\Services\SerialNumberService; use Carbon\Carbon; use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; @@ -26,7 +26,7 @@ class CloneEstimateController extends Controller $date = Carbon::now(); - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($estimate) ->setCompany($estimate->company_id) ->setCustomer($estimate->customer_id) diff --git a/app/Http/Controllers/V1/Admin/Estimate/ConvertEstimateController.php b/app/Http/Controllers/V1/Admin/Estimate/ConvertEstimateController.php index 95b10dda..eb46f9c3 100644 --- a/app/Http/Controllers/V1/Admin/Estimate/ConvertEstimateController.php +++ b/app/Http/Controllers/V1/Admin/Estimate/ConvertEstimateController.php @@ -8,7 +8,7 @@ use App\Http\Resources\InvoiceResource; use App\Models\CompanySetting; use App\Models\Estimate; use App\Models\Invoice; -use App\Services\SerialNumberFormatter; +use App\Services\SerialNumberService; use Carbon\Carbon; use Illuminate\Http\Request; use Illuminate\Http\Response; @@ -43,7 +43,7 @@ class ConvertEstimateController extends Controller $due_date = Carbon::now()->addDays($dueDateDays)->format('Y-m-d'); } - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($invoice) ->setCompany($estimate->company_id) ->setCustomer($estimate->customer_id) diff --git a/app/Http/Controllers/V1/Admin/General/NextNumberController.php b/app/Http/Controllers/V1/Admin/General/NextNumberController.php index 6a661948..d9259e2e 100644 --- a/app/Http/Controllers/V1/Admin/General/NextNumberController.php +++ b/app/Http/Controllers/V1/Admin/General/NextNumberController.php @@ -6,7 +6,7 @@ use App\Http\Controllers\Controller; use App\Models\Estimate; use App\Models\Invoice; use App\Models\Payment; -use App\Services\SerialNumberFormatter; +use App\Services\SerialNumberService; use Illuminate\Http\Request; use Illuminate\Http\Response; @@ -21,7 +21,7 @@ class NextNumberController extends Controller { $key = $request->key; $nextNumber = null; - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setCompany($request->header('company')) ->setCustomer($request->userId); diff --git a/app/Http/Controllers/V1/Admin/General/NumberPlaceholdersController.php b/app/Http/Controllers/V1/Admin/General/NumberPlaceholdersController.php index cce538b1..4ed87184 100644 --- a/app/Http/Controllers/V1/Admin/General/NumberPlaceholdersController.php +++ b/app/Http/Controllers/V1/Admin/General/NumberPlaceholdersController.php @@ -3,7 +3,7 @@ namespace App\Http\Controllers\V1\Admin\General; use App\Http\Controllers\Controller; -use App\Services\SerialNumberFormatter; +use App\Services\SerialNumberService; use Illuminate\Http\Request; use Illuminate\Http\Response; @@ -17,7 +17,7 @@ class NumberPlaceholdersController extends Controller public function __invoke(Request $request) { if ($request->format) { - $placeholders = SerialNumberFormatter::getPlaceholders($request->format); + $placeholders = SerialNumberService::getPlaceholders($request->format); } else { $placeholders = []; } diff --git a/app/Http/Controllers/V1/Admin/Invoice/CloneInvoiceController.php b/app/Http/Controllers/V1/Admin/Invoice/CloneInvoiceController.php index e3775781..c23a827c 100644 --- a/app/Http/Controllers/V1/Admin/Invoice/CloneInvoiceController.php +++ b/app/Http/Controllers/V1/Admin/Invoice/CloneInvoiceController.php @@ -7,7 +7,7 @@ use App\Http\Controllers\Controller; use App\Http\Resources\InvoiceResource; use App\Models\CompanySetting; use App\Models\Invoice; -use App\Services\SerialNumberFormatter; +use App\Services\SerialNumberService; use Carbon\Carbon; use Illuminate\Http\JsonResponse; use Illuminate\Http\Request; @@ -26,7 +26,7 @@ class CloneInvoiceController extends Controller $date = Carbon::now(); - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($invoice) ->setCompany($invoice->company_id) ->setCustomer($invoice->customer_id) diff --git a/app/Services/EstimateService.php b/app/Services/EstimateService.php index 5027e1e2..4e897a57 100644 --- a/app/Services/EstimateService.php +++ b/app/Services/EstimateService.php @@ -30,7 +30,7 @@ class EstimateService $estimate = Estimate::create($data); $estimate->unique_hash = Hashids::connection(Estimate::class)->encode($estimate->id); - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($estimate) ->setCompany($estimate->company_id) ->setCustomer($estimate->customer_id) @@ -65,7 +65,7 @@ class EstimateService { $data = $request->getEstimatePayload(); - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($estimate) ->setCompany($estimate->company_id) ->setCustomer($request->customer_id) diff --git a/app/Services/InvoiceService.php b/app/Services/InvoiceService.php index 177d8cb8..fdd181ae 100644 --- a/app/Services/InvoiceService.php +++ b/app/Services/InvoiceService.php @@ -32,7 +32,7 @@ class InvoiceService $invoice = Invoice::create($data); - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($invoice) ->setCompany($invoice->company_id) ->setCustomer($invoice->customer_id) @@ -73,7 +73,7 @@ class InvoiceService */ public function update(Invoice $invoice, Request $request): Invoice { - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($invoice) ->setCompany($invoice->company_id) ->setCustomer($request->customer_id) diff --git a/app/Services/PaymentService.php b/app/Services/PaymentService.php index 956971ed..feda346d 100644 --- a/app/Services/PaymentService.php +++ b/app/Services/PaymentService.php @@ -28,7 +28,7 @@ class PaymentService $payment = Payment::create($data); $payment->unique_hash = Hashids::connection(Payment::class)->encode($payment->id); - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($payment) ->setCompany($payment->company_id) ->setCustomer($payment->customer_id) @@ -78,7 +78,7 @@ class PaymentService $invoice->subtractInvoicePayment($request->amount); } - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel($payment) ->setCompany($payment->company_id) ->setCustomer($request->customer_id) @@ -191,7 +191,7 @@ class PaymentService { $invoice = Invoice::find($transaction->invoice_id); - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel(new Payment) ->setCompany($invoice->company_id) ->setCustomer($invoice->customer_id) diff --git a/app/Services/RecurringInvoiceService.php b/app/Services/RecurringInvoiceService.php index 0764687a..97459329 100644 --- a/app/Services/RecurringInvoiceService.php +++ b/app/Services/RecurringInvoiceService.php @@ -126,7 +126,7 @@ class RecurringInvoiceService private function createInvoiceFromRecurring(RecurringInvoice $recurringInvoice): void { - $serial = (new SerialNumberFormatter) + $serial = (new SerialNumberService) ->setModel(new Invoice) ->setCompany($recurringInvoice->company_id) ->setCustomer($recurringInvoice->customer_id) diff --git a/app/Services/SerialNumberFormatter.php b/app/Services/SerialNumberService.php similarity index 98% rename from app/Services/SerialNumberFormatter.php rename to app/Services/SerialNumberService.php index 0fe88ef6..8b0b6d5b 100644 --- a/app/Services/SerialNumberFormatter.php +++ b/app/Services/SerialNumberService.php @@ -5,10 +5,7 @@ namespace App\Services; use App\Models\CompanySetting; use App\Models\Customer; -/** - * SerialNumberFormatter - */ -class SerialNumberFormatter +class SerialNumberService { public const VALID_PLACEHOLDERS = ['CUSTOMER_SERIES', 'SEQUENCE', 'DATE_FORMAT', 'SERIES', 'RANDOM_SEQUENCE', 'DELIMITER', 'CUSTOMER_SEQUENCE']; diff --git a/database/factories/EstimateFactory.php b/database/factories/EstimateFactory.php index 3db92cfd..77a164ec 100644 --- a/database/factories/EstimateFactory.php +++ b/database/factories/EstimateFactory.php @@ -6,7 +6,7 @@ use App\Models\Currency; use App\Models\Customer; use App\Models\Estimate; use App\Models\User; -use App\Services\SerialNumberFormatter; +use App\Services\SerialNumberService; use Illuminate\Database\Eloquent\Factories\Factory; class EstimateFactory extends Factory @@ -68,7 +68,7 @@ class EstimateFactory extends Factory */ public function definition(): array { - $sequenceNumber = (new SerialNumberFormatter) + $sequenceNumber = (new SerialNumberService) ->setModel(new Estimate) ->setCompany(User::find(1)->companies()->first()->id) ->setNextNumbers(); diff --git a/database/factories/InvoiceFactory.php b/database/factories/InvoiceFactory.php index a09a5bdc..cea7f4fa 100644 --- a/database/factories/InvoiceFactory.php +++ b/database/factories/InvoiceFactory.php @@ -7,7 +7,7 @@ use App\Models\Customer; use App\Models\Invoice; use App\Models\RecurringInvoice; use App\Models\User; -use App\Services\SerialNumberFormatter; +use App\Services\SerialNumberService; use Illuminate\Database\Eloquent\Factories\Factory; class InvoiceFactory extends Factory @@ -78,7 +78,7 @@ class InvoiceFactory extends Factory */ public function definition(): array { - $sequenceNumber = (new SerialNumberFormatter) + $sequenceNumber = (new SerialNumberService) ->setModel(new Invoice) ->setCompany(User::find(1)->companies()->first()->id) ->setNextNumbers(); diff --git a/database/factories/PaymentFactory.php b/database/factories/PaymentFactory.php index f1f4b62f..acb70374 100644 --- a/database/factories/PaymentFactory.php +++ b/database/factories/PaymentFactory.php @@ -7,7 +7,7 @@ use App\Models\Customer; use App\Models\Payment; use App\Models\PaymentMethod; use App\Models\User; -use App\Services\SerialNumberFormatter; +use App\Services\SerialNumberService; use Illuminate\Database\Eloquent\Factories\Factory; class PaymentFactory extends Factory @@ -24,7 +24,7 @@ class PaymentFactory extends Factory */ public function definition(): array { - $sequenceNumber = (new SerialNumberFormatter) + $sequenceNumber = (new SerialNumberService) ->setModel(new Payment) ->setCompany(User::find(1)->companies()->first()->id) ->setNextNumbers();