Add return types and typed parameters to remaining 10 models

Complete the type modernization across all models. Adds Builder-typed
$query parameters and return types to all scope methods, typed parameters
on accessors, and PHPDoc on scopePaginateData/scopeApplyFilters.

Models updated: Address, EstimateItem, Expense, ExpenseCategory,
InvoiceItem, Item, Note, Tax, TaxType, Unit.

5 models needed no changes (Country, Currency, ImpersonationLog,
Module, UserSetting) as they had no untyped public methods.
This commit is contained in:
Darko Gjorgjijoski
2026-04-03 20:53:41 +02:00
parent 0fa1aac748
commit e9ee74cd01
10 changed files with 103 additions and 59 deletions

View File

@@ -3,6 +3,7 @@
namespace App\Models;
use Carbon\Carbon;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Database\Eloquent\Factories\HasFactory;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\BelongsTo;
@@ -65,19 +66,19 @@ class Tax extends Model
return $this->belongsTo(Item::class);
}
public function scopeWhereCompany($query, $company_id)
public function scopeWhereCompany(Builder $query, int $company_id): void
{
$query->where('company_id', $company_id);
}
public function scopeTaxAttributes($query)
public function scopeTaxAttributes(Builder $query): void
{
$query->select(
DB::raw('sum(base_amount) as total_tax_amount, tax_type_id')
)->groupBy('tax_type_id');
}
public function scopeInvoicesBetween($query, $start, $end)
public function scopeInvoicesBetween(Builder $query, Carbon $start, Carbon $end): void
{
$query->whereHas('invoice', function ($query) use ($start, $end) {
$query->where('paid_status', Invoice::STATUS_PAID)
@@ -95,7 +96,7 @@ class Tax extends Model
});
}
public function scopeWhereInvoicesFilters($query, array $filters)
public function scopeWhereInvoicesFilters(Builder $query, array $filters): void
{
$filters = collect($filters);