mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-16 22:05:20 +00:00
The app/Services/ directory had grown into 22 flat files at the root plus 7 uneven subdirectories — finding anything required scrolling through an alphabetical mix of small CRUD services, infrastructure drivers, and install-time utilities. This commit groups services by domain, folds Backup into a new Storage namespace, and moves framework-infrastructure and install-time helpers out of Services and into Support where they belong. New Services layout: Documents/ (Invoice, Estimate, RecurringInvoice, Payment, Expense, Transaction, DocumentItem, SerialNumber, Currency — matches the 'Documents' navigation group); Company/ (Company, Member, Invitation); Mail/ (MailConfiguration, CompanyMailConfig); Storage/ (FileDisk, plus Backup folded in). ExchangeRateProviderService moves next to its drivers in ExchangeRate/; FontService moves into Pdf/ where it belongs. CustomerService, ItemService, CustomFieldService stay at the Services root as standalone single-file domains. Moves to Support/: Hashids/ (library wrapper — not business logic); Setup/ (one-shot install-time utilities — stateless helpers); Pdf/ (ImageUtils, PdfTemplateUtils, plus the existing PdfHtmlSanitizer consolidated into the same subdir). These are all framework infrastructure and stateless utilities — the 'service' label never really fit them. Namespace declarations in 29 moved files updated to match new paths. 62 consumer files (controllers, other services, tests, database factories, seeders, routes, bootstrap/providers.php) have their use statements rewritten via a literal-string replacement script — no regex meant no risk of half-matching. Three Documents services needed an explicit 'use App\Services\Mail\CompanyMailConfigService' added because the same-namespace short reference they relied on no longer resolves after the split. Verified: composer dump-autoload, 350 tests pass (850 assertions), vendor/bin/pint clean, npm run build succeeds.
53 lines
1.3 KiB
PHP
53 lines
1.3 KiB
PHP
<?php
|
|
|
|
namespace App\Services\Storage;
|
|
|
|
use App\Models\FileDisk;
|
|
use App\Models\Setting;
|
|
use App\Services\Storage\FileDiskService;
|
|
use Spatie\Backup\BackupDestination\BackupDestination;
|
|
|
|
class BackupService
|
|
{
|
|
public function __construct(
|
|
private readonly FileDiskService $fileDiskService,
|
|
) {}
|
|
|
|
/**
|
|
* Resolve the backup FileDisk from the given ID, settings, or default.
|
|
*/
|
|
public function resolveBackupDisk(?int $fileDiskId = null): ?FileDisk
|
|
{
|
|
if ($fileDiskId) {
|
|
$disk = FileDisk::find($fileDiskId);
|
|
if ($disk) {
|
|
return $disk;
|
|
}
|
|
}
|
|
|
|
$backupDiskId = Setting::getSetting('backup_disk_id');
|
|
if ($backupDiskId) {
|
|
$disk = FileDisk::find($backupDiskId);
|
|
if ($disk) {
|
|
return $disk;
|
|
}
|
|
}
|
|
|
|
return FileDisk::where('set_as_default', true)->first();
|
|
}
|
|
|
|
/**
|
|
* Create a BackupDestination pointing at the resolved disk.
|
|
*/
|
|
public function getDestination(?int $fileDiskId = null): BackupDestination
|
|
{
|
|
$disk = $this->resolveBackupDisk($fileDiskId);
|
|
|
|
$diskName = $disk
|
|
? $this->fileDiskService->registerDisk($disk)
|
|
: config('filesystems.default');
|
|
|
|
return BackupDestination::create($diskName, config('backup.backup.name'));
|
|
}
|
|
}
|