mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-04-15 09:14:08 +00:00
When inviting an email without an InvoiceShelf account, the email now
links to a registration page (/register?invitation={token}) instead of
login. After registering, the invitation is auto-accepted.
Backend:
- InvitationRegistrationController: public details() and register()
endpoints. Registration validates token + email match, creates account,
auto-accepts invitation, returns Sanctum token.
- AuthController: login now accepts optional invitation_token param to
auto-accept invitation for existing users clicking the email link.
- CompanyInvitationMail: conditional URL based on user existence.
- Web route for /invitations/{token}/decline (email decline link).
Frontend:
- RegisterWithInvitation.vue: fetches invitation details, shows company
name + role, registration form with pre-filled email.
- Router: /register route added.
Tests: 3 new tests (invitation details, register + accept, email mismatch).
314 lines
9.1 KiB
PHP
314 lines
9.1 KiB
PHP
<?php
|
|
|
|
use App\Mail\CompanyInvitationMail;
|
|
use App\Models\Company;
|
|
use App\Models\CompanyInvitation;
|
|
use App\Models\User;
|
|
use Illuminate\Support\Facades\Artisan;
|
|
use Illuminate\Support\Facades\Mail;
|
|
use Laravel\Sanctum\Sanctum;
|
|
use Silber\Bouncer\Database\Role;
|
|
|
|
use function Pest\Laravel\deleteJson;
|
|
use function Pest\Laravel\getJson;
|
|
use function Pest\Laravel\postJson;
|
|
|
|
beforeEach(function () {
|
|
Artisan::call('db:seed', ['--class' => 'DatabaseSeeder', '--force' => true]);
|
|
Artisan::call('db:seed', ['--class' => 'DemoSeeder', '--force' => true]);
|
|
|
|
$user = User::find(1);
|
|
$this->withHeaders([
|
|
'company' => $user->companies()->first()->id,
|
|
]);
|
|
Sanctum::actingAs($user, ['*']);
|
|
});
|
|
|
|
test('invite user to company', function () {
|
|
Mail::fake();
|
|
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
|
|
$response = postJson('api/v1/company-invitations', [
|
|
'email' => 'newuser@example.com',
|
|
'role_id' => $role->id,
|
|
]);
|
|
|
|
$response->assertOk();
|
|
$response->assertJsonPath('success', true);
|
|
|
|
$this->assertDatabaseHas('company_invitations', [
|
|
'company_id' => $company->id,
|
|
'email' => 'newuser@example.com',
|
|
'role_id' => $role->id,
|
|
'status' => 'pending',
|
|
]);
|
|
|
|
Mail::assertSent(CompanyInvitationMail::class);
|
|
});
|
|
|
|
test('cannot invite user already in company', function () {
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
$existingUser = User::first();
|
|
|
|
$response = postJson('api/v1/company-invitations', [
|
|
'email' => $existingUser->email,
|
|
'role_id' => $role->id,
|
|
]);
|
|
|
|
$response->assertStatus(422);
|
|
});
|
|
|
|
test('cannot send duplicate invitation', function () {
|
|
Mail::fake();
|
|
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
|
|
postJson('api/v1/company-invitations', [
|
|
'email' => 'duplicate@example.com',
|
|
'role_id' => $role->id,
|
|
])->assertOk();
|
|
|
|
postJson('api/v1/company-invitations', [
|
|
'email' => 'duplicate@example.com',
|
|
'role_id' => $role->id,
|
|
])->assertStatus(422);
|
|
});
|
|
|
|
test('list pending invitations for company', function () {
|
|
Mail::fake();
|
|
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
|
|
postJson('api/v1/company-invitations', [
|
|
'email' => 'invited@example.com',
|
|
'role_id' => $role->id,
|
|
]);
|
|
|
|
$response = getJson('api/v1/company-invitations');
|
|
|
|
$response->assertOk();
|
|
$response->assertJsonCount(1, 'invitations');
|
|
});
|
|
|
|
test('cancel pending invitation', function () {
|
|
Mail::fake();
|
|
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
|
|
$storeResponse = postJson('api/v1/company-invitations', [
|
|
'email' => 'cancel@example.com',
|
|
'role_id' => $role->id,
|
|
]);
|
|
$storeResponse->assertOk();
|
|
|
|
$invitation = CompanyInvitation::where('email', 'cancel@example.com')->first();
|
|
$this->assertNotNull($invitation);
|
|
|
|
deleteJson("api/v1/company-invitations/{$invitation->id}")
|
|
->assertOk();
|
|
|
|
$this->assertDatabaseMissing('company_invitations', [
|
|
'email' => 'cancel@example.com',
|
|
]);
|
|
});
|
|
|
|
test('accept invitation adds user to company', function () {
|
|
Mail::fake();
|
|
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
|
|
// Create a new user not in the company
|
|
$newUser = User::factory()->create(['email' => 'accept@example.com']);
|
|
|
|
// Create invitation
|
|
$invitation = CompanyInvitation::create([
|
|
'company_id' => $company->id,
|
|
'user_id' => $newUser->id,
|
|
'email' => $newUser->email,
|
|
'role_id' => $role->id,
|
|
'token' => 'test-accept-token',
|
|
'status' => 'pending',
|
|
'invited_by' => User::first()->id,
|
|
'expires_at' => now()->addDays(7),
|
|
]);
|
|
|
|
// Act as the invited user
|
|
Sanctum::actingAs($newUser, ['*']);
|
|
|
|
postJson("api/v1/invitations/{$invitation->token}/accept")
|
|
->assertOk();
|
|
|
|
$this->assertTrue($newUser->fresh()->hasCompany($company->id));
|
|
$this->assertDatabaseHas('company_invitations', [
|
|
'token' => 'test-accept-token',
|
|
'status' => 'accepted',
|
|
]);
|
|
});
|
|
|
|
test('decline invitation', function () {
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
$newUser = User::factory()->create(['email' => 'decline@example.com']);
|
|
|
|
$invitation = CompanyInvitation::create([
|
|
'company_id' => $company->id,
|
|
'user_id' => $newUser->id,
|
|
'email' => $newUser->email,
|
|
'role_id' => $role->id,
|
|
'token' => 'test-decline-token',
|
|
'status' => 'pending',
|
|
'invited_by' => User::first()->id,
|
|
'expires_at' => now()->addDays(7),
|
|
]);
|
|
|
|
Sanctum::actingAs($newUser, ['*']);
|
|
|
|
postJson("api/v1/invitations/{$invitation->token}/decline")
|
|
->assertOk();
|
|
|
|
$this->assertDatabaseHas('company_invitations', [
|
|
'token' => 'test-decline-token',
|
|
'status' => 'declined',
|
|
]);
|
|
$this->assertFalse($newUser->fresh()->hasCompany($company->id));
|
|
});
|
|
|
|
test('cannot accept expired invitation', function () {
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
$newUser = User::factory()->create(['email' => 'expired@example.com']);
|
|
|
|
$invitation = CompanyInvitation::create([
|
|
'company_id' => $company->id,
|
|
'user_id' => $newUser->id,
|
|
'email' => $newUser->email,
|
|
'role_id' => $role->id,
|
|
'token' => 'test-expired-token',
|
|
'status' => 'pending',
|
|
'invited_by' => User::first()->id,
|
|
'expires_at' => now()->subDay(),
|
|
]);
|
|
|
|
Sanctum::actingAs($newUser, ['*']);
|
|
|
|
postJson("api/v1/invitations/{$invitation->token}/accept")
|
|
->assertStatus(422);
|
|
|
|
$this->assertFalse($newUser->fresh()->hasCompany($company->id));
|
|
});
|
|
|
|
test('bootstrap includes pending invitations', function () {
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
$user = User::first();
|
|
|
|
CompanyInvitation::create([
|
|
'company_id' => $company->id,
|
|
'user_id' => $user->id,
|
|
'email' => $user->email,
|
|
'role_id' => $role->id,
|
|
'token' => 'test-bootstrap-token',
|
|
'status' => 'pending',
|
|
'invited_by' => $user->id,
|
|
'expires_at' => now()->addDays(7),
|
|
]);
|
|
|
|
$response = getJson('api/v1/bootstrap');
|
|
|
|
$response->assertOk();
|
|
$response->assertJsonStructure(['pending_invitations']);
|
|
});
|
|
|
|
test('get invitation details by token', function () {
|
|
Mail::fake();
|
|
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
|
|
// Create invitation for non-existent user
|
|
$invitation = CompanyInvitation::create([
|
|
'company_id' => $company->id,
|
|
'user_id' => null,
|
|
'email' => 'newperson@example.com',
|
|
'role_id' => $role->id,
|
|
'token' => 'test-details-token',
|
|
'status' => 'pending',
|
|
'invited_by' => User::first()->id,
|
|
'expires_at' => now()->addDays(7),
|
|
]);
|
|
|
|
$response = getJson("api/v1/invitations/{$invitation->token}/details");
|
|
|
|
$response->assertOk();
|
|
$response->assertJsonPath('email', 'newperson@example.com');
|
|
$response->assertJsonPath('company_name', $company->name);
|
|
});
|
|
|
|
test('register with invitation creates account and accepts', function () {
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
|
|
$invitation = CompanyInvitation::create([
|
|
'company_id' => $company->id,
|
|
'user_id' => null,
|
|
'email' => 'register@example.com',
|
|
'role_id' => $role->id,
|
|
'token' => 'test-register-token',
|
|
'status' => 'pending',
|
|
'invited_by' => User::first()->id,
|
|
'expires_at' => now()->addDays(7),
|
|
]);
|
|
|
|
$response = postJson('api/v1/auth/register-with-invitation', [
|
|
'name' => 'New User',
|
|
'email' => 'register@example.com',
|
|
'password' => 'password123',
|
|
'password_confirmation' => 'password123',
|
|
'invitation_token' => 'test-register-token',
|
|
]);
|
|
|
|
$response->assertOk();
|
|
$response->assertJsonStructure(['type', 'token']);
|
|
|
|
$newUser = User::where('email', 'register@example.com')->first();
|
|
$this->assertNotNull($newUser);
|
|
$this->assertTrue($newUser->hasCompany($company->id));
|
|
$this->assertDatabaseHas('company_invitations', [
|
|
'token' => 'test-register-token',
|
|
'status' => 'accepted',
|
|
]);
|
|
});
|
|
|
|
test('cannot register with mismatched email', function () {
|
|
$company = Company::first();
|
|
$role = Role::where('name', 'owner')->first();
|
|
|
|
CompanyInvitation::create([
|
|
'company_id' => $company->id,
|
|
'user_id' => null,
|
|
'email' => 'correct@example.com',
|
|
'role_id' => $role->id,
|
|
'token' => 'test-mismatch-token',
|
|
'status' => 'pending',
|
|
'invited_by' => User::first()->id,
|
|
'expires_at' => now()->addDays(7),
|
|
]);
|
|
|
|
$response = postJson('api/v1/auth/register-with-invitation', [
|
|
'name' => 'Wrong User',
|
|
'email' => 'wrong@example.com',
|
|
'password' => 'password123',
|
|
'password_confirmation' => 'password123',
|
|
'invitation_token' => 'test-mismatch-token',
|
|
]);
|
|
|
|
$response->assertStatus(422);
|
|
});
|