Files
InvoiceShelf/app/Http/Controllers/Company/Settings/CompanyAiConfigurationController.php
Darko Gjorgjijoski ac2a8ca939 fix(security): gate AI tools by user ability and block admin-URL SSRF
The AI chat assistant scoped tool queries by company but ignored the
per-user Bouncer abilities the rest of the app enforces, so any `use ai`
holder could read customers, invoices, payments, and company financials
their role couldn't otherwise see. Each AiTool now declares a required
ability (entity-aligned); the registry hides unauthorized tools from the
model and refuses to execute them as a backstop.

Separately, admin/owner-supplied URLs were fetched server-side with no
guard against private/reserved targets (SSRF): the AI base URL, the
CurrencyConverter "DEDICATED" exchange-rate URL, and S3/Spaces file-disk
endpoints. A shared PrivateNetworkGuard now backs a PublicHttpUrl
validation rule (save-time) and runtime guards in each driver.

- AiTool::requiredAbility() + mapping across all 12 tools
- AiToolRegistry filters schemas() by ability and re-checks in execute()
- PrivateNetworkGuard / BlockedUrlException / PublicHttpUrl rule (new)
- Rule wired into AI config (service + 3 controllers), exchange-rate,
  and file-disk endpoints; runtime guards in OpenRouterDriver,
  CurrencyConverterDriver, and FileDiskService
- Tests for ability filtering, the guard, the rule, and 422 rejections
2026-06-05 00:01:09 +02:00

114 lines
3.5 KiB
PHP

<?php
namespace App\Http\Controllers\Company\Settings;
use App\Http\Controllers\Controller;
use App\Rules\PublicHttpUrl;
use App\Services\AiConfigurationService;
use App\Support\Ai\AiDriverFactory;
use App\Support\Ai\AiException;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Validation\ValidationException;
class CompanyAiConfigurationController extends Controller
{
public function __construct(
private readonly AiConfigurationService $aiConfigurationService,
) {}
/**
* Get the per-company AI config with decrypted API key masked for response.
*/
public function getConfig(Request $request): JsonResponse
{
$config = $this->aiConfigurationService->getCompanyConfig($request->header('company'));
return response()->json($this->maskApiKey($config));
}
/**
* Persist the per-company AI config.
*
* Respects the `use_custom_ai_config` toggle — when OFF, only the toggle is written
* and the driver fields are discarded (same pattern as the mail company override).
*
* @throws ValidationException
*/
public function saveConfig(Request $request): JsonResponse
{
$this->authorize('owner only');
$validated = $this->validate(
$request,
$this->aiConfigurationService->validationRules(allowDisabledCustomConfig: true),
);
// Preserve existing key when masked placeholder is submitted
if (($validated['ai_api_key'] ?? null) === '********' || ($validated['ai_api_key'] ?? null) === '') {
$existing = $this->aiConfigurationService->getCompanyConfig($request->header('company'));
$validated['ai_api_key'] = $existing['ai_api_key'] ?? '';
}
$this->aiConfigurationService->saveCompanyConfig(
$request->header('company'),
$validated,
);
return response()->json(['success' => true]);
}
/**
* Test a company-level AI configuration without persisting it.
*
* @throws ValidationException
*/
public function testConnection(Request $request): JsonResponse
{
$this->authorize('owner only');
$this->validate($request, [
'ai_driver' => 'required|string',
'ai_api_key' => 'nullable|string',
'ai_base_url' => ['nullable', 'string', 'url', new PublicHttpUrl],
]);
$apiKey = $request->input('ai_api_key');
if ($apiKey === '********' || $apiKey === null || $apiKey === '') {
$existing = $this->aiConfigurationService->getCompanyConfig($request->header('company'));
$apiKey = $existing['ai_api_key'] ?? '';
}
if ($apiKey === '') {
return response()->json(['error' => 'missing_api_key'], 422);
}
try {
$driver = AiDriverFactory::make(
$request->input('ai_driver'),
$apiKey,
['base_url' => $request->input('ai_base_url')],
);
$result = $driver->validateConnection();
} catch (AiException $e) {
return response()->json(['error' => $e->errorKey, 'message' => $e->getMessage()], 422);
}
return response()->json(['success' => true, 'details' => $result]);
}
/**
* @param array<string, mixed> $config
* @return array<string, mixed>
*/
private function maskApiKey(array $config): array
{
if (! empty($config['ai_api_key'])) {
$config['ai_api_key'] = '********';
}
return $config;
}
}