mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-09-01 21:00:58 +00:00
Darko Gjorgjijoski
4ab62b98c6
* ci: speed up the test job (disable Xdebug, drop frontend build, run parallel) The `tests` job in check.yaml carried three sources of wasted wall-clock, none of which it actually used: - `coverage: xdebug` loaded Xdebug into every PHP process, but no step ever passes `--coverage` — so it was pure tax (~2-3x slower execution). Switch to `coverage: none`. If coverage is wanted later, use pcov + `--coverage`. - The job ran `npm install` + `npm run build` before the PHP tests. The feature suite is API/JSON only (49/56 feature files use getJson/assertJson) and nothing renders the Vite blade, so the built assets are never needed. Drop the Node/Vite steps; release & docker workflows still build assets. - Tests ran single-process. brianium/paratest is already installed and the runner has 4 cores, so run `php artisan test --parallel`. Validated locally: full suite passes in parallel (exit 0), including repeated runs of the two filesystem-writing module tests — no races. docker.yaml carries the same pattern but only runs on release/nightly cron, so it is left for a follow-up. * ci: apply the same test-job speedups to docker.yaml The release/nightly `tests` job in docker.yaml carried the identical waste that check.yaml had: Xdebug loaded but never used for coverage, an unnecessary frontend build before the PHP tests, and serial execution. Mirror the check.yaml fix: coverage: none, drop the Node/Vite steps (the suite is API/JSON and the separate release_artifact_build job builds its own assets), and run php artisan test --parallel. * ci: run module-scaffolding tests serially under --parallel The Modules/* tests (module:make ScaffoldProbe + modules_statuses.json toggles) mutate shared on-disk module state. paratest isolates the DB per worker but NOT the filesystem, so concurrent workers boot with ScaffoldProbe enabled and fatal on the un-autoloaded ServiceProvider (31 failures). Tag them 'modules' (Pest group on Feature/Company/Modules) and split CI: parallel --exclude-group=modules, then serial --group=modules. * ci: stub Vite in tests + bump all actions to Node 24 versions Part A (fixes #657): the customer-portal entrypoint test renders the SPA shell (app.blade.php → @vite). With the frontend build dropped from CI there's no manifest, so it 500'd (ViteManifestNotFoundException). Call $this->withoutVite() in TestCase::setUp() so SPA-shell renders work without a built manifest; the build stays dropped. Part B: bump every Node-20 action to its node24 release — checkout v4->v6, setup-node v4->v6, paths-filter v3->v4, cancel-workflow-action 0.12.1->0.13.1, softprops/action-gh-release v2->v3, docker/{setup-buildx v3->v4, login v3->v4, metadata v5->v6, build-push v5->v7}. setup-php@v2, ramsey/composer-install@v2 (composite) and svenstaro/upload-release-action@v2 are already node24. * ci: bump ramsey/composer-install v2 -> 4.0.0 (node24 internal cache) composer-install@v2 is composite but internally calls actions/cache@v3 (Node 20), which still trips the deprecation. 4.0.0 uses actions/cache v5.0.3 (Node 24) and keeps the composer-options input we use.
108 lines
3.3 KiB
YAML
108 lines
3.3 KiB
YAML
name: Check
|
|
|
|
# Run this workflow every time a new commit pushed to your repository
|
|
on:
|
|
push:
|
|
tags-ignore:
|
|
- "*"
|
|
branches-ignore:
|
|
- 'translations'
|
|
pull_request:
|
|
branches-ignore:
|
|
- 'translations'
|
|
# Allow manually triggering the workflow.
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
changes:
|
|
name: 🔍 Detect changes
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
php: ${{ steps.filter.outputs.php }}
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Check for file changes
|
|
uses: dorny/paths-filter@v4
|
|
id: filter
|
|
with:
|
|
filters: |
|
|
php:
|
|
- 'app/**'
|
|
- 'config/**'
|
|
- 'database/**'
|
|
- 'routes/**'
|
|
- 'tests/**'
|
|
- 'composer.json'
|
|
- 'composer.lock'
|
|
- 'phpunit.xml'
|
|
|
|
kill_previous:
|
|
name: 0️⃣ Kill previous runs
|
|
runs-on: ubuntu-latest
|
|
# We want to run on external PRs, but not on our own internal PRs as they'll be run by the push to the branch.
|
|
if: (github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository)
|
|
steps:
|
|
- name: Cancel Previous Runs
|
|
uses: styfle/cancel-workflow-action@0.13.1
|
|
with:
|
|
access_token: ${{ github.token }}
|
|
|
|
php_syntax_errors:
|
|
name: 1️⃣ PHP Code Style errors
|
|
runs-on: ubuntu-latest
|
|
needs:
|
|
- kill_previous
|
|
- changes
|
|
if: needs.changes.outputs.php == 'true'
|
|
steps:
|
|
- name: Set up PHP
|
|
uses: shivammathur/setup-php@v2
|
|
with:
|
|
php-version: 8.4
|
|
|
|
- name: Checkout code
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Install dependencies
|
|
uses: ramsey/composer-install@4.0.0
|
|
|
|
- name: Check source code for syntax errors
|
|
run: ./vendor/bin/pint --test
|
|
|
|
tests:
|
|
name: 2️⃣ PHP ${{ matrix.php-version }} Tests
|
|
needs:
|
|
- php_syntax_errors
|
|
- changes
|
|
if: needs.changes.outputs.php == 'true'
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
matrix:
|
|
php-version:
|
|
- 8.4
|
|
env:
|
|
extensions: bcmath, curl, dom, gd, imagick, json, libxml, mbstring, pcntl, pdo, pdo_mysql, zip
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Setup PHP Action
|
|
uses: shivammathur/setup-php@v2
|
|
with:
|
|
php-version: ${{ matrix.php-version }}
|
|
extensions: ${{ env.extensions }}
|
|
coverage: none
|
|
tools: pecl, composer
|
|
|
|
- name: Install Composer dependencies
|
|
uses: ramsey/composer-install@4.0.0
|
|
|
|
- name: Apply tests ${{ matrix.php-version }} (parallel)
|
|
run: php artisan test --parallel --exclude-group=modules
|
|
|
|
- name: Apply module tests ${{ matrix.php-version }} (serial)
|
|
run: php artisan test --group=modules
|