Files
InvoiceShelf/app/Http/Controllers/Company/Members/MembersController.php
Darko Gjorgjijoski c6a00df120 fix(security): enforce company scope on notes, doc-convert, and member bulk-delete (#668)
v3 port of the v2 authorization fixes.

- Notes IDOR (GHSA-85wc): NotePolicy checks the note's company_id and
  NotesController passes the bound model to authorize() on show/update/destroy.
- Estimate<->Invoice convert IDOR (GHSA-j2vg): EstimatesController::convertToInvoice
  and InvoicesController::convertToEstimate authorize 'view' on the source
  document before creating the target.
- Member bulk-delete (GHSA-wxrv): MembersController scopes ids via
  User::whereCompany() before MemberService::delete.

Adds feature tests for cross-company 403s + same-company happy paths.
2026-06-12 11:02:08 +02:00

113 lines
2.7 KiB
PHP

<?php
namespace App\Http\Controllers\Company\Members;
use App\Http\Controllers\Controller;
use App\Http\Requests\DeleteMemberRequest;
use App\Http\Requests\MemberRequest;
use App\Http\Resources\UserResource;
use App\Models\User;
use App\Services\Company\MemberService;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
class MembersController extends Controller
{
public function __construct(
private readonly MemberService $memberService,
) {}
/**
* Display a listing of the resource.
*
* @return JsonResponse
*/
public function index(Request $request)
{
$this->authorize('viewAny', User::class);
$limit = $request->has('limit') ? $request->limit : 10;
$user = $request->user();
$users = User::whereCompany()
->applyFilters($request->all())
->where('id', '<>', $user->id)
->latest()
->paginate($limit);
return UserResource::collection($users)
->additional(['meta' => [
'user_total_count' => User::whereCompany()->count(),
]]);
}
/**
* Store a newly created resource in storage.
*
* @return JsonResponse
*/
public function store(MemberRequest $request)
{
$this->authorize('create', User::class);
$user = $this->memberService->create($request);
return new UserResource($user);
}
/**
* Display the specified resource.
*
* @return JsonResponse
*/
public function show(User $user)
{
$this->authorize('view', $user);
return new UserResource($user);
}
/**
* Update the specified resource in storage.
*
* @return JsonResponse
*/
public function update(MemberRequest $request, User $user)
{
$this->authorize('update', $user);
$this->memberService->update($user, $request);
return new UserResource($user);
}
/**
* Display a listing of the resource.
*
* @param Request $request
* @return JsonResponse
*/
public function delete(DeleteMemberRequest $request)
{
$this->authorize('delete multiple users', User::class);
if ($request->users) {
// Scope the candidate ids to members of the acting company so a user
// from one company cannot delete accounts belonging to another.
$ids = User::whereCompany()
->whereIn('id', $request->users)
->pluck('id')
->toArray();
if ($ids) {
$this->memberService->delete($ids);
}
}
return response()->json([
'success' => true,
]);
}
}