mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-16 22:05:20 +00:00
v3 port of the v2 authorization fixes. - Notes IDOR (GHSA-85wc): NotePolicy checks the note's company_id and NotesController passes the bound model to authorize() on show/update/destroy. - Estimate<->Invoice convert IDOR (GHSA-j2vg): EstimatesController::convertToInvoice and InvoicesController::convertToEstimate authorize 'view' on the source document before creating the target. - Member bulk-delete (GHSA-wxrv): MembersController scopes ids via User::whereCompany() before MemberService::delete. Adds feature tests for cross-company 403s + same-company happy paths.
175 lines
4.6 KiB
PHP
175 lines
4.6 KiB
PHP
<?php
|
|
|
|
namespace App\Http\Controllers\Company\Invoice;
|
|
|
|
use App\Http\Controllers\Controller;
|
|
use App\Http\Requests;
|
|
use App\Http\Requests\DeleteInvoiceRequest;
|
|
use App\Http\Requests\SendInvoiceRequest;
|
|
use App\Http\Resources\EstimateResource;
|
|
use App\Http\Resources\InvoiceResource;
|
|
use App\Jobs\GenerateInvoicePdfJob;
|
|
use App\Models\Estimate;
|
|
use App\Models\Invoice;
|
|
use App\Services\Document\InvoiceService;
|
|
use Illuminate\Http\JsonResponse;
|
|
use Illuminate\Http\Request;
|
|
use Illuminate\Mail\Markdown;
|
|
|
|
class InvoicesController extends Controller
|
|
{
|
|
public function __construct(
|
|
private readonly InvoiceService $invoiceService,
|
|
) {}
|
|
|
|
/**
|
|
* Display a listing of the resource.
|
|
*
|
|
* @return JsonResponse
|
|
*/
|
|
public function index(Request $request)
|
|
{
|
|
$this->authorize('viewAny', Invoice::class);
|
|
|
|
$limit = $request->input('limit', 10);
|
|
|
|
$invoices = Invoice::whereCompany()
|
|
->applyFilters($request->all())
|
|
->with('customer')
|
|
->latest()
|
|
->paginateData($limit);
|
|
|
|
return InvoiceResource::collection($invoices)
|
|
->additional(['meta' => [
|
|
'invoice_total_count' => Invoice::whereCompany()->count(),
|
|
]]);
|
|
}
|
|
|
|
/**
|
|
* Store a newly created resource in storage.
|
|
*
|
|
* @param Request $request
|
|
* @return JsonResponse
|
|
*/
|
|
public function store(Requests\InvoicesRequest $request)
|
|
{
|
|
$this->authorize('create', Invoice::class);
|
|
|
|
$invoice = $this->invoiceService->create($request);
|
|
|
|
if ($request->has('invoiceSend')) {
|
|
$this->invoiceService->send($invoice, $request->only(['subject', 'body']));
|
|
}
|
|
|
|
GenerateInvoicePdfJob::dispatch($invoice);
|
|
|
|
return new InvoiceResource($invoice);
|
|
}
|
|
|
|
/**
|
|
* Display the specified resource.
|
|
*
|
|
* @return JsonResponse
|
|
*/
|
|
public function show(Request $request, Invoice $invoice)
|
|
{
|
|
$this->authorize('view', $invoice);
|
|
|
|
return new InvoiceResource($invoice);
|
|
}
|
|
|
|
/**
|
|
* Update the specified resource in storage.
|
|
*
|
|
* @param Request $request
|
|
* @return JsonResponse
|
|
*/
|
|
public function update(Requests\InvoicesRequest $request, Invoice $invoice)
|
|
{
|
|
$this->authorize('update', $invoice);
|
|
|
|
$invoice = $this->invoiceService->update($invoice, $request);
|
|
|
|
GenerateInvoicePdfJob::dispatch($invoice, true);
|
|
|
|
return new InvoiceResource($invoice);
|
|
}
|
|
|
|
/**
|
|
* delete the specified resources in storage.
|
|
*
|
|
* @param Request $request
|
|
* @return JsonResponse
|
|
*/
|
|
public function delete(DeleteInvoiceRequest $request)
|
|
{
|
|
$this->authorize('delete multiple invoices');
|
|
|
|
$ids = Invoice::whereCompany()
|
|
->whereIn('id', $request->ids)
|
|
->pluck('id');
|
|
|
|
$this->invoiceService->delete($ids);
|
|
|
|
return response()->json([
|
|
'success' => true,
|
|
]);
|
|
}
|
|
|
|
public function send(SendInvoiceRequest $request, Invoice $invoice)
|
|
{
|
|
$this->authorize('send invoice', $invoice);
|
|
|
|
$this->invoiceService->send($invoice, $request->all());
|
|
|
|
return response()->json([
|
|
'success' => true,
|
|
]);
|
|
}
|
|
|
|
public function sendPreview(SendInvoiceRequest $request, Invoice $invoice)
|
|
{
|
|
$this->authorize('send invoice', $invoice);
|
|
|
|
$markdown = new Markdown(view(), config('mail.markdown'));
|
|
|
|
$data = $this->invoiceService->sendInvoiceData($invoice, $request->all());
|
|
$data['url'] = $invoice->invoicePdfUrl;
|
|
|
|
return $markdown->render('emails.send.invoice', ['data' => $data]);
|
|
}
|
|
|
|
public function clone(Request $request, Invoice $invoice)
|
|
{
|
|
$this->authorize('view', $invoice);
|
|
$this->authorize('create', Invoice::class);
|
|
|
|
$newInvoice = $this->invoiceService->clone($invoice);
|
|
|
|
return new InvoiceResource($newInvoice);
|
|
}
|
|
|
|
public function convertToEstimate(Request $request, Invoice $invoice)
|
|
{
|
|
// Authorize access to the source invoice (tenant isolation) in addition
|
|
// to the ability to create an estimate.
|
|
$this->authorize('view', $invoice);
|
|
$this->authorize('create', Estimate::class);
|
|
|
|
$estimate = $this->invoiceService->convertToEstimate($invoice);
|
|
|
|
return new EstimateResource($estimate);
|
|
}
|
|
|
|
public function changeStatus(Request $request, Invoice $invoice)
|
|
{
|
|
$this->authorize('send invoice', $invoice);
|
|
|
|
$this->invoiceService->changeStatus($invoice, $request->status);
|
|
|
|
return response()->json([
|
|
'success' => true,
|
|
]);
|
|
}
|
|
}
|