mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-16 22:05:20 +00:00
The app/Services/ directory had grown into 22 flat files at the root plus 7 uneven subdirectories — finding anything required scrolling through an alphabetical mix of small CRUD services, infrastructure drivers, and install-time utilities. This commit groups services by domain, folds Backup into a new Storage namespace, and moves framework-infrastructure and install-time helpers out of Services and into Support where they belong. New Services layout: Documents/ (Invoice, Estimate, RecurringInvoice, Payment, Expense, Transaction, DocumentItem, SerialNumber, Currency — matches the 'Documents' navigation group); Company/ (Company, Member, Invitation); Mail/ (MailConfiguration, CompanyMailConfig); Storage/ (FileDisk, plus Backup folded in). ExchangeRateProviderService moves next to its drivers in ExchangeRate/; FontService moves into Pdf/ where it belongs. CustomerService, ItemService, CustomFieldService stay at the Services root as standalone single-file domains. Moves to Support/: Hashids/ (library wrapper — not business logic); Setup/ (one-shot install-time utilities — stateless helpers); Pdf/ (ImageUtils, PdfTemplateUtils, plus the existing PdfHtmlSanitizer consolidated into the same subdir). These are all framework infrastructure and stateless utilities — the 'service' label never really fit them. Namespace declarations in 29 moved files updated to match new paths. 62 consumer files (controllers, other services, tests, database factories, seeders, routes, bootstrap/providers.php) have their use statements rewritten via a literal-string replacement script — no regex meant no risk of half-matching. Three Documents services needed an explicit 'use App\Services\Mail\CompanyMailConfigService' added because the same-namespace short reference they relied on no longer resolves after the split. Verified: composer dump-autoload, 350 tests pass (850 assertions), vendor/bin/pint clean, npm run build succeeds.
49 lines
1.2 KiB
PHP
49 lines
1.2 KiB
PHP
<?php
|
|
|
|
use App\Jobs\CreateBackupJob;
|
|
use App\Models\FileDisk;
|
|
use App\Models\User;
|
|
use App\Services\Storage\BackupConfigurationFactory;
|
|
use Illuminate\Support\Facades\Artisan;
|
|
use Illuminate\Support\Facades\Queue;
|
|
use Laravel\Sanctum\Sanctum;
|
|
use Spatie\Backup\Config\Config;
|
|
|
|
use function Pest\Laravel\postJson;
|
|
|
|
beforeEach(function () {
|
|
Artisan::call('db:seed', ['--class' => 'DatabaseSeeder', '--force' => true]);
|
|
Artisan::call('db:seed', ['--class' => 'DemoSeeder', '--force' => true]);
|
|
|
|
Sanctum::actingAs(
|
|
User::findOrFail(1),
|
|
['*']
|
|
);
|
|
});
|
|
|
|
test('create backup does not require company header', function () {
|
|
Queue::fake();
|
|
|
|
$disk = FileDisk::factory()->create();
|
|
|
|
postJson('/api/v1/backups', [
|
|
'option' => 'full',
|
|
'file_disk_id' => $disk->id,
|
|
])->assertOk()->assertJson([
|
|
'success' => true,
|
|
]);
|
|
|
|
Queue::assertPushed(CreateBackupJob::class);
|
|
});
|
|
|
|
test('backup configuration factory does not require company context', function () {
|
|
$disk = FileDisk::factory()->create();
|
|
|
|
$config = BackupConfigurationFactory::make([
|
|
'option' => 'full',
|
|
'file_disk_id' => $disk->id,
|
|
]);
|
|
|
|
expect($config)->toBeInstanceOf(Config::class);
|
|
});
|