mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-08-04 15:12:12 +00:00
3a989923d1
Most of docker.yaml was doing work that was duplicated or hazardous now that releases are cut from a tag. The tests were duplicated exactly: release.yaml and docker.yaml called the same reusable tests.yaml, on the same commit — once before drafting, again after publishing. No new information, and the image build queued behind it. Pint likewise: check.yaml already style-checked the commit when it landed. Both jobs go; coverage is unchanged. manual_docker_build goes too, and it was worse than redundant. Its checkout took no ref, so it built the dispatched branch while tagging with whatever string was typed — an image could be labelled 2.4.2 while containing 2.x HEAD — and `tag` defaulted to "latest", so a careless dispatch republished the moving stable tag from a branch. #710 had to add a guard purely to stop the registration dispatch doing that by accident. It was last used in September 2025 to push the legacy and alpha tags during the Docker distribution work; that is finished, and releases produce images now. A patched base image is better served by a patch release than by silently changing what a pinned tag contains. That cascade removes the tag input and the #710 guard as well, leaving register_tag as the only dispatch input and two jobs in the file. Losing the test gate would leave the image build ungated, so the release build now refuses a release with no InvoiceShelf.zip. A release either came from the tested pipeline or it gets no images — the updater is already protected this way, since registration downloads that same asset. GitHub offers no way to forbid hand-made releases; this is the closest thing, which is to make them inert. "Docker" no longer describes a workflow that registers on the updater and publishes images, so it becomes publish.yaml — matching its trigger and pairing with release.yaml, which prepares what this distributes. The recovery instructions in AGENTS.md name this workflow and would have broken silently, so they move with it.
40 lines
1.1 KiB
YAML
40 lines
1.1 KiB
YAML
name: Tests
|
|
|
|
# Called by publish.yaml and release.yaml rather than duplicated in both. The
|
|
# release artifact's file list used to exist in two places and drift was only a
|
|
# matter of time; the test definition should not repeat that.
|
|
on:
|
|
workflow_call:
|
|
|
|
jobs:
|
|
tests:
|
|
name: PHP Tests
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
matrix:
|
|
php-version:
|
|
- 8.4
|
|
env:
|
|
extensions: bcmath, curl, dom, gd, imagick, json, libxml, mbstring, pcntl, pdo, pdo_mysql, zip
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@v6
|
|
|
|
- name: Setup PHP Action
|
|
uses: shivammathur/setup-php@v2
|
|
with:
|
|
php-version: ${{ matrix.php-version }}
|
|
extensions: ${{ env.extensions }}
|
|
coverage: none
|
|
tools: pecl, composer
|
|
|
|
- name: Install Composer dependencies
|
|
uses: ramsey/composer-install@4.0.0
|
|
|
|
- name: Apply tests ${{ matrix.php-version }} (parallel)
|
|
run: php artisan test --parallel --exclude-group=modules
|
|
|
|
- name: Apply module tests ${{ matrix.php-version }} (serial)
|
|
run: php artisan test --group=modules
|