Files
InvoiceShelf/app/Http/Controllers/Admin/Settings/MailConfigurationController.php
Darko Gjorgjijoski 6d1816bd1b refactor: reorganize app/Services and app/Support by domain
The app/Services/ directory had grown into 22 flat files at the root plus 7 uneven subdirectories — finding anything required scrolling through an alphabetical mix of small CRUD services, infrastructure drivers, and install-time utilities. This commit groups services by domain, folds Backup into a new Storage namespace, and moves framework-infrastructure and install-time helpers out of Services and into Support where they belong.

New Services layout: Documents/ (Invoice, Estimate, RecurringInvoice, Payment, Expense, Transaction, DocumentItem, SerialNumber, Currency — matches the 'Documents' navigation group); Company/ (Company, Member, Invitation); Mail/ (MailConfiguration, CompanyMailConfig); Storage/ (FileDisk, plus Backup folded in). ExchangeRateProviderService moves next to its drivers in ExchangeRate/; FontService moves into Pdf/ where it belongs. CustomerService, ItemService, CustomFieldService stay at the Services root as standalone single-file domains.

Moves to Support/: Hashids/ (library wrapper — not business logic); Setup/ (one-shot install-time utilities — stateless helpers); Pdf/ (ImageUtils, PdfTemplateUtils, plus the existing PdfHtmlSanitizer consolidated into the same subdir). These are all framework infrastructure and stateless utilities — the 'service' label never really fit them.

Namespace declarations in 29 moved files updated to match new paths. 62 consumer files (controllers, other services, tests, database factories, seeders, routes, bootstrap/providers.php) have their use statements rewritten via a literal-string replacement script — no regex meant no risk of half-matching. Three Documents services needed an explicit 'use App\Services\Mail\CompanyMailConfigService' added because the same-namespace short reference they relied on no longer resolves after the split.

Verified: composer dump-autoload, 350 tests pass (850 assertions), vendor/bin/pint clean, npm run build succeeds.
2026-04-11 10:00:00 +02:00

95 lines
2.4 KiB
PHP
Executable File

<?php
namespace App\Http\Controllers\Admin\Settings;
use App\Http\Controllers\Controller;
use App\Http\Requests\MailEnvironmentRequest;
use App\Mail\TestMail;
use App\Models\Setting;
use App\Services\Mail\MailConfigurationService;
use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Mail;
use Illuminate\Validation\ValidationException;
class MailConfigurationController extends Controller
{
public function __construct(private readonly MailConfigurationService $mailConfigurationService) {}
/**
* Save the mail environment variables
*
*
*
* @throws AuthorizationException
*/
public function saveMailEnvironment(MailEnvironmentRequest $request): JsonResponse
{
$this->authorize('manage email config');
$setting = Setting::getSetting('profile_complete');
$this->mailConfigurationService->saveGlobalConfig($request->validated());
if ($setting !== 'COMPLETED') {
Setting::setSetting('profile_complete', 4);
}
return response()->json([
'success' => 'mail_variables_save_successfully',
]);
}
/**
* Return the mail environment variables
*
*
* @throws AuthorizationException
*/
public function getMailEnvironment(): JsonResponse
{
$this->authorize('manage email config');
return response()->json($this->mailConfigurationService->getGlobalConfig());
}
/**
* Return the available mail drivers
*
*
* @throws AuthorizationException
*/
public function getMailDrivers(): JsonResponse
{
$this->authorize('manage email config');
return response()->json($this->mailConfigurationService->getAvailableDrivers());
}
/**
* Test the email configuration
*
*
*
* @throws AuthorizationException
* @throws ValidationException
*/
public function testEmailConfig(Request $request): JsonResponse
{
$this->authorize('manage email config');
$this->validate($request, [
'to' => 'required|email',
'subject' => 'required',
'message' => 'required',
]);
Mail::to($request->to)->send(new TestMail($request->subject, $request->message));
return response()->json([
'success' => true,
]);
}
}