mirror of
https://github.com/InvoiceShelf/InvoiceShelf.git
synced 2026-07-16 22:05:20 +00:00
f657b53215
Services/Integrations/ExchangeRate/ and Services/Pdf/ were both mostly Support-shaped: interfaces, abstract classes, static factories, concrete adapter drivers, DTOs, and exceptions — infrastructure that doesn't carry business logic. They only each had one real DI-injected service mixed in. This commit applies the same Services=DI-business-logic / Support=stateless-plumbing rule we've been using throughout the reorg: **Moved to Support/Integrations/ExchangeRate/** (7 files): ExchangeRateDriver (abstract), ExchangeRateDriverFactory (static), ExchangeRateException, and the four concrete drivers (CurrencyConverter, CurrencyFreak, CurrencyLayer, OpenExchangeRate). These are HTTP adapters over third-party currency APIs — same shape as the Hashids library wrapper classes already in Support. **Moved to Support/Pdf/** (6 files, merging with existing Pdf utilities): PdfDriver (interface), PdfDriverFactory (static), PdfService (static facade), GotenbergPdfDriver, GotenbergPdfResponse (DTO), ResponseStream (interface). The Support/Pdf/ dir now contains the full PDF rendering subsystem — drivers + sanitizer + template/image utilities. **Promoted to Services/ root** (the real DI services): ExchangeRateProviderService (CRUD for ExchangeRateProvider model) and FontService (font package install/download orchestration). Both are proper DI services — instance methods, model writes, HTTP side effects. Services/Integrations/ and Services/Pdf/ are now empty and deleted. Services/ holds only DI-injected classes; Support/ holds all the plumbing. 17 files renamed (git detects 90-99% similarity), 4 consumer files updated (DriverRegistryProvider, PdfServiceProvider, ExchangeRateProviderController, FontController, GeneratesPdfTrait, test). 350 tests pass, Pint clean.
35 lines
857 B
PHP
35 lines
857 B
PHP
<?php
|
|
|
|
namespace App\Support\Integrations\ExchangeRate;
|
|
|
|
abstract class ExchangeRateDriver
|
|
{
|
|
public function __construct(
|
|
protected string $apiKey,
|
|
protected array $config = [],
|
|
) {}
|
|
|
|
/**
|
|
* Fetch exchange rate between two currencies.
|
|
*
|
|
* @return array Exchange rate values
|
|
*/
|
|
abstract public function getExchangeRate(string $baseCurrency, string $targetCurrency): array;
|
|
|
|
/**
|
|
* Get list of currencies supported by this provider.
|
|
*
|
|
* @return array Currency codes
|
|
*/
|
|
abstract public function getSupportedCurrencies(): array;
|
|
|
|
/**
|
|
* Validate that the API key and connection work.
|
|
*
|
|
* @return array Exchange rate values (proof of working connection)
|
|
*
|
|
* @throws ExchangeRateException
|
|
*/
|
|
abstract public function validateConnection(): array;
|
|
}
|