feat: code review notes

This commit is contained in:
Ahmed Bouhuolia
2024-02-21 17:17:34 +02:00
parent d16ec7cda9
commit 1752c32eec
30 changed files with 43 additions and 42 deletions

View File

@@ -61,14 +61,14 @@ export const FinancialSheetStructure = (Base: Class) =>
});
};
findNodeDeep = (nodes, callback) => {
public findNodeDeep = (nodes, callback) => {
return findValueDeep(nodes, callback, {
childrenPath: 'children',
pathFormat: 'array',
});
};
mapAccNodesDeep = (nodes, callback) => {
public mapAccNodesDeep = (nodes, callback) => {
return reduceDeep(
nodes,
(acc, value, key, parentValue, context) => {
@@ -97,11 +97,11 @@ export const FinancialSheetStructure = (Base: Class) =>
});
};
getTotalOfChildrenNodes = (node) => {
public getTotalOfChildrenNodes = (node) => {
return this.getTotalOfNodes(node.children);
};
getTotalOfNodes = (nodes) => {
public getTotalOfNodes = (nodes) => {
return sumBy(nodes, 'total.amount');
};
};