QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-15 20:30:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: code review notes

Browse Source
This commit is contained in:
Ahmed Bouhuolia
2024-02-21 17:17:34 +02:00
parent d16ec7cda9
commit 1752c32eec
30 changed files with 43 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
packages/webapp/src/containers/FinancialStatements/BalanceSheet/BalanceSheetTable.tsx
View File

@@ -9,7 +9,6 @@ import { useBalanceSheetContext } from './BalanceSheetProvider';
import { useBalanceSheetColumns } from './components';
import { defaultExpanderReducer, tableRowTypesToClassnames } from '@/utils';
/**
* Balance sheet table.
*/

2
packages/webapp/src/hooks/query/FinancialReports/use-AP-aging-summary.ts
View File

@@ -58,7 +58,7 @@ export const useAPAgingSheetCsvExport = (query, args) => {
*/
export function useAPAgingSummaryPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/payable_aging_summary`,
url: `/financial_statements/payable_aging_summary`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-AR-aging-summary.ts
View File

@@ -57,7 +57,7 @@ export const useARAgingSheetCsvExport = (query, args) => {
*/
export function useARAgingSummaryPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/receivable_aging_summary`,
url: `/financial_statements/receivable_aging_summary`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-balance-sheet.ts
View File

@@ -76,7 +76,7 @@ export const useBalanceSheetCsvExport = (query, args) => {
*/
export function useBalanceSheetPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/balance_sheet`,
url: `/financial_statements/balance_sheet`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-cashflow-sheet.ts
View File

@@ -77,7 +77,7 @@ export const useCashFlowStatementCsvExport = (query, args) => {
*/
export function useCashflowSheetPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/cash-flow`,
url: `/financial_statements/cash-flow`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-customer-balance-summary.ts
View File

@@ -65,7 +65,7 @@ export const useCustomerBalanceSummaryCsvExport = (query, args) => {
*/
export function useCustomerBalanceSummaryPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/customer-balance-summary`,
url: `/financial_statements/customer-balance-summary`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-customer-transactions.ts
View File

@@ -69,7 +69,7 @@ export const useCustomersTransactionsCsvExport = (query, args) => {
*/
export const useCustomersTransactionsPdfExport = (query = {}) => {
return useRequestPdf({
url: '/api/financial_statements/transactions-by-customers',
url: '/financial_statements/transactions-by-customers',
params: query,
});
};

2
packages/webapp/src/hooks/query/FinancialReports/use-general-ledger.ts
View File

@@ -57,7 +57,7 @@ export const useGeneralLedgerSheetCsvExport = (query, args) => {
*/
export function useGeneralLedgerPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/general_ledger`,
url: `/financial_statements/general_ledger`,
params: query
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-inventory-item-details.ts
View File

@@ -69,7 +69,7 @@ export const useInventoryItemDetailsCsvExport = (query, args) => {
*/
export function useInventoryItemDetailsPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/inventory-item-details`,
url: `/financial_statements/inventory-item-details`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-inventory-valuation.ts
View File

@@ -77,7 +77,7 @@ export const useInventoryValuationCsvExport = (query, args) => {
*/
export function useInventoryValuationPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/inventory-valuation`,
url: `/financial_statements/inventory-valuation`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-journal-sheet.ts
View File

@@ -58,7 +58,7 @@ export const useJournalSheetCsvExport = (query, args) => {
*/
export const useJournalSheetPdf = (query = {}) => {
return useRequestPdf({
url: `/api/financial_statements/journal`,
url: `/financial_statements/journal`,
params: query,
});
};

2
packages/webapp/src/hooks/query/FinancialReports/use-profit-loss-sheet.ts
View File

@@ -58,7 +58,7 @@ export const useProfitLossSheetCsvExport = (query, args) => {
*/
export function useProfitLossSheetPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/profit_loss_sheet`,
url: `/financial_statements/profit_loss_sheet`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-purchases-by-items.ts
View File

@@ -73,7 +73,7 @@ export const usePurchasesByItemsXlsxExport = (query, args) => {
*/
export const usePurchasesByItemsPdfExport = (query = {}) => {
return useRequestPdf({
url: '/api/financial_statements/purchases-by-items',
url: '/financial_statements/purchases-by-items',
params: query,
});
};

2
packages/webapp/src/hooks/query/FinancialReports/use-sales-by-items.ts
View File

@@ -72,7 +72,7 @@ export const useSalesByItemsXlsxExport = (query, args) => {
export const useSalesByItemsPdfExport = (query = {}) => {
return useRequestPdf({
url: '/api/financial_statements/sales-by-items',
url: '/financial_statements/sales-by-items',
params: query,
});
};

2
packages/webapp/src/hooks/query/FinancialReports/use-sales-tax-liabilities-summary.ts
View File

@@ -58,7 +58,7 @@ export const useSalesTaxLiabilitySummaryCsvExport = (query, args) => {
*/
export function useSalesTaxLiabilitySummaryPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/sales-tax-liability-summary`,
url: `/financial_statements/sales-tax-liability-summary`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-trial-balance-sheet.ts
View File

@@ -58,7 +58,7 @@ export const useTrialBalanceSheetCsvExport = (query, args) => {
*/
export function useTrialBalanceSheetPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/trial_balance_sheet`,
url: `/financial_statements/trial_balance_sheet`,
params: query,
});
}

2
packages/webapp/src/hooks/query/FinancialReports/use-vendor-balance-summary.ts
View File

@@ -65,7 +65,7 @@ export const useVendorBalanceSummaryCsvExport = (args) => {
export const useVendorBalanceSummaryPdfExport = (query = {}) => {
return useRequestPdf({
url: '/api/financial_statements/vendor-balance-summary',
url: 'financial_statements/vendor-balance-summary',
params: query,
});
};

2
packages/webapp/src/hooks/query/FinancialReports/use-vendor-transactions.ts
View File

@@ -68,7 +68,7 @@ export const useVendorsTransactionsCsvExport = (query, args) => {
*/
export function useTransactionsByVendorsPdf(query = {}) {
return useRequestPdf({
url: `/api/financial_statements/transactions-by-vendors`,
url: `financial_statements/transactions-by-vendors`,
params: query,
});
}

4
packages/webapp/src/hooks/query/creditNote.tsx
View File

@@ -354,5 +354,7 @@ export function useRefundCreditTransaction(id, props, requestProps) {
* Retrieve the credit note pdf document data,
*/
export function usePdfCreditNote(creditNoteId) {
return useRequestPdf(`sales/credit_notes/${creditNoteId}`);
return useRequestPdf({
url: `sales/credit_notes/${creditNoteId}`,
});
}

4
packages/webapp/src/hooks/query/estimates.tsx
View File

@@ -181,7 +181,9 @@ export function useRejectEstimate(props) {
*/
export function usePdfEstimate(estimateId) {
return useRequestPdf(`sales/estimates/${estimateId}`);
return useRequestPdf({
url: `sales/estimates/${estimateId}`,
});
}
export function useRefreshEstimates() {

7
packages/webapp/src/hooks/query/invoices.tsx
View File

@@ -24,7 +24,7 @@ const commonInvalidateQueries = (queryClient) => {
// Invalidate financial reports.
queryClient.invalidateQueries(t.FINANCIAL_REPORT);
// Invalidate transactions by reference.
queryClient.invalidateQueries(t.TRANSACTIONS_BY_REFERENCE);
@@ -188,7 +188,9 @@ export function useInvoice(invoiceId, props, requestProps) {
* Retrieve the invoice pdf document data.
*/
export function usePdfInvoice(invoiceId) {
return useRequestPdf(`sales/invoices/${invoiceId}`);
return useRequestPdf({
url: `sales/invoices/${invoiceId}`,
});
}
/**
@@ -339,4 +341,3 @@ export function useSaleInvoiceDefaultOptions(invoiceId, props) {
},
);
}

3
packages/webapp/src/hooks/query/paymentReceives.tsx
View File

@@ -233,9 +233,10 @@ export function usePaymentReceiveSMSDetail(
/**
* Retrieve the payment receive pdf document data.
* @param {number} paymentReceiveId - Payment receive id.
*/
export function usePdfPaymentReceive(paymentReceiveId) {
return useRequestPdf(`sales/payment_receives/${paymentReceiveId}`);
return useRequestPdf({ url: `sales/payment_receives/${paymentReceiveId}` });
}
export function useSendPaymentReceiveMail(props) {

7
packages/webapp/src/hooks/query/receipts.tsx
View File

@@ -162,9 +162,12 @@ export function useReceipt(id, props) {
/**
* Retrieve the receipt pdf document data.
* @param {number} receiptId -
*/
export function usePdfReceipt(ReceiptId) {
return useRequestPdf(`sales/receipts/${ReceiptId}`);
export function usePdfReceipt(receiptId: number) {
return useRequestPdf({
url: `sales/receipts/${receiptId}`,
});
}
export function useRefreshReceipts() {

2
packages/webapp/src/hooks/query/transactionsLocking.tsx
View File

@@ -1,9 +1,7 @@
// @ts-nocheck
import { useQueryClient, useMutation } from 'react-query';
import { useRequestQuery } from '../useQueryRequest';
import { transformPagination } from '@/utils';
import useApiRequest from '../useRequest';
import { useRequestPdf } from '../utils';
import t from './types';
// Common invalidate queries.

1
packages/webapp/src/hooks/useRequestPdf.tsx
View File

@@ -16,6 +16,7 @@ export const useRequestPdf = (httpProps) => {
headers: { accept: 'application/pdf' },
responseType: 'blob',
...httpProps,
url: `/api/${httpProps?.url}`,
})
.then((response) => {
// Create a Blob from the PDF Stream.