wip

packages/server/src/modules/CreditNotes/BulkDeleteCreditNotes.service.ts

@@ -12,17 +12,25 @@ export class BulkDeleteCreditNotesService {
 
   async bulkDeleteCreditNotes(
     creditNoteIds: number | Array<number>,
+    options?: { skipUndeletable?: boolean },
     trx?: Knex.Transaction,
   ): Promise<void> {
+    const { skipUndeletable = false } = options ?? {};
     const notesIds = uniq(castArray(creditNoteIds));
 
     const results = await PromisePool.withConcurrency(1)
       .for(notesIds)
       .process(async (creditNoteId: number) => {
-        await this.deleteCreditNoteService.deleteCreditNote(creditNoteId);
+        try {
+          await this.deleteCreditNoteService.deleteCreditNote(creditNoteId);
+        } catch (error) {
+          if (!skipUndeletable) {
+            throw error;
+          }
+        }
       });
 
-    if (results.errors && results.errors.length > 0) {
+    if (!skipUndeletable && results.errors && results.errors.length > 0) {
       throw results.errors[0].raw;
     }
   }

packages/server/src/modules/CreditNotes/CreditNoteApplication.service.ts

@@ -107,9 +107,13 @@ export class CreditNoteApplication {
    * @param {number[]} creditNoteIds
    * @returns {Promise<void>}
    */
-  bulkDeleteCreditNotes(creditNoteIds: number[]) {
+  bulkDeleteCreditNotes(
+    creditNoteIds: number[],
+    options?: { skipUndeletable?: boolean },
+  ) {
     return this.bulkDeleteCreditNotesService.bulkDeleteCreditNotes(
       creditNoteIds,
+      options,
     );
   }
 

packages/server/src/modules/CreditNotes/CreditNotes.controller.ts

@@ -3,6 +3,7 @@ import {
   ApiOperation,
   ApiResponse,
   ApiParam,
+  ApiQuery,
   ApiExtraModels,
   getSchemaPath,
 } from '@nestjs/swagger';
@@ -11,7 +12,9 @@ import {
   Controller,
   Delete,
   Get,
+  DefaultValuePipe,
   Param,
+  ParseBoolPipe,
   Post,
   Put,
   Query,
@@ -37,7 +40,7 @@ export class CreditNotesController {
   /**
    * @param {CreditNoteApplication} creditNoteApplication - The credit note application service.
    */
-  constructor(private creditNoteApplication: CreditNoteApplication) {}
+  constructor(private creditNoteApplication: CreditNoteApplication) { }
 
   @Post()
   @ApiOperation({ summary: 'Create a new credit note' })
@@ -140,13 +143,25 @@ export class CreditNotesController {
 
   @Post('bulk-delete')
   @ApiOperation({ summary: 'Deletes multiple credit notes.' })
+  @ApiQuery({
+    name: 'skip_undeletable',
+    required: false,
+    type: Boolean,
+    description:
+      'When true, undeletable credit notes will be skipped and only deletable ones will be removed.',
+  })
   @ApiResponse({
     status: 200,
     description: 'Credit notes deleted successfully',
   })
-  bulkDeleteCreditNotes(@Body() bulkDeleteDto: BulkDeleteDto): Promise<void> {
+  bulkDeleteCreditNotes(
+    @Body() bulkDeleteDto: BulkDeleteDto,
+    @Query('skip_undeletable', new DefaultValuePipe(false), ParseBoolPipe)
+    skipUndeletable: boolean,
+  ): Promise<void> {
     return this.creditNoteApplication.bulkDeleteCreditNotes(
       bulkDeleteDto.ids,
+      { skipUndeletable },
     );
   }