wip

packages/server/src/modules/Expenses/BulkDeleteExpenses.service.ts

@@ -6,21 +6,29 @@ import { DeleteExpense } from './commands/DeleteExpense.service';
 
 @Injectable()
 export class BulkDeleteExpensesService {
-  constructor(private readonly deleteExpenseService: DeleteExpense) {}
+  constructor(private readonly deleteExpenseService: DeleteExpense) { }
 
   async bulkDeleteExpenses(
     expenseIds: number | Array<number>,
+    options?: { skipUndeletable?: boolean },
     trx?: Knex.Transaction,
   ): Promise<void> {
+    const { skipUndeletable = false } = options ?? {};
     const expensesIds = uniq(castArray(expenseIds));
 
     const results = await PromisePool.withConcurrency(1)
       .for(expensesIds)
       .process(async (expenseId: number) => {
-        await this.deleteExpenseService.deleteExpense(expenseId);
+        try {
+          await this.deleteExpenseService.deleteExpense(expenseId);
+        } catch (error) {
+          if (!skipUndeletable) {
+            throw error;
+          }
+        }
       });
 
-    if (results.errors && results.errors.length > 0) {
+    if (!skipUndeletable && results.errors && results.errors.length > 0) {
       throw results.errors[0].raw;
     }
   }

packages/server/src/modules/Expenses/Expenses.controller.ts

@@ -7,12 +7,15 @@ import {
   Post,
   Put,
   Query,
+  DefaultValuePipe,
+  ParseBoolPipe,
 } from '@nestjs/common';
 import { ExpensesApplication } from './ExpensesApplication.service';
 import { IExpensesFilter } from './Expenses.types';
 import {
   ApiExtraModels,
   ApiOperation,
+  ApiQuery,
   ApiResponse,
   ApiTags,
   getSchemaPath,
@@ -59,12 +62,25 @@ export class ExpensesController {
 
   @Post('bulk-delete')
   @ApiOperation({ summary: 'Deletes multiple expenses.' })
+  @ApiQuery({
+    name: 'skip_undeletable',
+    required: false,
+    type: Boolean,
+    description:
+      'When true, undeletable expenses will be skipped and only deletable ones will be removed.',
+  })
   @ApiResponse({
     status: 200,
     description: 'Expenses deleted successfully',
   })
-  public bulkDeleteExpenses(@Body() bulkDeleteDto: BulkDeleteDto) {
-    return this.expensesApplication.bulkDeleteExpenses(bulkDeleteDto.ids);
+  public bulkDeleteExpenses(
+    @Body() bulkDeleteDto: BulkDeleteDto,
+    @Query('skip_undeletable', new DefaultValuePipe(false), ParseBoolPipe)
+    skipUndeletable: boolean,
+  ) {
+    return this.expensesApplication.bulkDeleteExpenses(bulkDeleteDto.ids, {
+      skipUndeletable,
+    });
   }
 
   /**

packages/server/src/modules/Expenses/ExpensesApplication.service.ts

@@ -21,7 +21,7 @@ export class ExpensesApplication {
     private readonly getExpensesService: GetExpensesService,
     private readonly bulkDeleteExpensesService: BulkDeleteExpensesService,
     private readonly validateBulkDeleteExpensesService: ValidateBulkDeleteExpensesService,
-  ) {}
+  ) { }
 
   /**
    * Create a new expense transaction.
@@ -55,8 +55,14 @@ export class ExpensesApplication {
    * Deletes expenses in bulk.
    * @param {number[]} expenseIds - Expense ids.
    */
-  public bulkDeleteExpenses(expenseIds: number[]) {
-    return this.bulkDeleteExpensesService.bulkDeleteExpenses(expenseIds);
+  public bulkDeleteExpenses(
+    expenseIds: number[],
+    options?: { skipUndeletable?: boolean },
+  ) {
+    return this.bulkDeleteExpensesService.bulkDeleteExpenses(
+      expenseIds,
+      options,
+    );
   }
 
   /**