wip

packages/server/src/modules/ManualJournals/BulkDeleteManualJournals.service.ts

@@ -8,23 +8,31 @@ import { DeleteManualJournalService } from './commands/DeleteManualJournal.servi
 export class BulkDeleteManualJournalsService {
   constructor(
     private readonly deleteManualJournalService: DeleteManualJournalService,
-  ) {}
+  ) { }
 
   async bulkDeleteManualJournals(
     manualJournalIds: number | Array<number>,
+    options?: { skipUndeletable?: boolean },
     trx?: Knex.Transaction,
   ): Promise<void> {
+    const { skipUndeletable = false } = options ?? {};
     const journalsIds = uniq(castArray(manualJournalIds));
 
     const results = await PromisePool.withConcurrency(1)
       .for(journalsIds)
       .process(async (manualJournalId: number) => {
-        await this.deleteManualJournalService.deleteManualJournal(
-          manualJournalId,
-        );
+        try {
+          await this.deleteManualJournalService.deleteManualJournal(
+            manualJournalId,
+          );
+        } catch (error) {
+          if (!skipUndeletable) {
+            throw error;
+          }
+        }
       });
 
-    if (results.errors && results.errors.length > 0) {
+    if (!skipUndeletable && results.errors && results.errors.length > 0) {
       throw results.errors[0].raw;
     }
   }

packages/server/src/modules/ManualJournals/ManualJournals.controller.ts

@@ -8,12 +8,15 @@ import {
   Post,
   Put,
   Query,
+  DefaultValuePipe,
+  ParseBoolPipe,
 } from '@nestjs/common';
 import { ManualJournalsApplication } from './ManualJournalsApplication.service';
 import {
   ApiExtraModels,
   ApiOperation,
   ApiParam,
+  ApiQuery,
   ApiResponse,
   ApiTags,
   getSchemaPath,
@@ -61,15 +64,25 @@ export class ManualJournalsController {
 
   @Post('bulk-delete')
   @ApiOperation({ summary: 'Deletes multiple manual journals.' })
+  @ApiQuery({
+    name: 'skip_undeletable',
+    required: false,
+    type: Boolean,
+    description:
+      'When true, undeletable journals will be skipped and only deletable ones will be removed.',
+  })
   @ApiResponse({
     status: 200,
     description: 'Manual journals deleted successfully',
   })
   public bulkDeleteManualJournals(
     @Body() bulkDeleteDto: BulkDeleteDto,
+    @Query('skip_undeletable', new DefaultValuePipe(false), ParseBoolPipe)
+    skipUndeletable: boolean,
   ): Promise<void> {
     return this.manualJournalsApplication.bulkDeleteManualJournals(
       bulkDeleteDto.ids,
+      { skipUndeletable },
     );
   }
 

packages/server/src/modules/ManualJournals/ManualJournalsApplication.service.ts

@@ -25,7 +25,7 @@ export class ManualJournalsApplication {
     private getManualJournalsService: GetManualJournals,
     private bulkDeleteManualJournalsService: BulkDeleteManualJournalsService,
     private validateBulkDeleteManualJournalsService: ValidateBulkDeleteManualJournalsService,
-  ) {}
+  ) { }
 
   /**
    * Make journal entries.
@@ -65,9 +65,13 @@ export class ManualJournalsApplication {
    * Bulk deletes manual journals.
    * @param {number[]} manualJournalIds
    */
-  public bulkDeleteManualJournals = (manualJournalIds: number[]) => {
+  public bulkDeleteManualJournals = (
+    manualJournalIds: number[],
+    options?: { skipUndeletable?: boolean },
+  ) => {
     return this.bulkDeleteManualJournalsService.bulkDeleteManualJournals(
       manualJournalIds,
+      options,
     );
   };