QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-13 03:10:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: match uncategorized bank transactions

Browse Source
This commit is contained in:
Ahmed Bouhuolia
2025-12-22 23:02:08 +02:00
parent a9a7cd8617
commit 37f0f4e227
3 changed files with 37 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
packages/server/src/modules/BankingMatching/_utils.ts
View File

@@ -1,6 +1,6 @@
import * as moment from 'moment';
import * as R from 'ramda';
import { isEmpty, sumBy } from 'lodash';
import { isEmpty, round, sumBy } from 'lodash';
import { ERRORS, MatchedTransactionPOJO } from './types';
import { ServiceError } from '../Items/ServiceError';
@@ -22,18 +22,24 @@ export const sortClosestMatchTransactions = (
};
export const sumMatchTranasctions = (transactions: Array<any>) => {
return transactions.reduce(
(total, item) =>
total +
(item.transactionNormal === 'debit' ? 1 : -1) * parseFloat(item.amount),
const total = transactions.reduce(
(sum, item) => {
const amount = parseFloat(item.amount) || 0;
const multiplier = item.transactionNormal === 'debit' ? 1 : -1;
return sum + multiplier * amount;
},
0
);
// Round to 2 decimal places to avoid floating-point precision issues
return round(total, 2);
};
export const sumUncategorizedTransactions = (
uncategorizedTransactions: Array<any>
) => {
return sumBy(uncategorizedTransactions, 'amount');
const total = sumBy(uncategorizedTransactions, 'amount');
// Round to 2 decimal places to avoid floating-point precision issues
return round(total, 2);
};
export const validateUncategorizedTransactionsNotMatched = (