From 38a961b8993b32ab008dd6e61608e15e606c89b0 Mon Sep 17 00:00:00 2001 From: elforjani13 <39470382+elforjani13@users.noreply.github.com> Date: Wed, 6 Jul 2022 13:44:00 +0200 Subject: [PATCH] fix: additional notes. --- src/common/modalChargeOptions.tsx | 17 ---- src/components/Datatable/TableHeader.js | 30 ++++--- src/components/DialogsContainer.js | 12 +-- ...ChargeSelect.tsx => ChangeTypesSelect.tsx} | 17 ++-- src/containers/Projects/components/index.ts | 2 +- .../EstimatedExpenseFormChargeFields.tsx | 4 +- .../EstimatedExpenseFormFields.tsx | 6 +- .../ProjectDetailActionsBar.tsx | 4 +- .../Timesheets/TimesheetsTable.tsx | 7 +- .../ProjectDetails/Timesheets/components.tsx | 43 +--------- .../ProjectDetails/Timesheets/hooks.ts | 43 ++++++++++ .../containers/ProjectDetails/index.tsx | 4 +- .../components/ProjectSelect.tsx | 63 ++++++++++++++ .../components/TaskSelect.tsx | 63 ++++++++++++++ .../ProjectsLanding/ProjectsDataTable.tsx | 3 +- .../containers/common/modalChargeOptions.ts | 17 ++++ src/lang/en/index.json | 86 +++++++++---------- 17 files changed, 276 insertions(+), 145 deletions(-) delete mode 100644 src/common/modalChargeOptions.tsx rename src/containers/Projects/components/{ChargeSelect.tsx => ChangeTypesSelect.tsx} (58%) create mode 100644 src/containers/Projects/containers/ProjectDetails/Timesheets/hooks.ts create mode 100644 src/containers/Projects/containers/ProjectTimeEntryFormDialog/components/ProjectSelect.tsx create mode 100644 src/containers/Projects/containers/ProjectTimeEntryFormDialog/components/TaskSelect.tsx create mode 100644 src/containers/Projects/containers/common/modalChargeOptions.ts diff --git a/src/common/modalChargeOptions.tsx b/src/common/modalChargeOptions.tsx deleted file mode 100644 index fd832c48e..000000000 --- a/src/common/modalChargeOptions.tsx +++ /dev/null @@ -1,17 +0,0 @@ -import intl from 'react-intl-universal'; - -export const taskChargeOptions = [ - { name: intl.get('task.dialog.hourly_rate'), value: 'Hourly rate' }, - { name: intl.get('task.dialog.fixed_price'), value: 'Fixed price' }, - { name: intl.get('task.dialog.non_chargeable'), value: 'Non-chargeable' }, -]; - -export const expenseChargeOption = [ - { - name: intl.get('expenses.dialog.markup'), - value: '% markup', - }, - { name: intl.get('expenses.dialog.pass_cost_on'), value: 'Pass cost on' }, - { name: intl.get('expenses.dialog.custom_pirce'), value: 'Custom Pirce' }, - { name: intl.get('expenses.dialog.non_chargeable'), value: 'Non-chargeable' }, -]; diff --git a/src/components/Datatable/TableHeader.js b/src/components/Datatable/TableHeader.js index 9fcbb2686..57b5be5cd 100644 --- a/src/components/Datatable/TableHeader.js +++ b/src/components/Datatable/TableHeader.js @@ -91,20 +91,24 @@ export default function TableHeader() { if (headerLoading && TableHeaderSkeletonRenderer) { return ; } + + // Can't contiunue if the thead is disabled. + if (hideTableHeader) { + return null; + } + return ( - !hideTableHeader && ( - -
-
- {headerGroups.map((headerGroup, index) => ( - - ))} - - - -
+ +
+
+ {headerGroups.map((headerGroup, index) => ( + + ))} + + +
- - ) +
+
); } diff --git a/src/components/DialogsContainer.js b/src/components/DialogsContainer.js index d7c037f32..861c74b72 100644 --- a/src/components/DialogsContainer.js +++ b/src/components/DialogsContainer.js @@ -41,9 +41,9 @@ import WarehouseActivateDialog from '../containers/Dialogs/WarehouseActivateDial import CustomerOpeningBalanceDialog from '../containers/Dialogs/CustomerOpeningBalanceDialog'; import VendorOpeningBalanceDialog from '../containers/Dialogs/VendorOpeningBalanceDialog'; import ProjectFormDialog from '../containers/Projects/containers/ProjectFormDialog'; -import TaskFormDialog from '../containers/Projects/containers/TaskFormDialog'; -import TimeEntryFormDialog from '../containers/Projects/containers/TimeEntryFormDialog'; -import ExpenseFormDialog from '../containers/Projects/containers/ExpenseFormDialog'; +import ProjectTaskFormDialog from '../containers/Projects/containers/ProjectTaskFormDialog'; +import ProjectTimeEntryFormDialog from '../containers/Projects/containers/ProjectTimeEntryFormDialog'; +import ProjectExpenseForm from '../containers/Projects/containers/ProjectExpenseForm'; import EstimatedExpenseFormDialog from '../containers/Projects/containers/EstimatedExpenseFormDialog'; /** @@ -96,9 +96,9 @@ export default function DialogsContainer() { - - - + + +
); diff --git a/src/containers/Projects/components/ChargeSelect.tsx b/src/containers/Projects/components/ChangeTypesSelect.tsx similarity index 58% rename from src/containers/Projects/components/ChargeSelect.tsx rename to src/containers/Projects/components/ChangeTypesSelect.tsx index 2a11908c0..956c1d25f 100644 --- a/src/containers/Projects/components/ChargeSelect.tsx +++ b/src/containers/Projects/components/ChangeTypesSelect.tsx @@ -1,6 +1,7 @@ + import React from 'react'; import { MenuItem, Button } from '@blueprintjs/core'; -import { FSelect } from 'components'; +import { FSelect } from '../../../components'; /** * @@ -8,7 +9,7 @@ import { FSelect } from 'components'; * @param {*} param1 * @returns */ -const chargeItemRenderer = (item, { handleClick, modifiers, query }) => { +const chargeTypeItemRenderer = (item, { handleClick, modifiers, query }) => { return ( { ); }; -const chargeItemSelectProps = { - itemRenderer: chargeItemRenderer, +const chargeTypeSelectProps = { + itemRenderer: chargeTypeItemRenderer, valueAccessor: 'value', labelAccessor: 'name', }; @@ -30,13 +31,13 @@ const chargeItemSelectProps = { * @param param0 * @returns */ -export function ChargeSelect({ items, ...rest }) { +export function ChangeTypesSelect({ items, ...rest }) { return ( ); } @@ -45,6 +46,6 @@ export function ChargeSelect({ items, ...rest }) { * @param param0 * @returns */ -function ChargeSelectButton({ label }) { +function ChargeTypeSelectButton({ label }) { return