diff --git a/packages/webapp/src/containers/Purchases/PaymentsMade/PaymentForm/PaymentMadeFormHeaderFields.tsx b/packages/webapp/src/containers/Purchases/PaymentsMade/PaymentForm/PaymentMadeFormHeaderFields.tsx index c6b01ae9b..112b2e552 100644 --- a/packages/webapp/src/containers/Purchases/PaymentsMade/PaymentForm/PaymentMadeFormHeaderFields.tsx +++ b/packages/webapp/src/containers/Purchases/PaymentsMade/PaymentForm/PaymentMadeFormHeaderFields.tsx @@ -12,8 +12,13 @@ import { Button, } from '@blueprintjs/core'; import { DateInput } from '@blueprintjs/datetime'; -import { FastField, Field, useFormikContext, ErrorMessage } from 'formik'; -import { FormattedMessage as T, VendorsSelect } from '@/components'; +import { FastField, useFormikContext, ErrorMessage } from 'formik'; +import { + FInputGroup, + FMoneyInputGroup, + FormattedMessage as T, + VendorsSelect, +} from '@/components'; import { CLASSES } from '@/constants/classes'; import { @@ -25,7 +30,6 @@ import { Hint, Icon, VendorDrawerLink, - MoneyInputGroup, } from '@/components'; import withCurrentOrganization from '@/containers/Organization/withCurrentOrganization'; import { usePaymentMadeFormContext } from './PaymentMadeFormProvider'; @@ -49,7 +53,7 @@ import { accountsFieldShouldUpdate, vendorsFieldShouldUpdate } from './utils'; function PaymentMadeFormHeaderFields({ organization: { base_currency } }) { // Formik form context. const { - values: { entries }, + values: { entries, currency_code }, setFieldValue, } = useFormikContext(); @@ -115,47 +119,34 @@ function PaymentMadeFormHeaderFields({ organization: { base_currency } }) { {/* ------------ Full amount ------------ */} - - {({ - form: { - values: { currency_code, entries }, - }, - field: { value }, - meta: { error, touched }, - }) => ( - } - inline={true} - className={('form-group--full-amount', Classes.FILL)} - intent={inputIntent({ error, touched })} - labelInfo={} - helperText={} - > - - - { - setFieldValue('amount', value); - }} - onBlurValue={onFullAmountBlur} - /> - + } + inline={true} + labelInfo={} + fastField + > + + + + - {!isEmpty(entries) && ( - - )} - + {!isEmpty(entries) && ( + )} - + {/* ------------ Payment number ------------ */} @@ -203,23 +194,14 @@ function PaymentMadeFormHeaderFields({ organization: { base_currency } }) { {/* ------------ Reference ------------ */} - - {({ form, field, meta: { error, touched } }) => ( - } - inline={true} - className={classNames('form-group--reference', Classes.FILL)} - intent={inputIntent({ error, touched })} - helperText={} - > - - - )} - + } + inline={true} + fastField + > + + ); } diff --git a/packages/webapp/src/containers/Purchases/PaymentsMade/PaymentForm/utils.tsx b/packages/webapp/src/containers/Purchases/PaymentsMade/PaymentForm/utils.tsx index 8b8323939..1bd2f3c01 100644 --- a/packages/webapp/src/containers/Purchases/PaymentsMade/PaymentForm/utils.tsx +++ b/packages/webapp/src/containers/Purchases/PaymentsMade/PaymentForm/utils.tsx @@ -53,7 +53,6 @@ export const defaultPaymentMade = { export const transformToEditForm = (paymentMade, paymentMadeEntries) => { const attachments = transformAttachmentsToForm(paymentMade); - const appliedAmount = safeSumBy(paymentMadeEntries, 'payment_amount'); return { ...transformToForm(paymentMade, defaultPaymentMade), diff --git a/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveForm.schema.tsx b/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveForm.schema.tsx index ab7654bc1..fdbec8e9e 100644 --- a/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveForm.schema.tsx +++ b/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveForm.schema.tsx @@ -9,7 +9,7 @@ const Schema = Yup.object().shape({ deposit_account_id: Yup.number() .required() .label(intl.get('deposit_account_')), - full_amount: Yup.number().nullable(), + amount: Yup.number().required().label('Amount'), payment_receive_no: Yup.string() .nullable() .max(DATATYPES_LENGTH.STRING) diff --git a/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveFormAlerts.tsx b/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveFormAlerts.tsx index d482ad990..7d1643390 100644 --- a/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveFormAlerts.tsx +++ b/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveFormAlerts.tsx @@ -13,7 +13,7 @@ export default function PaymentReceiveFormAlerts() { const handleClearingAllLines = () => { const newEntries = clearAllPaymentEntries(entries); setFieldValue('entries', newEntries); - setFieldValue('full_amount', ''); + setFieldValue('amount', ''); }; return ( diff --git a/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveHeaderFields.tsx b/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveHeaderFields.tsx index 98b9fe4e2..71ff9bfc8 100644 --- a/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveHeaderFields.tsx +++ b/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/PaymentReceiveHeaderFields.tsx @@ -12,12 +12,13 @@ import { } from '@blueprintjs/core'; import { DateInput } from '@blueprintjs/datetime'; import { isEmpty, toSafeInteger } from 'lodash'; -import { FastField, Field, useFormikContext, ErrorMessage } from 'formik'; +import { FastField, useFormikContext, ErrorMessage } from 'formik'; import { FeatureCan, CustomersSelect, FormattedMessage as T, + FMoneyInputGroup, } from '@/components'; import { CLASSES } from '@/constants/classes'; import { @@ -32,7 +33,6 @@ import { AccountsSelect, FieldRequiredHint, Icon, - MoneyInputGroup, InputPrependText, CustomerDrawerLink, Hint, @@ -64,7 +64,7 @@ export default function PaymentReceiveHeaderFields() { // Formik form context. const { - values: { entries }, + values: { entries, currency_code }, setFieldValue, } = useFormikContext(); @@ -79,7 +79,7 @@ export default function PaymentReceiveHeaderFields() { const fullAmount = safeSumBy(newEntries, 'payment_amount'); setFieldValue('entries', newEntries); - setFieldValue('full_amount', fullAmount); + setFieldValue('amount', fullAmount); }; // Handles the full-amount field blur. const onFullAmountBlur = (value) => { @@ -124,48 +124,34 @@ export default function PaymentReceiveHeaderFields() { {/* ------------ Full amount ------------ */} - - {({ - form: { - setFieldValue, - values: { currency_code, entries }, - }, - field: { value, onChange }, - meta: { error, touched }, - }) => ( - } - inline={true} - className={('form-group--full-amount', CLASSES.FILL)} - intent={inputIntent({ error, touched })} - labelInfo={} - helperText={} - > - - - { - setFieldValue('amount', value); - }} - onBlurValue={onFullAmountBlur} - /> - + } + inline={true} + labelInfo={} + fastField + > + + + + - {!isEmpty(entries) && ( - - )} - + {!isEmpty(entries) && ( + )} - + {/* ------------ Payment receive no. ------------ */} @@ -197,23 +183,14 @@ export default function PaymentReceiveHeaderFields() { {/* ------------ Reference No. ------------ */} - - {({ form, field, meta: { error, touched } }) => ( - } - inline={true} - className={classNames('form-group--reference', CLASSES.FILL)} - intent={inputIntent({ error, touched })} - helperText={} - > - - - )} - + } + inline={true} + fastField + > + + {/*------------ Project name -----------*/} diff --git a/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/utils.tsx b/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/utils.tsx index 3d02486e6..bbd416248 100644 --- a/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/utils.tsx +++ b/packages/webapp/src/containers/Sales/PaymentsReceived/PaymentReceiveForm/utils.tsx @@ -71,7 +71,6 @@ export const defaultRequestPayment = { */ export const transformToEditForm = (paymentReceive, paymentReceiveEntries) => ({ ...transformToForm(paymentReceive, defaultPaymentReceive), - full_amount: safeSumBy(paymentReceiveEntries, 'payment_amount'), entries: [ ...paymentReceiveEntries.map((paymentReceiveEntry) => ({ ...transformToForm(paymentReceiveEntry, defaultPaymentReceiveEntry),