From 46d895bef9d608f0299292a2f311b218332f9a2e Mon Sep 17 00:00:00 2001 From: elforjani13 <39470382+elforjani13@users.noreply.github.com> Date: Thu, 31 Mar 2022 14:50:40 +0200 Subject: [PATCH] BIG-354: Validate the warehouse transfer. --- .../WarehouseTransferForm/WarehouseTransferForm.js | 13 ------------- .../WarehouseTransferForm.schema.js | 2 +- .../WarehouseTransferFormEntriesTable.js | 2 +- 3 files changed, 2 insertions(+), 15 deletions(-) diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js index 7a9f77a34..07bcb913e 100644 --- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js +++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.js @@ -71,19 +71,6 @@ function WarehouseTransferForm({ // Handles form submit. const handleSubmit = (values, { setSubmitting, setErrors, resetForm }) => { - setSubmitting(true); - const totalQuantity = sumBy(values.entries, 'quantity'); - - if (totalQuantity <= 0) { - AppToaster.show({ - message: intl.get( - 'warehouse_transfer.quantity_cannot_be_zero_or_empty', - ), - intent: Intent.DANGER, - }); - return; - } - // Transformes the values of the form to request. const form = { ...transformValueToRequest(values), diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.schema.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.schema.js index 026bc5e20..3fab6b29a 100644 --- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.schema.js +++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferForm.schema.js @@ -20,7 +20,7 @@ const Schema = Yup.object().shape({ Yup.object().shape({ item_id: Yup.number().nullable(), description: Yup.string().nullable().max(DATATYPES_LENGTH.TEXT), - quantity: Yup.number().nullable().max(DATATYPES_LENGTH.INT_10), + quantity: Yup.number().min(1).max(DATATYPES_LENGTH.INT_10), }), ), }); diff --git a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormEntriesTable.js b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormEntriesTable.js index b4336cb13..09e8f5990 100644 --- a/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormEntriesTable.js +++ b/src/containers/WarehouseTransfers/WarehouseTransferForm/WarehouseTransferFormEntriesTable.js @@ -45,7 +45,7 @@ export default function WarehouseTransferFormEntriesTable({ item_id: newRowMeta.itemId, warehouses: newRowMeta.warehouses, description: '', - quantity: 0, + quantity: '', }; const newRows = mutateTableRow(newRowMeta.rowIndex, newRow, entries);