QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-15 20:30:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(nestjs): transaction locking

Browse Source
This commit is contained in:
Ahmed Bouhuolia
2025-04-07 13:35:02 +02:00
parent 443fbdd89e
commit 4febc4e502
9 changed files with 14 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
packages/server/src/modules/Branches/integrations/ValidateBranchExistance.ts
View File

@@ -22,7 +22,7 @@ export class ValidateBranchExistance {
public validateTransactionBranchWhenActive = async (
branchId: number | null,
) => {
const isActive = this.branchesSettings.isMultiBranchesActive();
const isActive = await this.branchesSettings.isMultiBranchesActive();
// Can't continue if the multi-warehouses feature is inactive.
if (!isActive) return;

2
packages/server/src/modules/Metable/MetableStore.ts
View File

@@ -119,8 +119,8 @@ export class MetableStore implements IMetableStore {
value: newValue,
key,
...extraColumns,
group: extraColumns?.group || 'default',
_markAsInserted: true,
group: 'default',
});
}
}

5
packages/server/src/modules/TransactionsLocking/dtos/TransactionsLocking.dto.ts
View File

@@ -1,9 +1,14 @@
import { Type } from 'class-transformer';
import { IsString } from 'class-validator';
import { IsNotEmpty } from 'class-validator';
import { IsDate } from 'class-validator';
export class TransactionsLockingDto {
@IsString()
module: string;
@IsDate()
@Type(() => Date)
@IsNotEmpty()
lockToDate: Date;

4
packages/server/src/modules/TransactionsLocking/guards/PurchasesTransactionLockingGuard.ts
View File

@@ -1,7 +1,7 @@
import { TransactionsLockingGroup } from '../types/TransactionsLocking.types';
import { Injectable } from '@nestjs/common';
import { TransactionsLockingGuard } from './TransactionsLockingGuard';
import { MomentInput } from 'moment';
import { TransactionsLockingGroup } from '../types/TransactionsLocking.types';
import { TransactionsLockingGuard } from './TransactionsLockingGuard';
@Injectable()
export class PurchasesTransactionLockingGuard {

4
packages/server/src/modules/TransactionsLocking/guards/SalesTransactionLockingGuard.ts
View File

@@ -1,7 +1,7 @@
import { TransactionsLockingGroup } from '../types/TransactionsLocking.types';
import { Injectable } from '@nestjs/common';
import { TransactionsLockingGuard } from './TransactionsLockingGuard';
import { MomentInput } from 'moment';
import { TransactionsLockingGroup } from '../types/TransactionsLocking.types';
import { TransactionsLockingGuard } from './TransactionsLockingGuard';
@Injectable()
export class SalesTransactionLockingGuard {

5
packages/server/src/modules/TransactionsLocking/guards/TransactionsLockingGuard.ts
View File

@@ -70,7 +70,8 @@ export class TransactionsLockingGuard {
) => {
const { lockToDate } =
await this.transactionsLockingRepo.getTransactionsLocking(lockingGroup);
throw new ServiceError(ERRORS.TRANSACTIONS_DATE_LOCKED, null, {
throw new ServiceError(ERRORS.TRANSACTIONS_DATE_LOCKED, 'Transactions locked', {
lockedToDate: lockToDate,
formattedLockedToDate: moment(lockToDate).format('YYYY/MM/DD'),
});
@@ -88,14 +89,12 @@ export class TransactionsLockingGuard {
const lockingType =
await this.transactionsLockingRepo.getTransactionsLockingType();
//
if (lockingType === TransactionsLockingGroup.All) {
return this.validateTransactionsLocking(
transactionDate,
TransactionsLockingGroup.All,
);
}
//
return this.validateTransactionsLocking(transactionDate, moduleType);
};
}

2
packages/server/src/modules/TransactionsLocking/types/TransactionsLocking.types.ts
View File

@@ -19,13 +19,11 @@ export enum TransactionsLockingType {
}
export interface ITransactionsLockingPartialUnlocked {
tenantId: number;
module: TransactionsLockingGroup;
transactionLockingDTO: ITransactionsLockingAllDTO;
}
export interface ITransactionsLockingCanceled {
tenantId: number;
module: TransactionsLockingGroup;
cancelLockingDTO: ICancelTransactionsLockingDTO;
}

7
packages/server/src/modules/Warehouses/Warehouse.types.ts
View File

@@ -64,26 +64,22 @@ export interface IEditWarehouseTransferDTO {
}
export interface IWarehouseEditPayload {
tenantId: number;
warehouseId: number;
warehouseDTO: IEditWarehouseDTO;
trx: Knex.Transaction;
}
export interface IWarehouseEditedPayload {
tenantId: number;
warehouse: IWarehouse;
warehouseDTO: IEditWarehouseDTO;
trx: Knex.Transaction;
}
export interface IWarehouseDeletePayload {
// tenantId: number;
warehouseId: number;
trx: Knex.Transaction;
}
export interface IWarehouseDeletedPayload {
tenantId: number;
warehouseId: number;
trx: Knex.Transaction;
}
@@ -101,7 +97,6 @@ export interface IWarehouseCreatedPayload {
export interface IWarehouseTransferCreate {
trx: Knex.Transaction;
warehouseTransferDTO: ICreateWarehouseTransferDTO;
tenantId: number;
}
export interface IWarehouseTransferCreated {
@@ -146,10 +141,8 @@ export interface IItemWarehouseQuantityChange {
}
export interface IWarehousesActivatePayload {
// tenantId: number;
}
export interface IWarehousesActivatedPayload {
// tenantId: number;
primaryWarehouse: Warehouse;
}