fix: assign contacts customer/vendor in make jorunal.

server/src/api/controllers/ManualJournals.ts

@@ -128,7 +128,6 @@ export default class ManualJournalsController extends BaseController {
         .optional({ nullable: true })
         .isInt({ max: DATATYPES_LENGTH.INT_10 })
         .toInt(),
-      check('entries.*.contact_type').optional().isIn(['vendor', 'customer']),
     ];
   }
 

server/src/database/migrations/20200105195825_create_manual_journals_entries_table.js

@@ -6,7 +6,6 @@ exports.up = function(knex) {
     table.decimal('debit', 13, 3);
     table.integer('index').unsigned();
     table.integer('account_id').unsigned().index().references('id').inTable('accounts');
-    table.string('contact_type').nullable().index();
     table.integer('contact_id').unsigned().nullable().index();
     table.string('note');
     table.integer('manual_journal_id').unsigned().index().references('id').inTable('manual_journals');

server/src/interfaces/ManualJournal.ts

@@ -25,7 +25,6 @@ export interface IManualJournalEntry {
   accountId: number;
   note: string;
   contactId?: number;
-  contactType?: string;
 }
 
 export interface IManualJournalEntryDTO {
@@ -35,7 +34,6 @@ export interface IManualJournalEntryDTO {
   accountId: number;
   note: string;
   contactId?: number;
-  contactType?: string;
 }
 
 export interface IManualJournalDTO {

server/src/services/ManualJournals/ManualJournalsService.ts

@@ -1,7 +1,7 @@
 import { difference, sumBy, omit, map } from 'lodash';
 import { Service, Inject } from 'typedi';
 import moment from 'moment';
-import { ServiceError } from 'exceptions';
+import { ServiceError, ServiceErrors } from 'exceptions';
 import {
   IManualJournalDTO,
   IManualJournalsService,
@@ -187,15 +187,27 @@ export default class ManualJournalsService implements IManualJournalsService {
   private async validateAccountWithContactType(
     tenantId: number,
     entriesDTO: IManualJournalEntry[],
-
     accountBySlug: string,
     contactType: string
-  ): Promise<void> {
-    const { Account, Contact } = this.tenancy.models(tenantId);
+  ): Promise<void | ServiceError> {
+    const { Account } = this.tenancy.models(tenantId);
+    const { contactRepository } = this.tenancy.repositories(tenantId);
 
     // Retrieve account meta by the given account slug.
     const account = await Account.query().findOne('slug', accountBySlug);
 
+    // Retrieve all stored contacts on the storage from contacts entries.
+    const storedContacts = await contactRepository.findWhereIn(
+      'id',
+      entriesDTO
+        .filter((entry) => entry.contactId)
+        .map((entry) => entry.contactId)
+    );
+    // Converts the stored contacts to map with id as key and entry as value.
+    const storedContactsMap = new Map(
+      storedContacts.map((contact) => [contact.id, contact])
+    );
+
     // Filter all entries of the given account.
     const accountEntries = entriesDTO.filter(
       (entry) => entry.accountId === account.id
@@ -205,14 +217,15 @@ export default class ManualJournalsService implements IManualJournalsService {
       return;
     }
     // Filter entries that have no contact type or not equal the valid type.
-    const entriesNoContact = accountEntries.filter(
-      (entry) => !entry.contactType || entry.contactType !== contactType
-    );
+    const entriesNoContact = accountEntries.filter((entry) => {
+      const contact = storedContactsMap.get(entry.contactId);
+      return !contact || contact.contactService !== contactType;
+    });
     // Throw error in case one of entries that has invalid contact type.
     if (entriesNoContact.length > 0) {
       const indexes = entriesNoContact.map((e) => e.index);
 
-      throw new ServiceError(ERRORS.ENTRIES_SHOULD_ASSIGN_WITH_CONTACT, '', {
+      return new ServiceError(ERRORS.ENTRIES_SHOULD_ASSIGN_WITH_CONTACT, '', {
         accountSlug: accountBySlug,
         contactType,
         indexes,
@@ -242,11 +255,25 @@ export default class ManualJournalsService implements IManualJournalsService {
         'accounts-payable',
         'vendor'
       ),
-    ]);
+    ]).then((results) => {
+      const metadataErrors = results
+        .filter((result) => result instanceof ServiceError)
+        .map((result: ServiceError) => result.payload);
+
+      if (metadataErrors.length > 0) {
+        throw new ServiceError(
+          ERRORS.ENTRIES_SHOULD_ASSIGN_WITH_CONTACT,
+          '',
+          metadataErrors
+        );
+      }
+
+      return results;
+    });
   }
 
   /**
-   * Vaplidate entries contacts existance.
+   * Validate entries contacts existance.
    * @param {number} tenantId -
    * @param {IManualJournalDTO} manualJournalDTO
    */
@@ -280,10 +307,7 @@ export default class ManualJournalsService implements IManualJournalsService {
         const storedContact = storedContactsMap.get(contactEntry.contactId);
 
         // in case the contact id not found.
-        if (
-          !storedContact ||
-          storedContact.contactService !== contactEntry.contactType
-        ) {
+        if (!storedContact) {
           notFoundContactsIds.push(storedContact);
         }
       });
@@ -347,7 +371,8 @@ export default class ManualJournalsService implements IManualJournalsService {
     // Settings tenant service.
     const settings = this.tenancy.settings(tenantId);
     const currencyCode = settings.get({
-      group: 'organization', key: 'base_currency',
+      group: 'organization',
+      key: 'base_currency',
     });
     // Validate manual journal number require.
     this.validateJournalNoRequire(journalNumber);
@@ -803,7 +828,7 @@ export default class ManualJournalsService implements IManualJournalsService {
 
     return manualJournal;
   }
-  
+
   /**
    * Reverts the manual journal journal entries.
    * @param {number} tenantId