wip

packages/server/src/modules/Items/BulkDeleteItems.service.ts

@@ -6,7 +6,7 @@ import { DeleteItemService } from './DeleteItem.service';
 
 @Injectable()
 export class BulkDeleteItemsService {
-  constructor(private readonly deleteItemService: DeleteItemService) { }
+  constructor(private readonly deleteItemService: DeleteItemService) {}
 
   /**
    * Deletes multiple items.
@@ -15,23 +15,26 @@ export class BulkDeleteItemsService {
    */
   async bulkDeleteItems(
     itemIds: number | Array<number>,
+    options?: { skipUndeletable?: boolean },
     trx?: Knex.Transaction,
   ): Promise<void> {
+    const { skipUndeletable = false } = options ?? {};
     const itemsIds = uniq(castArray(itemIds));
 
-    // Use PromisePool to delete items sequentially (concurrency: 1)
-    // to avoid potential database locks and maintain transaction integrity
     const results = await PromisePool.withConcurrency(1)
       .for(itemsIds)
       .process(async (itemId: number) => {
-        await this.deleteItemService.deleteItem(itemId, trx);
+        try {
+          await this.deleteItemService.deleteItem(itemId, trx);
+        } catch (error) {
+          if (!skipUndeletable) {
+            throw error;
+          }
+        }
       });
 
-    // Check if there were any errors
-    if (results.errors && results.errors.length > 0) {
-      // If needed, you can throw an error here or handle errors individually
-      // For now, we'll let individual errors bubble up
-      throw results.errors[0].raw;
+    if (!skipUndeletable && results.errors && results.errors.length > 0) {
+      throw results.errors[0].raw ?? results.errors[0];
     }
   }
 }

packages/server/src/modules/Items/Item.controller.ts

@@ -374,6 +374,8 @@ export class ItemsController extends TenantController {
   async bulkDeleteItems(
     @Body() bulkDeleteDto: BulkDeleteItemsDto,
   ): Promise<void> {
-    return this.itemsApplication.bulkDeleteItems(bulkDeleteDto.ids);
+    return this.itemsApplication.bulkDeleteItems(bulkDeleteDto.ids, {
+      skipUndeletable: bulkDeleteDto.skipUndeletable ?? false,
+    });
   }
 }

packages/server/src/modules/Items/ItemsApplication.service.ts

@@ -158,7 +158,10 @@ export class ItemsApplicationService {
    * @param {number[]} itemIds - Array of item IDs to delete
    * @returns {Promise<void>}
    */
-  async bulkDeleteItems(itemIds: number[]): Promise<void> {
-    return this.bulkDeleteItemsService.bulkDeleteItems(itemIds);
+  async bulkDeleteItems(
+    itemIds: number[],
+    options?: { skipUndeletable?: boolean },
+  ): Promise<void> {
+    return this.bulkDeleteItemsService.bulkDeleteItems(itemIds, options);
   }
 }

packages/server/src/modules/Items/dtos/BulkDeleteItems.dto.ts

@@ -1,5 +1,13 @@
-import { IsArray, IsInt, ArrayNotEmpty } from 'class-validator';
-import { ApiProperty } from '@nestjs/swagger';
+import {
+  IsArray,
+  IsInt,
+  ArrayNotEmpty,
+  IsOptional,
+  IsBoolean,
+} from 'class-validator';
+import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
+import { Transform } from 'class-transformer';
+import { parseBoolean } from '@/utils/parse-boolean';
 
 export class BulkDeleteItemsDto {
   @IsArray()
@@ -11,6 +19,17 @@ export class BulkDeleteItemsDto {
     example: [1, 2, 3],
   })
   ids: number[];
+
+  @IsOptional()
+  @IsBoolean()
+  @Transform(({ value, obj }) => parseBoolean(value ?? obj?.skip_undeletable, false))
+  @ApiPropertyOptional({
+    description:
+      'When true, undeletable items will be skipped and only deletable ones removed.',
+    type: Boolean,
+    default: false,
+  })
+  skipUndeletable?: boolean;
 }
 
 export class ValidateBulkDeleteItemsResponseDto {