From 5ecdf9289dd3cece9012cf64a5216da359f41771 Mon Sep 17 00:00:00 2001
From: Ahmed Bouhuolia <a.bouhuolia@live.com>
Date: Wed, 21 Oct 2020 01:53:30 +0200
Subject: [PATCH] feat: add view details and edit icons.

---
 .../containers/Accounting/ManualJournalsDataTable.js |  5 ++++-
 client/src/containers/Accounts/AccountsDataTable.js  |  5 ++++-
 client/src/containers/Expenses/ExpenseDataTable.js   |  6 +++++-
 client/src/static/json/icons.js                      | 12 ++++++++++++
 4 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/client/src/containers/Accounting/ManualJournalsDataTable.js b/client/src/containers/Accounting/ManualJournalsDataTable.js
index 71bfbb4a2..52e5523ca 100644
--- a/client/src/containers/Accounting/ManualJournalsDataTable.js
+++ b/client/src/containers/Accounting/ManualJournalsDataTable.js
@@ -113,7 +113,9 @@ function ManualJournalsDataTable({
   const actionMenuList = useCallback(
     (journal) => (
       <Menu>
-        <MenuItem text={formatMessage({ id: 'view_details' })} />
+        <MenuItem
+          icon={<Icon icon="reader-18" />}
+          text={formatMessage({ id: 'view_details' })} />
         <MenuDivider />
         <If condition={!journal.status}>
           <MenuItem
@@ -122,6 +124,7 @@ function ManualJournalsDataTable({
           />
         </If>
         <MenuItem
+          icon={<Icon icon="pen-18" />}
           text={formatMessage({ id: 'edit_journal' })}
           onClick={handleEditJournal(journal)}
         />
diff --git a/client/src/containers/Accounts/AccountsDataTable.js b/client/src/containers/Accounts/AccountsDataTable.js
index 0d8c1de4b..c52e7053a 100644
--- a/client/src/containers/Accounts/AccountsDataTable.js
+++ b/client/src/containers/Accounts/AccountsDataTable.js
@@ -157,9 +157,12 @@ function AccountsDataTable({
   const actionMenuList = useCallback(
     (account) => (
       <Menu>
-        <MenuItem text={formatMessage({ id: 'view_details' })} />
+        <MenuItem
+          icon={<Icon icon="reader-18" />}
+          text={formatMessage({ id: 'view_details' })} />
         <MenuDivider />
         <MenuItem
+          icon={<Icon icon="pen-18" />}
           text={formatMessage({ id: 'edit_account' })}
           onClick={handleEditAccount(account)}
         />
diff --git a/client/src/containers/Expenses/ExpenseDataTable.js b/client/src/containers/Expenses/ExpenseDataTable.js
index a5ac30e5f..82643c1d9 100644
--- a/client/src/containers/Expenses/ExpenseDataTable.js
+++ b/client/src/containers/Expenses/ExpenseDataTable.js
@@ -105,7 +105,9 @@ function ExpensesDataTable({
   const actionMenuList = useCallback(
     (expense) => (
       <Menu>
-        <MenuItem text={formatMessage({ id: 'view_details' })} />
+        <MenuItem
+          icon={<Icon icon="reader-18" />}
+          text={formatMessage({ id: 'view_details' })} />
         <MenuDivider />
         <If condition={!expense.published}>
           <MenuItem
@@ -115,10 +117,12 @@ function ExpensesDataTable({
         </If>
 
         <MenuItem
+          icon={<Icon icon="pen-18" />}
           text={formatMessage({ id: 'edit_expense' })}
           onClick={handleEditExpense(expense)}
         />
         <MenuItem
+          icon={<Icon icon="trash-16" iconSize={16} />}
           text={formatMessage({ id: 'delete_expense' })}
           intent={Intent.DANGER}
           onClick={handleDeleteExpense(expense)}
diff --git a/client/src/static/json/icons.js b/client/src/static/json/icons.js
index bfe440098..903f415c0 100644
--- a/client/src/static/json/icons.js
+++ b/client/src/static/json/icons.js
@@ -281,4 +281,16 @@ export default {
     ],
     viewBox: '0 0 24 24',
   },
+  'pen-18': {
+    path: [
+      'M3 17.25V21h3.75L17.81 9.94l-3.75-3.75L3 17.25zM20.71 7.04c.39-.39.39-1.02 0-1.41l-2.34-2.34c-.39-.39-1.02-.39-1.41 0l-1.83 1.83 3.75 3.75 1.83-1.83z',
+    ],
+    viewBox: '0 0 24 24',
+  },
+  'reader-18': {
+    path: [
+      'M13 12h7v1.5h-7zm0-2.5h7V11h-7zm0 5h7V16h-7zM21 4H3c-1.1 0-2 .9-2 2v13c0 1.1.9 2 2 2h18c1.1 0 2-.9 2-2V6c0-1.1-.9-2-2-2zm0 15h-9V6h9v13z',
+    ],
+    viewBox: '0 0 24 24',
+  }
 };