From 8826d2bc5b227ba5d4e2082f193bc110e43a244b Mon Sep 17 00:00:00 2001 From: elforjani13 <39470382+elforjani13@users.noreply.github.com> Date: Sun, 10 Jul 2022 17:41:50 +0200 Subject: [PATCH] fix: notes. --- src/components/Datatable/TableHeader.js | 8 +- .../Projects/components/ChangeTypesSelect.tsx | 1 - .../ProjectsSelect.tsx} | 10 +-- .../components/TaskSelect.tsx | 3 +- src/containers/Projects/components/index.ts | 4 +- .../ProjectDetailActionsBar.tsx | 12 ++- .../ProjectDetails/ProjectDetailTabs.tsx | 12 +-- .../ProjectPurchasesTable.tsx} | 30 ++------ .../ProjectPurchasesTable/components.tsx | 21 ++++++ .../hooks.ts} | 27 +------ .../ProjectPurchasesTable/index.tsx | 16 ++++ .../ProjectSalesTable.tsx} | 33 +++------ .../ProjectSalesTable/components.tsx | 22 ++++++ .../hooks.ts} | 27 +------ .../ProjectSalesTable/index.tsx | 18 +++++ .../ProjectTimesheetsHeader.tsx} | 4 +- .../ProjectTimesheetsTable.tsx} | 74 ++++++++----------- .../components.tsx | 0 .../hooks.ts | 4 +- .../ProjectTimeSheets/index.tsx | 27 +++++++ .../ProjectDetails/Purchases/index.tsx | 35 --------- .../containers/ProjectDetails/Sales/index.tsx | 18 ----- .../ProjectDetails/Timesheets/index.tsx | 27 ------- .../containers/ProjectDetails/common.ts | 9 +++ .../components/FinancialSection.tsx | 2 - ...lect.tsx => ProjectTransactionsSelect.tsx} | 12 +-- .../ProjectDetails/components/index.tsx | 3 +- .../ProjectFormDialog/ProjectForm.schema.tsx | 2 +- .../ProjectFormDialog/ProjectForm.tsx | 2 +- .../ProjectFormDialog/ProjectFormFields.tsx | 6 +- .../ProjectTaskFormDialog/components.tsx | 51 ------------- .../ProjectTimeEntryFormFields.tsx | 6 +- .../components/ProjectSelect.tsx | 63 ---------------- .../components/index.ts | 2 - .../ProjectsLanding/ProjectsDataTable.tsx | 40 +++++----- .../containers/ProjectsLanding/components.tsx | 3 +- src/lang/en/index.json | 12 +-- 37 files changed, 240 insertions(+), 406 deletions(-) rename src/containers/Projects/{containers/ProjectDetails/components/ProjectSelect.tsx => components/ProjectsSelect.tsx} (80%) rename src/containers/Projects/{containers/ProjectTimeEntryFormDialog => }/components/TaskSelect.tsx (95%) rename src/containers/Projects/containers/ProjectDetails/{Purchases/PurchasesTable.tsx => ProjectPurchasesTable/ProjectPurchasesTable.tsx} (71%) create mode 100644 src/containers/Projects/containers/ProjectDetails/ProjectPurchasesTable/components.tsx rename src/containers/Projects/containers/ProjectDetails/{Purchases/components.tsx => ProjectPurchasesTable/hooks.ts} (71%) create mode 100644 src/containers/Projects/containers/ProjectDetails/ProjectPurchasesTable/index.tsx rename src/containers/Projects/containers/ProjectDetails/{Sales/SalesTable.tsx => ProjectSalesTable/ProjectSalesTable.tsx} (69%) create mode 100644 src/containers/Projects/containers/ProjectDetails/ProjectSalesTable/components.tsx rename src/containers/Projects/containers/ProjectDetails/{Sales/components.tsx => ProjectSalesTable/hooks.ts} (71%) create mode 100644 src/containers/Projects/containers/ProjectDetails/ProjectSalesTable/index.tsx rename src/containers/Projects/containers/ProjectDetails/{Timesheets/TimesheetsHeader.tsx => ProjectTimeSheets/ProjectTimesheetsHeader.tsx} (94%) rename src/containers/Projects/containers/ProjectDetails/{Timesheets/TimesheetsTable.tsx => ProjectTimeSheets/ProjectTimesheetsTable.tsx} (58%) rename src/containers/Projects/containers/ProjectDetails/{Timesheets => ProjectTimeSheets}/components.tsx (100%) rename src/containers/Projects/containers/ProjectDetails/{Timesheets => ProjectTimeSheets}/hooks.ts (90%) create mode 100644 src/containers/Projects/containers/ProjectDetails/ProjectTimeSheets/index.tsx delete mode 100644 src/containers/Projects/containers/ProjectDetails/Purchases/index.tsx delete mode 100644 src/containers/Projects/containers/ProjectDetails/Sales/index.tsx delete mode 100644 src/containers/Projects/containers/ProjectDetails/Timesheets/index.tsx create mode 100644 src/containers/Projects/containers/ProjectDetails/common.ts rename src/containers/Projects/containers/ProjectDetails/components/{TransactionSelect.tsx => ProjectTransactionsSelect.tsx} (75%) delete mode 100644 src/containers/Projects/containers/ProjectTaskFormDialog/components.tsx delete mode 100644 src/containers/Projects/containers/ProjectTimeEntryFormDialog/components/ProjectSelect.tsx delete mode 100644 src/containers/Projects/containers/ProjectTimeEntryFormDialog/components/index.ts diff --git a/src/components/Datatable/TableHeader.js b/src/components/Datatable/TableHeader.js index 57b5be5cd..b05c15c67 100644 --- a/src/components/Datatable/TableHeader.js +++ b/src/components/Datatable/TableHeader.js @@ -88,15 +88,15 @@ export default function TableHeader() { }, } = useContext(TableContext); - if (headerLoading && TableHeaderSkeletonRenderer) { - return ; - } - // Can't contiunue if the thead is disabled. if (hideTableHeader) { return null; } + if (headerLoading && TableHeaderSkeletonRenderer) { + return ; + } + return (
diff --git a/src/containers/Projects/components/ChangeTypesSelect.tsx b/src/containers/Projects/components/ChangeTypesSelect.tsx index 956c1d25f..61763206d 100644 --- a/src/containers/Projects/components/ChangeTypesSelect.tsx +++ b/src/containers/Projects/components/ChangeTypesSelect.tsx @@ -1,4 +1,3 @@ - import React from 'react'; import { MenuItem, Button } from '@blueprintjs/core'; import { FSelect } from '../../../components'; diff --git a/src/containers/Projects/containers/ProjectDetails/components/ProjectSelect.tsx b/src/containers/Projects/components/ProjectsSelect.tsx similarity index 80% rename from src/containers/Projects/containers/ProjectDetails/components/ProjectSelect.tsx rename to src/containers/Projects/components/ProjectsSelect.tsx index 1d7d55960..2e715af80 100644 --- a/src/containers/Projects/containers/ProjectDetails/components/ProjectSelect.tsx +++ b/src/containers/Projects/components/ProjectsSelect.tsx @@ -11,7 +11,7 @@ import { FSelect } from 'components'; * @param {*} exactMatch * @returns */ -const projectItemPredicate = (query, project, _index, exactMatch) => { +const projectsItemPredicate = (query, project, _index, exactMatch) => { const normalizedTitle = project.name.toLowerCase(); const normalizedQuery = query.toLowerCase(); @@ -28,7 +28,7 @@ const projectItemPredicate = (query, project, _index, exactMatch) => { * @param {*} param1 * @returns */ -const projectItemRenderer = (project, { handleClick, modifiers, query }) => { +const projectsItemRenderer = (project, { handleClick, modifiers, query }) => { return ( { }; const projectSelectProps = { - itemPredicate: projectItemPredicate, - itemRenderer: projectItemRenderer, + itemPredicate: projectsItemPredicate, + itemRenderer: projectsItemRenderer, valueAccessor: 'id', labelAccessor: 'name', }; -export function ProjectSelect({ projects, ...rest }) { +export function ProjectsSelect({ projects, ...rest }) { return ( -