fix: delete inventory adjustment gl entries

packages/server/src/modules/InventoryAdjutments/commands/DeleteInventoryAdjustment.service.ts

@@ -46,7 +46,7 @@ export class DeleteInventoryAdjustmentService {
     return this.uow.withTransaction(async (trx: Knex.Transaction) => {
       // Triggers `onInventoryAdjustmentDeleting` event.
       await this.eventEmitter.emitAsync(events.inventoryAdjustment.onDeleting, {
-        oldInventoryAdjustment,
+        inventoryAdjustment: oldInventoryAdjustment,
         trx,
       } as IInventoryAdjustmentDeletingPayload);
 

packages/server/src/modules/InventoryAdjutments/commands/ledger/InventoryAdjustmentsGLEntries.ts

@@ -31,7 +31,7 @@ export class InventoryAdjustmentsGLEntries {
     const adjustment = await this.inventoryAdjustment()
       .query(trx)
       .findById(inventoryAdjustmentId)
-      .withGraphFetched('entries.item');
+      .withGraphFetched('entries.item.inventoryAccount');
 
     const tenantMeta = await this.tenancyContext.getTenantMetadata();
 

packages/server/src/modules/InventoryAdjutments/subscribers/InventoryAdjustmentGL.subscriber.ts

@@ -1,7 +1,10 @@
 import { Injectable } from '@nestjs/common';
 import { OnEvent } from '@nestjs/event-emitter';
 import { InventoryAdjustmentsGLEntries } from '../commands/ledger/InventoryAdjustmentsGLEntries';
-import { IInventoryAdjustmentEventDeletedPayload } from '../types/InventoryAdjustments.types';
+import {
+  IInventoryAdjustmentDeletingPayload,
+  IInventoryAdjustmentEventPublishedPayload,
+} from '../types/InventoryAdjustments.types';
 import { IInventoryAdjustmentEventCreatedPayload } from '../types/InventoryAdjustments.types';
 import { events } from '@/common/events/events';
 
@@ -13,10 +16,11 @@ export class InventoryAdjustmentsGLSubscriber {
 
   /**
    * Handles writing increment inventory adjustment GL entries.
+   * @param {IInventoryAdjustmentEventCreatedPayload} payload - 
    */
   @OnEvent(events.inventoryAdjustment.onQuickCreated)
   @OnEvent(events.inventoryAdjustment.onPublished)
-  public async handleGLEntriesOnceIncrementAdjustmentCreated({
+  async handleGLEntriesOnceIncrementAdjustmentCreated({
     inventoryAdjustmentId,
     inventoryAdjustment,
     trx,
@@ -37,19 +41,20 @@ export class InventoryAdjustmentsGLSubscriber {
 
   /**
    * Reverts the inventory adjustment GL entries once the transaction deleted.
-   * @param {IInventoryAdjustmentEventDeletedPayload} payload -
+   * @param {IInventoryAdjustmentDeletingPayload} payload -
    */
-  @OnEvent(events.inventoryAdjustment.onDeleted)
-  public async revertAdjustmentGLEntriesOnceDeleted({
-    inventoryAdjustmentId,
-    oldInventoryAdjustment,
-  }: IInventoryAdjustmentEventDeletedPayload) {
+  @OnEvent(events.inventoryAdjustment.onDeleting)
+  async revertAdjustmentGLEntriesOnceDeleted({
+    inventoryAdjustment,
+    trx,
+  }: IInventoryAdjustmentDeletingPayload) {
     // Can't continue if the inventory adjustment is not published.
-    if (!oldInventoryAdjustment.isPublished) {
+    if (!inventoryAdjustment.isPublished) {
       return;
     }
     await this.inventoryAdjustmentGL.revertAdjustmentGLEntries(
-      inventoryAdjustmentId,
+      inventoryAdjustment.id,
+      trx,
     );
   }
 
@@ -58,39 +63,16 @@ export class InventoryAdjustmentsGLSubscriber {
    * @param {IInventoryAdjustmentEventPublishedPayload} payload
    * @param {IInventoryAdjustmentEventCreatedPayload} payload -
    */
-  // private handleWriteInventoryTransactionsOncePublished = async ({
-  //   inventoryAdjustment,
-  //   trx,
-  // }:
-  //   | IInventoryAdjustmentEventPublishedPayload
-  //   | IInventoryAdjustmentEventCreatedPayload) => {
-  //   await this.inventoryAdjustment.writeInventoryTransactions(
-  //     tenantId,
-  //     inventoryAdjustment,
-  //     false,
-  //     trx
-  //   );
-  // };
-
-  /**
-   * Handles reverting invetory transactions once the inventory adjustment deleted.
-   * @param {IInventoryAdjustmentEventDeletedPayload} payload -
-   */
-  // private handleRevertInventoryTransactionsOnceDeleted = async ({
-  //   tenantId,
-  //   inventoryAdjustmentId,
-  //   oldInventoryAdjustment,
-  //   trx,
-  // }: IInventoryAdjustmentEventDeletedPayload) => {
-  //   // Can't continue if the inventory adjustment is not published.
-  //   if (!oldInventoryAdjustment.isPublished) {
-  //     return;
-  //   }
-  //   // Reverts the inventory transactions of adjustment transaction.
-  //   await this.inventoryAdjustment.revertInventoryTransactions(
-  //     tenantId,
-  //     inventoryAdjustmentId,
-  //     trx
-  //   );
-  // };
+  @OnEvent(events.inventoryAdjustment.onPublished)
+  async handleWriteInventoryTransactionsOncePublished({
+    inventoryAdjustmentId,
+    trx,
+  }:
+    | IInventoryAdjustmentEventPublishedPayload
+    | IInventoryAdjustmentEventCreatedPayload) {
+    await this.inventoryAdjustmentGL.writeAdjustmentGLEntries(
+      inventoryAdjustmentId,
+      trx,
+    );
+  }
 }

packages/server/src/modules/InventoryAdjutments/types/InventoryAdjustments.types.ts

@@ -51,7 +51,7 @@ export interface IInventoryAdjustmentEventDeletedPayload {
 }
 
 export interface IInventoryAdjustmentDeletingPayload {
-  oldInventoryAdjustment: InventoryAdjustment;
+  inventoryAdjustment: InventoryAdjustment;
   trx: Knex.Transaction;
 }