QT/bigcapital
1
0
Fork 0
mirror of https://github.com/bigcapitalhq/bigcapital.git synced 2026-02-17 05:10:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle delete vendor/vendors that has/have associated bills.

Browse Source
This commit is contained in:
a.bouhuolia
2021-01-02 13:38:01 +02:00
parent db70d04743
commit 905cbbed70
3 changed files with 19 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
server/src/services/Contacts/VendorsService.ts
View File

@@ -1,5 +1,5 @@
import { Inject, Service } from 'typedi';
import { difference, defaultTo } from 'lodash';
import { intersection, defaultTo } from 'lodash';
import {
EventDispatcher,
EventDispatcherInterface,
@@ -220,10 +220,14 @@ export default class VendorsService {
): Promise<void> {
const { Contact } = this.tenancy.models(tenantId);
// Validate the given vendors exists on the storage.
await this.getVendorsOrThrowErrorNotFound(tenantId, vendorsIds);
// Validate the given vendors have no assocaited bills.
await this.vendorsHaveNoBillsOrThrowError(tenantId, vendorsIds);
await Contact.query().whereIn('id', vendorsIds).delete();
await this.eventDispatcher.dispatch(events.vendors.onBulkDeleted, {
tenantId,
vendorsIds,
@@ -262,7 +266,7 @@ export default class VendorsService {
*/
private async vendorsHaveNoBillsOrThrowError(
tenantId: number,
vendorsIds: number[]
vendorsIds: number[],
) {
const { billRepository } = this.tenancy.repositories(tenantId);
@@ -273,8 +277,8 @@ export default class VendorsService {
);
const billsVendorsIds = vendorsBills.map((bill) => bill.vendorId);
// The difference between the vendors ids and bills vendors ids.
const vendorsHaveInvoices = difference(vendorsIds, billsVendorsIds);
// The intersection between vendors and vendors that have bills.
const vendorsHaveInvoices = intersection(vendorsIds, billsVendorsIds);
if (vendorsHaveInvoices.length > 0) {
throw new ServiceError('some_vendors_have_bills');