fix: writing the bill journal entries.

server/src/subscribers/bills.ts

@@ -37,11 +37,20 @@ export default class BillSubscriber {
    * Handles writing journal entries once bill created.
    */
   @On(events.bill.onCreated)
-  @On(events.bill.onEdited)
-  async handlerWriteJournalEntries({ tenantId, billId, bill }) {
+  async handlerWriteJournalEntriesOnCreate({ tenantId, bill }) {
     // Writes the journal entries for the given bill transaction.
     this.logger.info('[bill] writing bill journal entries.', { tenantId });
-    await this.billsService.recordJournalTransactions(tenantId, bill, billId);
+    await this.billsService.recordJournalTransactions(tenantId, bill);
+  }
+
+  /**
+   * Handles the overwriting journal entries once bill edited.
+   */
+  @On(events.bill.onEdited)
+  async handleOverwriteJournalEntriesOnEdit({ tenantId, bill }) {
+    // Overwrite the journal entries for the given bill transaction.
+    this.logger.info('[bill] overwriting bill journal entries.', { tenantId });
+    await this.billsService.recordJournalTransactions(tenantId, bill, true);
   }
 
   /**

server/src/subscribers/saleInvoices.ts

@@ -1,9 +1,10 @@
 import { Container } from 'typedi';
-import { On, EventSubscriber } from "event-dispatch";
+import { On, EventSubscriber } from 'event-dispatch';
 import events from 'subscribers/events';
 import TenancyService from 'services/Tenancy/TenancyService';
 import SettingsService from 'services/Settings/SettingsService';
 import SaleEstimateService from 'services/Sales/SalesEstimate';
+
 @EventSubscriber()
 export default class SaleInvoiceSubscriber {
   logger: any;
@@ -22,23 +23,36 @@ export default class SaleInvoiceSubscriber {
    * Handles customer balance increment once sale invoice created.
    */
   @On(events.saleInvoice.onCreated)
-  public async handleCustomerBalanceIncrement({ tenantId, saleInvoice, saleInvoiceId }) {
+  public async handleCustomerBalanceIncrement({
+    tenantId,
+    saleInvoice,
+    saleInvoiceId,
+  }) {
     const { customerRepository } = this.tenancy.repositories(tenantId);
 
-    this.logger.info('[sale_invoice] trying to increment customer balance.', { tenantId });
-    await customerRepository.changeBalance(saleInvoice.customerId, saleInvoice.balance);
+    this.logger.info('[sale_invoice] trying to increment customer balance.', {
+      tenantId,
+    });
+    await customerRepository.changeBalance(
+      saleInvoice.customerId,
+      saleInvoice.balance
+    );
   }
 
   /**
-   * 
+   * Marks the sale estimate as converted from the sale invoice once created.
    */
   @On(events.saleInvoice.onCreated)
-  public async handleMarkEstimateConvert({ tenantId, saleInvoice, saleInvoiceId }) {
-    if (saleInvoice.fromEstiamteId) {
+  public async handleMarkEstimateConvert({
+    tenantId,
+    saleInvoice,
+    saleInvoiceId,
+  }) {
+    if (saleInvoice.fromEstimateId) {
       this.saleEstimatesService.convertEstimateToInvoice(
         tenantId,
         saleInvoice.fromEstiamteId,
-        saleInvoiceId,
+        saleInvoiceId
       );
     }
   }
@@ -47,29 +61,42 @@ export default class SaleInvoiceSubscriber {
    * Handles customer balance diff balnace change once sale invoice edited.
    */
   @On(events.saleInvoice.onEdited)
-  public async onSaleInvoiceEdited({ tenantId, saleInvoice, oldSaleInvoice, saleInvoiceId }) {
+  public async onSaleInvoiceEdited({
+    tenantId,
+    saleInvoice,
+    oldSaleInvoice,
+    saleInvoiceId,
+  }) {
     const { customerRepository } = this.tenancy.repositories(tenantId);
 
-    this.logger.info('[sale_invoice] trying to change diff customer balance.', { tenantId });
+    this.logger.info('[sale_invoice] trying to change diff customer balance.', {
+      tenantId,
+    });
     await customerRepository.changeDiffBalance(
       saleInvoice.customerId,
       saleInvoice.balance,
       oldSaleInvoice.balance,
-      oldSaleInvoice.customerId,
-    )
+      oldSaleInvoice.customerId
+    );
   }
 
   /**
    * Handles customer balance decrement once sale invoice deleted.
    */
   @On(events.saleInvoice.onDeleted)
-  public async handleCustomerBalanceDecrement({ tenantId, saleInvoiceId, oldSaleInvoice }) {
+  public async handleCustomerBalanceDecrement({
+    tenantId,
+    saleInvoiceId,
+    oldSaleInvoice,
+  }) {
     const { customerRepository } = this.tenancy.repositories(tenantId);
 
-    this.logger.info('[sale_invoice] trying to decrement customer balance.', { tenantId });
-    await customerRepository.changeBalance( 
+    this.logger.info('[sale_invoice] trying to decrement customer balance.', {
+      tenantId,
+    });
+    await customerRepository.changeBalance(
       oldSaleInvoice.customerId,
-      oldSaleInvoice.balance * -1,
+      oldSaleInvoice.balance * -1
     );
   }
 
@@ -77,10 +104,14 @@ export default class SaleInvoiceSubscriber {
    * Handles sale invoice next number increment once invoice created.
    */
   @On(events.saleInvoice.onCreated)
-  public async handleInvoiceNextNumberIncrement({ tenantId, saleInvoiceId, saleInvoice }) {
+  public async handleInvoiceNextNumberIncrement({
+    tenantId,
+    saleInvoiceId,
+    saleInvoice,
+  }) {
     await this.settingsService.incrementNextNumber(tenantId, {
       key: 'next_number',
       group: 'sales_invoices',
     });
   }
-}
+}